public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/gem_blits: Don't test Y Tile for newer GPUs
@ 2023-01-18 13:42 Nirmoy Das
  2023-01-18 13:43 ` Das, Nirmoy
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Nirmoy Das @ 2023-01-18 13:42 UTC (permalink / raw)
  To: igt-dev; +Cc: Nirmoy Das

From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

Legacy Y Tile is no longer supported on newer GPUs.

Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Co-developed-by: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 tests/i915/gem_blits.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c
index d9296cf2d..577eb6bfc 100644
--- a/tests/i915/gem_blits.c
+++ b/tests/i915/gem_blits.c
@@ -793,6 +793,7 @@ igt_main
 	igt_subtest("basic") {
 		struct buffer *src, *dst;
 		unsigned int x, y;
+		int devid = intel_get_drm_devid(device.fd);
 
 		for (unsigned int height = 1; height <= 16; height <<= 2) {
 			for (unsigned int y0 = ZERO; y0 <= (height > 2 ? BELOW : ZERO); y0++) {
@@ -808,12 +809,28 @@ igt_main
 						for (unsigned int src_tiling = I915_TILING_NONE;
 						     src_tiling <= (device.gen >= 6 ? I915_TILING_Y : I915_TILING_X);
 						     src_tiling++) {
+
+							/*
+							 * Legacy Y Tile is not supported on newer GPUs so skip that.
+							 * Probably need more generic solution to detect and skip unsupported formats.
+							 */
+							if (intel_graphics_ver(devid) >= IP_VER(12, 60) && (src_tiling == I915_TILING_Y))
+								continue;
+
 							buffer_set_tiling(&device, src, src_tiling);
 
 							x = start_at(width, x0);
 							for (unsigned int dst_tiling = I915_TILING_NONE;
 							     dst_tiling <= (device.gen >= 6 ? I915_TILING_Y : I915_TILING_X);
 							     dst_tiling++) {
+
+								/*
+								 * Legacy Y Tile is not supported on newer GPUs so skip that.
+								 * Probably need more generic solution to detect and skip unsupported formats.
+								 */
+								if (intel_graphics_ver(devid) >= IP_VER(12, 60) && (dst_tiling == I915_TILING_Y))
+									continue;
+
 								buffer_set_tiling(&device, dst, dst_tiling);
 
 								for (enum mode down = CPU; down <= WC; down++) {
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-19 15:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-18 13:42 [igt-dev] [PATCH i-g-t] tests/gem_blits: Don't test Y Tile for newer GPUs Nirmoy Das
2023-01-18 13:43 ` Das, Nirmoy
2023-01-18 14:12 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-01-19 15:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox