Re: [PATCH i-g-t v3 06/10] tests/intel/xe_drm_fdinfo: Use usec for batch duration

[Nirmoy Das <nirmoy.das@linux.intel.com>]

On 8/27/2024 6:54 PM, Lucas De Marchi wrote:
> It's only used to control the time to usleep(), so use a better unit.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>   tests/intel/xe_drm_fdinfo.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/intel/xe_drm_fdinfo.c b/tests/intel/xe_drm_fdinfo.c
> index 68c21925c..9fb739fba 100644
> --- a/tests/intel/xe_drm_fdinfo.c
> +++ b/tests/intel/xe_drm_fdinfo.c
> @@ -73,7 +73,7 @@ struct pceu_cycles {
>   	uint64_t total_cycles;
>   };
>   
> -const unsigned long batch_duration_ns = (1 * NSEC_PER_SEC) / 2;
> +const unsigned long batch_duration_usec = (1 * USEC_PER_SEC) / 2;
>   
>   static const char *engine_map[] = {
>   	"rcs",
> @@ -517,7 +517,7 @@ single(int fd, struct drm_xe_engine_class_instance *hwe, unsigned int flags)
>   	if (flags & TEST_ISOLATION)
>   		read_engine_cycles(new_fd, pceu1[1]);
>   
> -	usleep(batch_duration_ns / 1000);
> +	usleep(batch_duration_usec);
>   	if (flags & TEST_TRAILING_IDLE)
>   		spin_sync_end(fd, ctx);
>   
> @@ -553,7 +553,7 @@ busy_check_all(int fd, struct drm_xe_engine_class_instance *hwe, unsigned int fl
>   	}
>   
>   	read_engine_cycles(fd, pceu1);
> -	usleep(batch_duration_ns / 1000);
> +	usleep(batch_duration_usec);
>   	if (flags & TEST_TRAILING_IDLE)
>   		spin_sync_end(fd, ctx);
>   	read_engine_cycles(fd, pceu2);
> @@ -580,7 +580,7 @@ single_destroy_queue(int fd, struct drm_xe_engine_class_instance *hwe)
>   	spin_sync_start(fd, ctx);
>   
>   	read_engine_cycles(fd, pceu1);
> -	usleep(batch_duration_ns / 1000);
> +	usleep(batch_duration_usec);
>   
>   	/* destroy queue before sampling again */
>   	spin_sync_end(fd, ctx);
> @@ -619,7 +619,7 @@ most_busy_check_all(int fd, struct drm_xe_engine_class_instance *hwe,
>   	}
>   
>   	read_engine_cycles(fd, pceu1);
> -	usleep(batch_duration_ns / 1000);
> +	usleep(batch_duration_usec);
>   	if (flags & TEST_TRAILING_IDLE)
>   		xe_for_each_engine_class(class)
>   			spin_sync_end(fd, ctx[class]);
> @@ -663,7 +663,7 @@ all_busy_check_all(int fd, unsigned int flags)
>   	}
>   
>   	read_engine_cycles(fd, pceu1);
> -	usleep(batch_duration_ns / 1000);
> +	usleep(batch_duration_usec);
>   	if (flags & TEST_TRAILING_IDLE)
>   		xe_for_each_engine_class(class)
>   			spin_sync_end(fd, ctx[class]);