From: Jani Nikula <jani.nikula@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, ville.syrjala@linux.intel.com
Subject: Re: [PATCH i-g-t 1/4] tests/kms_chamelium_color_pipeline: prefer igt_crtc_name() over kmstest_pipe_name()
Date: Mon, 14 Sep 2026 11:06:26 +0300 [thread overview]
Message-ID: <d7db1c124f95fc39d68b0b192b1e23104ef278f1@intel.com> (raw)
In-Reply-To: <20260902143415.zgtnwjl5fg37co7u@kamilkon-DESK.igk.intel.com>
On Wed, 02 Sep 2026, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi Jani,
> On 2026-09-01 at 11:46:37 +0300, Jani Nikula wrote:
>> Reduce the direct pipe usage.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> LGTM
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Thanks for the reviews, pushed the lot to master.
BR,
Jani.
>
> Regards,
> Kamil
>
>> ---
>> tests/chamelium/kms_chamelium_color_pipeline.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/chamelium/kms_chamelium_color_pipeline.c b/tests/chamelium/kms_chamelium_color_pipeline.c
>> index db6107221d51..ee096f711a88 100644
>> --- a/tests/chamelium/kms_chamelium_color_pipeline.c
>> +++ b/tests/chamelium/kms_chamelium_color_pipeline.c
>> @@ -188,7 +188,7 @@ test_plane_colorops(data_t *data, igt_crtc_t *crtc,
>> if (!igt_plane_has_prop(plane, IGT_PLANE_COLOR_PIPELINE))
>> continue;
>>
>> - igt_dynamic_f("pipe-%s-plane-%u", kmstest_pipe_name(crtc->pipe), plane_id)
>> + igt_dynamic_f("pipe-%s-plane-%u", igt_crtc_name(crtc), plane_id)
>> _test_plane_colorops(data, plane, fb_colors,
>> exp_colors, colorops,
>> data->ports[port_idx]);
>> --
>> 2.47.3
>>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-09-14 8:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 8:46 [PATCH i-g-t 0/4] igt: rename pipe to hardware_pipe Jani Nikula
2026-09-01 8:46 ` [PATCH i-g-t 1/4] tests/kms_chamelium_color_pipeline: prefer igt_crtc_name() over kmstest_pipe_name() Jani Nikula
2026-09-02 14:34 ` Kamil Konieczny
2026-09-14 8:06 ` Jani Nikula [this message]
2026-09-01 8:46 ` [PATCH i-g-t 2/4] tests/intel/kms_joiner_helper: iterate CRTCs instead of pipes Jani Nikula
2026-09-02 14:45 ` Kamil Konieczny
2026-09-02 21:40 ` Jani Nikula
2026-09-03 11:31 ` Kamil Konieczny
2026-09-01 8:46 ` [PATCH i-g-t 3/4] lib/kms: rename enum pipe to hardware_pipe, crtc->pipe to crtc->hardware_pipe Jani Nikula
2026-09-02 17:33 ` Kamil Konieczny
2026-09-01 8:46 ` [PATCH i-g-t 4/4] lib/kms: use enum hardware_pipe for __intel_get_pipe_from_crtc_index() return type Jani Nikula
2026-09-03 11:39 ` Kamil Konieczny
2026-09-01 23:01 ` ✓ i915.CI.BAT: success for igt: rename pipe to hardware_pipe Patchwork
2026-09-02 7:15 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-02 13:29 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-02 14:21 ` ✗ i915.CI.Full: failure " Patchwork
2026-09-07 8:09 ` [PATCH i-g-t 0/4] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7db1c124f95fc39d68b0b192b1e23104ef278f1@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox