Re: [PATCH i-g-t 0/5] tests/intel/kms_cdclk: Refactor mode setting and CD clock verification

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 2/18/2025 3:05 AM, Swati Sharma wrote:
> Based on the review comments received, add highres and lowres
> functions to lib and made corresponding changes in the lib.
> On top, broken initial patches into smaller patches to better
> review.
>
> Swati Sharma (5):
>    lib/igt_kms: Add func() to read and parse cdclk debugfs
>    lib/igt_kms: Add highres() and lowres() func
>    tests/intel/kms_cdclk: Add conditions to filter valid outputs
>    tests/intel/kms_cdclk: Introduce set_mode()
>    tests/intel/kms_cdclk: Use igt_get_max_cdclk()

Minor changes suggested in Patch#1.

Series looks good to me.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


>
>   lib/igt_kms.c             | 110 ++++++++++++++++----
>   lib/igt_kms.h             |   4 +
>   tests/intel/kms_cdclk.c   | 207 +++++++++++++++-----------------------
>   tests/intel/kms_dsc.c     |  14 +--
>   tests/kms_display_modes.c |  14 +--
>   5 files changed, 177 insertions(+), 172 deletions(-)
>