Re: [PATCH i-g-t v3 1/6] tests: s/check_dc_counter/assert_dc_counter

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

On 23-04-2026 11:03 pm, Jeevan B wrote:
> Rename function name.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>

LGTM:
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
>   tests/intel/kms_pm_dc.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
> index 423a5c4a4..c8cfa300c 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -110,7 +110,7 @@ typedef struct {
>   	bool runtime_suspend_disabled;
>   } data_t;
>   
> -static void check_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count);
> +static void assert_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count);
>   
>   static void set_output_on_pipe_b(data_t *data)
>   {
> @@ -257,7 +257,7 @@ static void create_color_fb(data_t *data, igt_fb_t *fb, color_t *fb_color)
>   	paint_rectangles(data, data->mode, fb_color, fb);
>   }
>   
> -static void check_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count)
> +static void assert_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count)
>   {
>   	igt_assert_f(igt_dc_state_wait_entry(data->debugfs_fd, dc_flag, prev_dc_count),
>   		     "%s state is not achieved\n%s:\n%s\n", igt_dc_state_name(dc_flag),
> @@ -265,7 +265,7 @@ static void check_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count)
>   		     PWR_DOMAIN_INFO));
>   }
>   
> -static void check_dc_counter_negative(data_t *data, int dc_flag, uint32_t prev_dc_count)
> +static void assert_dc_counter_negative(data_t *data, int dc_flag, uint32_t prev_dc_count)
>   {
>   	igt_assert_f(!igt_dc_state_wait_entry(data->debugfs_fd, dc_flag, prev_dc_count),
>   		     "%s state is achieved\n%s:\n%s\n", igt_dc_state_name(dc_flag),
> @@ -346,7 +346,7 @@ static void test_dc5_retention_flops(data_t *data, int dc_flag)
>   	set_output_on_pipe_b(data);
>   	setup_primary(data);
>   	igt_assert(psr_wait_entry(data->debugfs_fd, data->op_psr_mode, data->output));
> -	check_dc_counter(data, dc_flag, dc_counter_before_psr);
> +	assert_dc_counter(data, dc_flag, dc_counter_before_psr);
>   	cleanup_dc_psr(data);
>   }
>   
> @@ -360,7 +360,7 @@ static void test_dc_state_psr(data_t *data, int dc_flag)
>   	setup_primary(data);
>   	igt_require(!psr_disabled_check(data->debugfs_fd));
>   	igt_assert(psr_wait_entry(data->debugfs_fd, data->op_psr_mode, data->output));
> -	check_dc_counter(data, dc_flag, dc_counter_before_psr);
> +	assert_dc_counter(data, dc_flag, dc_counter_before_psr);
>   	psr_sink_error_check(data->debugfs_fd, data->op_psr_mode, data->output);
>   	cleanup_dc_psr(data);
>   }
> @@ -439,7 +439,7 @@ static void test_dc_state_dpms(data_t *data, int dc_flag)
>   	setup_dc_dpms(data);
>   	dc_counter = igt_read_dc_counter(data->debugfs_fd, dc_flag);
>   	dpms_off(data);
> -	check_dc_counter(data, dc_flag, dc_counter);
> +	assert_dc_counter(data, dc_flag, dc_counter);
>   	dpms_on(data);
>   	cleanup_dc_dpms(data);
>   }
> @@ -452,7 +452,7 @@ static void test_dc_state_dpms_negative(data_t *data, int dc_flag)
>   	setup_dc_dpms(data);
>   	dc_counter = igt_read_dc_counter(data->debugfs_fd, dc_flag);
>   	dpms_on(data);
> -	check_dc_counter_negative(data, dc_flag, dc_counter);
> +	assert_dc_counter_negative(data, dc_flag, dc_counter);
>   	cleanup_dc_dpms(data);
>   }
>