public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: add missing include in header
Date: Fri, 20 Jan 2023 22:56:17 +0530	[thread overview]
Message-ID: <fc3bcc51-d1f0-6fb9-fb2d-3fc383e732a6@intel.com> (raw)
In-Reply-To: <20230120170027.56231-1-kamil.konieczny@linux.intel.com>

Hi Kamil,

Thanks for the patch.
Getting following error while build.
WARNING: custom_target 'i915-perf-metrics-mtlgt3' has more than one 
output! Using the first one.

Can you check once?

On 20-Jan-23 10:30 PM, Kamil Konieczny wrote:
> Direct include of lib igt_fb header breaks builds with errors
> 
> xf86drmMode.h:533:2: error: unknown type name ‘uint32_t’
> 
> Fixed it with adding proper include in header.
> 
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
> ---
> Maybe it is worth to put this patch as first, together with
> https://patchwork.freedesktop.org/series/113045/
> tests/i915/kms_dsc: Reorg
> so it can be tested in CI.

 >> Sure, I'll float the series.

> ---
>   lib/igt_fb.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
> index 6995b14b..73bdfc86 100644
> --- a/lib/igt_fb.h
> +++ b/lib/igt_fb.h
> @@ -32,6 +32,7 @@
>   #include <cairo.h>
>   #include <stddef.h>
>   #include <stdbool.h>
> +#include <stdint.h>
>   #include <drm_fourcc.h>
>   #include <xf86drmMode.h>
>   

-- 
~Swati Sharma

  reply	other threads:[~2023-01-20 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 17:00 [igt-dev] [PATCH i-g-t] lib/igt_fb: add missing include in header Kamil Konieczny
2023-01-20 17:26 ` Swati Sharma [this message]
2023-01-20 18:36 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc3bcc51-d1f0-6fb9-fb2d-3fc383e732a6@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox