[igt-dev] [PATCH i-g-t] lib/igt_fb: add missing include in header

[igt-dev] [PATCH i-g-t] lib/igt_fb: add missing include in header

[Kamil Konieczny]

Direct include of lib igt_fb header breaks builds with errors

xf86drmMode.h:533:2: error: unknown type name ‘uint32_t’

Fixed it with adding proper include in header.

Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

---
Maybe it is worth to put this patch as first, together with
https://patchwork.freedesktop.org/series/113045/
tests/i915/kms_dsc: Reorg
so it can be tested in CI.
---
 lib/igt_fb.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 6995b14b..73bdfc86 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -32,6 +32,7 @@
 #include <cairo.h>
 #include <stddef.h>
 #include <stdbool.h>
+#include <stdint.h>
 #include <drm_fourcc.h>
 #include <xf86drmMode.h>
 
-- 
2.37.2

Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: add missing include in header

[Swati Sharma]

Hi Kamil,

Thanks for the patch.
Getting following error while build.
WARNING: custom_target 'i915-perf-metrics-mtlgt3' has more than one 
output! Using the first one.

Can you check once?

On 20-Jan-23 10:30 PM, Kamil Konieczny wrote:
> Direct include of lib igt_fb header breaks builds with errors
> 
> xf86drmMode.h:533:2: error: unknown type name ‘uint32_t’
> 
> Fixed it with adding proper include in header.
> 
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
> ---
> Maybe it is worth to put this patch as first, together with
> https://patchwork.freedesktop.org/series/113045/
> tests/i915/kms_dsc: Reorg
> so it can be tested in CI.

 >> Sure, I'll float the series.

> ---
>   lib/igt_fb.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
> index 6995b14b..73bdfc86 100644
> --- a/lib/igt_fb.h
> +++ b/lib/igt_fb.h
> @@ -32,6 +32,7 @@
>   #include <cairo.h>
>   #include <stddef.h>
>   #include <stdbool.h>
> +#include <stdint.h>
>   #include <drm_fourcc.h>
>   #include <xf86drmMode.h>
>   

-- 
~Swati Sharma

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_fb: add missing include in header

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5524 bytes --]

== Series Details ==

Series: lib/igt_fb: add missing include in header
URL   : https://patchwork.freedesktop.org/series/113164/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12618 -> IGTPW_8387
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8387 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8387, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/index.html

Participating hosts (36 -> 36)
------------------------------

  Additional (2): fi-kbl-soraka fi-bsw-kefka 
  Missing    (2): fi-rkl-11600 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8387:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@guc:
    - fi-kbl-soraka:      NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-kbl-soraka/igt@i915_selftest@live@guc.html

  
Known issues
------------

  Here are the changes found in IGTPW_8387 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_gttfill@basic:
    - fi-pnv-d510:        [PASS][2] -> [FAIL][3] ([i915#7229])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-pnv-d510/igt@gem_exec_gttfill@basic.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][6] ([i915#1886])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@kms_chamelium_frames@hdmi-crc-fast:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-bsw-kefka:       NOTRUN -> [SKIP][8] ([fdo#109271]) +26 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-bsw-kefka/igt@prime_vgem@basic-fence-flip.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - {bat-jsl-1}:        [DMESG-FAIL][9] ([i915#5334]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@slpc:
    - {bat-rpls-1}:       [DMESG-FAIL][11] ([i915#6367]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/bat-rpls-1/igt@i915_selftest@live@slpc.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/bat-rpls-1/igt@i915_selftest@live@slpc.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
    - fi-bsw-n3050:       [FAIL][13] ([i915#6298]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
  [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
  [i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
  [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
  [i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7129 -> IGTPW_8387

  CI-20190529: 20190529
  CI_DRM_12618: 7ba8ff20ba23bc940e928ffe3a9054225fff418e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8387: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/index.html
  IGT_7129: 7816773163a1b0d248dd9dd34d14e632ad8903be @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8387/index.html

[-- Attachment #2: Type: text/html, Size: 6184 bytes --]