[PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[anonymoustranquillity]

Hello, 

there seems to be a problem with rendering in the interactive mode in intel_gpu_top, seems to be a simple off-by-one. Below is a patch. I am new to contributing via email, so I apologize if I did something wrong - I tried to follow CONTRIBUTING.md to the best of my ability.

Have a nice day,
- Ity.

---
 tools/intel_gpu_top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 046ead15a..24363e72f 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
 			len += *class_w;
 		}
 
-		printf(" %-*s\n", con_w - len - 1, c->print_name);
+		printf(" %-*s\n", con_w - len - 2, c->print_name);
 	} else if (output_mode == JSON) {
 		char buf[64];
 
-- 
2.43.0

✓ CI.xeBAT: success for tools/intel_gpu_top: Fix misaligned rendering

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

== Series Details ==

Series: tools/intel_gpu_top: Fix misaligned rendering
URL   : https://patchwork.freedesktop.org/series/128774/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7673_BAT -> XEIGTPW_10532_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in XEIGTPW_10532_BAT that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@xe_exec_threads@threads-mixed-fd-basic:
    - bat-dg2-oem2:       [TIMEOUT][1] -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7673/bat-dg2-oem2/igt@xe_exec_threads@threads-mixed-fd-basic.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10532/bat-dg2-oem2/igt@xe_exec_threads@threads-mixed-fd-basic.html

  


Build changes
-------------

  * IGT: IGT_7673 -> IGTPW_10532
  * Linux: xe-627-d1296191ba3a2fb8300d9887bd56b8613c1bc18d -> xe-629-3a1d727c0061b96ddf8e653130f94ab331e2f065

  IGTPW_10532: 10532
  IGT_7673: 7673
  xe-627-d1296191ba3a2fb8300d9887bd56b8613c1bc18d: d1296191ba3a2fb8300d9887bd56b8613c1bc18d
  xe-629-3a1d727c0061b96ddf8e653130f94ab331e2f065: 3a1d727c0061b96ddf8e653130f94ab331e2f065

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10532/index.html

[-- Attachment #2: Type: text/html, Size: 2021 bytes --]

✗ Fi.CI.BAT: failure for tools/intel_gpu_top: Fix misaligned rendering

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 9209 bytes --]

== Series Details ==

Series: tools/intel_gpu_top: Fix misaligned rendering
URL   : https://patchwork.freedesktop.org/series/128774/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14123 -> IGTPW_10532
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_10532 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_10532, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/index.html

Participating hosts (36 -> 38)
------------------------------

  Additional (3): bat-dg2-9 fi-bsw-nick bat-adls-6 
  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_10532:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_busy@basic@flip:
    - fi-apl-guc:         [PASS][1] -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14123/fi-apl-guc/igt@kms_busy@basic@flip.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/fi-apl-guc/igt@kms_busy@basic@flip.html

  
Known issues
------------

  Here are the changes found in IGTPW_10532 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-bsw-nick:        NOTRUN -> [SKIP][3] ([fdo#109271]) +15 other tests skip
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/fi-bsw-nick/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_mmap@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][4] ([i915#4083])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@gem_mmap@basic.html

  * igt@gem_mmap_gtt@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][5] ([i915#4077]) +2 other tests skip
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@gem_mmap_gtt@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][6] ([i915#4079]) +1 other test skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@gem_render_tiled_blits@basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-9:          NOTRUN -> [SKIP][7] ([i915#6621])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@i915_pm_rps@basic-api.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-atsm-1:         NOTRUN -> [SKIP][8] ([i915#6645])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][9] ([i915#5190])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][10] ([i915#4215] / [i915#5190])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
    - bat-dg2-9:          NOTRUN -> [SKIP][11] ([i915#4212]) +7 other tests skip
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][12] ([i915#4103] / [i915#4213]) +1 other test skip
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-dg2-9:          NOTRUN -> [SKIP][13] ([fdo#109285])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-dg2-9:          NOTRUN -> [SKIP][14] ([i915#5274])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-atsm-1:         NOTRUN -> [SKIP][15] ([i915#1836])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-atsm-1/igt@kms_pipe_crc_basic@suspend-read-crc.html

  * igt@kms_pm_backlight@basic-brightness:
    - bat-dg2-9:          NOTRUN -> [SKIP][16] ([i915#5354])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_pm_backlight@basic-brightness.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-dg2-9:          NOTRUN -> [SKIP][17] ([i915#3555])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-flip:
    - bat-dg2-9:          NOTRUN -> [SKIP][18] ([i915#3708])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html

  * igt@prime_vgem@basic-fence-mmap:
    - bat-dg2-9:          NOTRUN -> [SKIP][19] ([i915#3708] / [i915#4077]) +1 other test skip
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html

  * igt@prime_vgem@basic-write:
    - bat-dg2-9:          NOTRUN -> [SKIP][20] ([i915#3291] / [i915#3708]) +2 other tests skip
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-dg2-9/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - bat-rpls-2:         [ABORT][21] -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14123/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@gem_contexts:
    - bat-atsm-1:         [INCOMPLETE][23] -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14123/bat-atsm-1/igt@i915_selftest@live@gem_contexts.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-atsm-1/igt@i915_selftest@live@gem_contexts.html

  * igt@i915_selftest@live@hangcheck:
    - {bat-rpls-3}:       [DMESG-WARN][25] ([i915#5591]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14123/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
    - fi-skl-guc:         [DMESG-FAIL][27] -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14123/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/fi-skl-guc/igt@i915_selftest@live@hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
  [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
  [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7673 -> IGTPW_10532

  CI-20190529: 20190529
  CI_DRM_14123: 8469921d0f3c869f3185dfce2b171b276f4c8459 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10532: 10532
  IGT_7673: 7673

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10532/index.html

[-- Attachment #2: Type: text/html, Size: 10188 bytes --]

Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[Kamil Konieczny]

Hi anonymoustranquillity,
On 2024-01-14 at 21:26:36 +0000, anonymoustranquillity@proton.me wrote:
> Hello, 
> 
> there seems to be a problem with rendering in the interactive
> mode in intel_gpu_top, seems to be a simple off-by-one. Below
> is a patch. I am new to contributing via email, so I apologize
> if I did something wrong - I tried to follow CONTRIBUTING.md
> to the best of my ability.
> 
> Have a nice day,
> - Ity.

Thank you for patch, if you would like to use git and re-send
with the help of 'git format-patch -1' and then
'git send e-mail 0001-your-first.patch'

Before that setup your real name and e-mail in git configuration,
like "First Last <your@email-address.me>"

If it is too much bother someone can take it from here
but without your real name we cannot give you contribution
(except for link into patchwork).

+cc Tvrtko

Regards,
Kamil

> 
> ---
>  tools/intel_gpu_top.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 046ead15a..24363e72f 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>  			len += *class_w;
>  		}
>  
> -		printf(" %-*s\n", con_w - len - 1, c->print_name);
> +		printf(" %-*s\n", con_w - len - 2, c->print_name);
>  	} else if (output_mode == JSON) {
>  		char buf[64];
>  
> -- 
> 2.43.0
> 

Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[Tvrtko Ursulin]

Hi,

On 15/01/2024 15:29, Kamil Konieczny wrote:
> Hi anonymoustranquillity,
> On 2024-01-14 at 21:26:36 +0000, anonymoustranquillity@proton.me wrote:
>> Hello,
>>
>> there seems to be a problem with rendering in the interactive
>> mode in intel_gpu_top, seems to be a simple off-by-one. Below
>> is a patch. I am new to contributing via email, so I apologize
>> if I did something wrong - I tried to follow CONTRIBUTING.md
>> to the best of my ability.

What renders incorrectly? Asking since locally things look fine for me.

Regards,

Tvrtko

>>
>> Have a nice day,
>> - Ity.
> 
> Thank you for patch, if you would like to use git and re-send
> with the help of 'git format-patch -1' and then
> 'git send e-mail 0001-your-first.patch'
> 
> Before that setup your real name and e-mail in git configuration,
> like "First Last <your@email-address.me>"
> 
> If it is too much bother someone can take it from here
> but without your real name we cannot give you contribution
> (except for link into patchwork).
> 
> +cc Tvrtko
> 
> Regards,
> Kamil
> 
>>
>> ---
>>   tools/intel_gpu_top.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index 046ead15a..24363e72f 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>>   			len += *class_w;
>>   		}
>>   
>> -		printf(" %-*s\n", con_w - len - 1, c->print_name);
>> +		printf(" %-*s\n", con_w - len - 2, c->print_name);
>>   	} else if (output_mode == JSON) {
>>   		char buf[64];
>>   
>> -- 
>> 2.43.0
>>

Fw: Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[anonymoustranquillity]

I forgot to include the mailing list in the CC, I apologize. Forwarding it.




------- Forwarded Message -------
From: anonymoustranquillity@proton.me <anonymoustranquillity@proton.me>
Date: On Tuesday, January 16th, 2024 at 10:39 AM
Subject: Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>


> 
> 
> 
> Hello,
> 
> I have not used send-email as my email provider (protonmail) does not seem to support SMTP (I have been meaning to switch to a self hosted provider for a while now, haven't been able to yet).
> 
> This email is the one I use for FOSS contributions, it's the same one as the one I used to sign up to the freedesktop gitlab (https://gitlab.freedesktop.org/tranquillity-codes). I am unable to include my real name due to personal reasons related to my safety (since it will be visible publicly).
> 
> Running intel_gpu_top on some terminal sizes seems to overflow a character at end of line N to the first character of line N+1, misalign the column marker for PIDs, and sometimes hide the first few lines describing the engines. I used alacritty on X11 to test this.
> 
> Thank you for your time,
> Ity
> 
> On Tuesday, January 16th, 2024 at 9:49 AM, Tvrtko Ursulin tvrtko.ursulin@linux.intel.com wrote:
> 
> 
> 
> > Hi,
> > 
> > On 15/01/2024 15:29, Kamil Konieczny wrote:
> > 
> > > Hi anonymoustranquillity,
> > > On 2024-01-14 at 21:26:36 +0000, anonymoustranquillity@proton.me wrote:
> > > 
> > > > Hello,
> > > > 
> > > > there seems to be a problem with rendering in the interactive
> > > > mode in intel_gpu_top, seems to be a simple off-by-one. Below
> > > > is a patch. I am new to contributing via email, so I apologize
> > > > if I did something wrong - I tried to follow CONTRIBUTING.md
> > > > to the best of my ability.
> > 
> > What renders incorrectly? Asking since locally things look fine for me.
> > 
> > Regards,
> > 
> > Tvrtko
> > 
> > > > Have a nice day,
> > > > - Ity.
> > > 
> > > Thank you for patch, if you would like to use git and re-send
> > > with the help of 'git format-patch -1' and then
> > > 'git send e-mail 0001-your-first.patch'
> > > 
> > > Before that setup your real name and e-mail in git configuration,
> > > like "First Last your@email-address.me"
> > > 
> > > If it is too much bother someone can take it from here
> > > but without your real name we cannot give you contribution
> > > (except for link into patchwork).
> > > 
> > > +cc Tvrtko
> > > 
> > > Regards,
> > > Kamil
> > > 
> > > > ---
> > > > tools/intel_gpu_top.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> > > > index 046ead15a..24363e72f 100644
> > > > --- a/tools/intel_gpu_top.c
> > > > +++ b/tools/intel_gpu_top.c
> > > > @@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
> > > > len += *class_w;
> > > > }
> > > > 
> > > > - printf(" %-*s\n", con_w - len - 1, c->print_name);
> > > > + printf(" %-*s\n", con_w - len - 2, c->print_name);
> > > > } else if (output_mode == JSON) {
> > > > char buf[64];
> > > > 
> > > > --
> > > > 2.43.0

Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[anonymoustranquillity]

[-- Attachment #1: Type: text/plain, Size: 3897 bytes --]

I have done some further testing, and it seems that my patch does in fact not resolve the issue. I am attaching a few screenshots that I was able to reproduce. I am not sure why the patch seemed to work yesterday, I apologize, I should have done more thorough testing.


On Tuesday, January 16th, 2024 at 12:48 PM, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:

> 
> 
> 
> On 16/01/2024 09:39, anonymoustranquillity@proton.me wrote:
> 
> > Hello,
> > 
> > I have not used send-email as my email provider (protonmail) does not seem to support SMTP (I have been meaning to switch to a self hosted provider for a while now, haven't been able to yet).
> > 
> > This email is the one I use for FOSS contributions, it's the same one as the one I used to sign up to the freedesktop gitlab (https://gitlab.freedesktop.org/tranquillity-codes). I am unable to include my real name due to personal reasons related to my safety (since it will be visible publicly).
> > 
> > Running intel_gpu_top on some terminal sizes seems to overflow a character at end of line N to the first character of line N+1, misalign the column marker for PIDs, and sometimes hide the first few lines describing the engines. I used alacritty on X11 to test this.
> 
> 
> I can't repro it I'm afraid. Tried xterm, alactritty and konsole.
> Resizing the windows to large or small it always re-renders mostly OK.
> Mostly because if you go too small then parts of the UI start to get
> dropped but can't really show everything if there is no space.
> 
> What terminal size should I try, at least roughly? Or could you share a
> screenshot somewhere?
> 
> Regards,
> 
> Tvrtko
> 
> > Thank you for your time,
> > Ity
> > 
> > On Tuesday, January 16th, 2024 at 9:49 AM, Tvrtko Ursulin tvrtko.ursulin@linux.intel.com wrote:
> > 
> > > Hi,
> > > 
> > > On 15/01/2024 15:29, Kamil Konieczny wrote:
> > > 
> > > > Hi anonymoustranquillity,
> > > > On 2024-01-14 at 21:26:36 +0000, anonymoustranquillity@proton.me wrote:
> > > > 
> > > > > Hello,
> > > > > 
> > > > > there seems to be a problem with rendering in the interactive
> > > > > mode in intel_gpu_top, seems to be a simple off-by-one. Below
> > > > > is a patch. I am new to contributing via email, so I apologize
> > > > > if I did something wrong - I tried to follow CONTRIBUTING.md
> > > > > to the best of my ability.
> > > 
> > > What renders incorrectly? Asking since locally things look fine for me.
> > > 
> > > Regards,
> > > 
> > > Tvrtko
> > > 
> > > > > Have a nice day,
> > > > > - Ity.
> > > > 
> > > > Thank you for patch, if you would like to use git and re-send
> > > > with the help of 'git format-patch -1' and then
> > > > 'git send e-mail 0001-your-first.patch'
> > > > 
> > > > Before that setup your real name and e-mail in git configuration,
> > > > like "First Last your@email-address.me"
> > > > 
> > > > If it is too much bother someone can take it from here
> > > > but without your real name we cannot give you contribution
> > > > (except for link into patchwork).
> > > > 
> > > > +cc Tvrtko
> > > > 
> > > > Regards,
> > > > Kamil
> > > > 
> > > > > ---
> > > > > tools/intel_gpu_top.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> > > > > index 046ead15a..24363e72f 100644
> > > > > --- a/tools/intel_gpu_top.c
> > > > > +++ b/tools/intel_gpu_top.c
> > > > > @@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
> > > > > len += *class_w;
> > > > > }
> > > > > 
> > > > > - printf(" %-*s\n", con_w - len - 1, c->print_name);
> > > > > + printf(" %-*s\n", con_w - len - 2, c->print_name);
> > > > > } else if (output_mode == JSON) {
> > > > > char buf[64];
> > > > > 
> > > > > --
> > > > > 2.43.0

[-- Attachment #2: issue-02-attachment.png --]
[-- Type: image/png, Size: 244451 bytes --]

[-- Attachment #3: issue-01-attachment.png --]
[-- Type: image/png, Size: 70199 bytes --]

Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering

[Tvrtko Ursulin]

On 16/01/2024 12:32, anonymoustranquillity@proton.me wrote:
> I have done some further testing, and it seems that my patch does in fact not resolve the issue. I am attaching a few screenshots that I was able to reproduce. I am not sure why the patch seemed to work yesterday, I apologize, I should have done more thorough testing.

No worries.

It seems load in the percentage bar is the key to repro. Can you try this:

diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 046ead15a122..5b4f94d7de7a 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1015,9 +1015,8 @@ print_percentage_bar(double percent, double max, 
int max_len, bool numeric)
                 printf("%s", bars[i]);

         len -= (bar_len + (w - 1)) / w;
-       if (len < 1)
-               return;
-       n_spaces(len);
+       if (len >= 1)
+               n_spaces(len);

         putchar('|');

Regards,

Tvrtko

> 
> 
> On Tuesday, January 16th, 2024 at 12:48 PM, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> 
>>
>>
>>
>> On 16/01/2024 09:39, anonymoustranquillity@proton.me wrote:
>>
>>> Hello,
>>>
>>> I have not used send-email as my email provider (protonmail) does not seem to support SMTP (I have been meaning to switch to a self hosted provider for a while now, haven't been able to yet).
>>>
>>> This email is the one I use for FOSS contributions, it's the same one as the one I used to sign up to the freedesktop gitlab (https://gitlab.freedesktop.org/tranquillity-codes). I am unable to include my real name due to personal reasons related to my safety (since it will be visible publicly).
>>>
>>> Running intel_gpu_top on some terminal sizes seems to overflow a character at end of line N to the first character of line N+1, misalign the column marker for PIDs, and sometimes hide the first few lines describing the engines. I used alacritty on X11 to test this.
>>
>>
>> I can't repro it I'm afraid. Tried xterm, alactritty and konsole.
>> Resizing the windows to large or small it always re-renders mostly OK.
>> Mostly because if you go too small then parts of the UI start to get
>> dropped but can't really show everything if there is no space.
>>
>> What terminal size should I try, at least roughly? Or could you share a
>> screenshot somewhere?
>>
>> Regards,
>>
>> Tvrtko
>>
>>> Thank you for your time,
>>> Ity
>>>
>>> On Tuesday, January 16th, 2024 at 9:49 AM, Tvrtko Ursulin tvrtko.ursulin@linux.intel.com wrote:
>>>
>>>> Hi,
>>>>
>>>> On 15/01/2024 15:29, Kamil Konieczny wrote:
>>>>
>>>>> Hi anonymoustranquillity,
>>>>> On 2024-01-14 at 21:26:36 +0000, anonymoustranquillity@proton.me wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> there seems to be a problem with rendering in the interactive
>>>>>> mode in intel_gpu_top, seems to be a simple off-by-one. Below
>>>>>> is a patch. I am new to contributing via email, so I apologize
>>>>>> if I did something wrong - I tried to follow CONTRIBUTING.md
>>>>>> to the best of my ability.
>>>>
>>>> What renders incorrectly? Asking since locally things look fine for me.
>>>>
>>>> Regards,
>>>>
>>>> Tvrtko
>>>>
>>>>>> Have a nice day,
>>>>>> - Ity.
>>>>>
>>>>> Thank you for patch, if you would like to use git and re-send
>>>>> with the help of 'git format-patch -1' and then
>>>>> 'git send e-mail 0001-your-first.patch'
>>>>>
>>>>> Before that setup your real name and e-mail in git configuration,
>>>>> like "First Last your@email-address.me"
>>>>>
>>>>> If it is too much bother someone can take it from here
>>>>> but without your real name we cannot give you contribution
>>>>> (except for link into patchwork).
>>>>>
>>>>> +cc Tvrtko
>>>>>
>>>>> Regards,
>>>>> Kamil
>>>>>
>>>>>> ---
>>>>>> tools/intel_gpu_top.c | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>>>>>> index 046ead15a..24363e72f 100644
>>>>>> --- a/tools/intel_gpu_top.c
>>>>>> +++ b/tools/intel_gpu_top.c
>>>>>> @@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>>>>>> len += *class_w;
>>>>>> }
>>>>>>
>>>>>> - printf(" %-*s\n", con_w - len - 1, c->print_name);
>>>>>> + printf(" %-*s\n", con_w - len - 2, c->print_name);
>>>>>> } else if (output_mode == JSON) {
>>>>>> char buf[64];
>>>>>>
>>>>>> --
>>>>>> 2.43.0