From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Martin Kepplinger <martink@posteo.de>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
"Paul J. Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Martin Hecht <martin.hecht@avnet.eu>,
Zhi Mao <zhi.mao@mediatek.com>,
Alain Volmat <alain.volmat@foss.st.com>,
Mikhail Rudenko <mike.rudenko@gmail.com>,
Ricardo Ribalda <ribalda@kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Umang Jain <umang.jain@ideasonboard.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Dongchun Zhu <dongchun.zhu@mediatek.com>,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Todor Tomov <todor.too@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema
Date: Sat, 12 Oct 2024 20:24:30 +0300 [thread overview]
Message-ID: <20241012172430.GB5212@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-1-a2bb12a1796d@linaro.org>
Hi Bryan,
Thank you for the patch.
On Sat, Oct 12, 2024 at 04:02:50PM +0100, Bryan O'Donoghue wrote:
> Remove extraneous assigned-clock* from media/i2c/* schemas, retain in the
> relevant examples.
You may want to explain in the commit message *why* you're doing this.
The reason may not be straightforward for everybody. With that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Link: https://lore.kernel.org/linux-media/j7kgz2lyxnler5qwd7yiazdq6fmsv77kyozdrxf33h54ydakjz@uqjhwhoyv6re
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 8 --------
> Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml | 8 --------
> Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml | 8 --------
> Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 4 ----
> Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ----
> Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 4 ----
> Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ----
> Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml | 4 ----
> 8 files changed, 44 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 60f19e1152b33128cf3baa15b8c70a874ca6d52e..d18ead8f7fc43bfacc291aed85b5ca9166c46edb 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -28,12 +28,6 @@ properties:
> items:
> - description: Reference to the mclk clock.
>
> - assigned-clocks:
> - maxItems: 1
> -
> - assigned-clock-rates:
> - maxItems: 1
> -
> reset-gpios:
> description: Reference to the GPIO connected to the RESETB pin. Active low.
> maxItems: 1
> @@ -82,8 +76,6 @@ required:
> - compatible
> - reg
> - clocks
> - - assigned-clocks
> - - assigned-clock-rates
> - vddio-supply
> - vdda-supply
> - vddd-supply
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> index 1f497679168c8395a94b3867beb49b251ef621fc..622243cae03caa5d14aa312df40ef5907e190d2c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> @@ -20,12 +20,6 @@ properties:
> items:
> - description: XVCLK Clock
>
> - assigned-clocks:
> - maxItems: 1
> -
> - assigned-clock-rates:
> - maxItems: 1
> -
> dvdd-supply:
> description: Digital Domain Power Supply
>
> @@ -68,8 +62,6 @@ required:
> - compatible
> - reg
> - clocks
> - - assigned-clocks
> - - assigned-clock-rates
> - dvdd-supply
> - dovdd-supply
> - port
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> index 8a70e23ba6abed67d8b61c33bd7a261089bddda2..382d7de7a89bcea11be384a2a3800512994f9346 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> @@ -20,12 +20,6 @@ properties:
> items:
> - description: EXTCLK Clock
>
> - assigned-clocks:
> - maxItems: 1
> -
> - assigned-clock-rates:
> - maxItems: 1
> -
> dvdd-supply:
> description: Digital Domain Power Supply
>
> @@ -68,8 +62,6 @@ required:
> - compatible
> - reg
> - clocks
> - - assigned-clocks
> - - assigned-clock-rates
> - dvdd-supply
> - avdd-supply
> - dovdd-supply
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> index 79a7658f6d0547e4d6fb2267e5757eedf49fd416..38325cf318f7bd2cd60a4c7bbb6a65b54b855e26 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> @@ -27,10 +27,6 @@ properties:
> description: I2C address
> maxItems: 1
>
> - assigned-clocks: true
> - assigned-clock-parents: true
> - assigned-clock-rates: true
> -
> clocks:
> description: Clock frequency from 6 to 27MHz
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> index c978abc0cdb35cfe2b85069946cf1be435a58cb8..f0f9726a2add89492b8c56e17ed607841baa3a0d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> @@ -24,10 +24,6 @@ properties:
> - sony,imx258
> - sony,imx258-pdaf
>
> - assigned-clocks: true
> - assigned-clock-parents: true
> - assigned-clock-rates: true
> -
> clocks:
> description:
> Clock frequency from 6 to 27 MHz.
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> index bce57b22f7b63bd73f08d8831d9bb04858ef03e0..872b8288948b2bba743f2365a55165181df156ae 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> @@ -24,10 +24,6 @@ properties:
> description: I2C address
> maxItems: 1
>
> - assigned-clocks: true
> - assigned-clock-parents: true
> - assigned-clock-rates: true
> -
> clocks:
> description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> index 77bf3a4ee89db3b5d16149470c0380ef8f1aeac1..38bd1c7304a59bb5fea90954c1e4e626a7c86f2f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> @@ -24,10 +24,6 @@ properties:
> description: I2C address
> maxItems: 1
>
> - assigned-clocks: true
> - assigned-clock-parents: true
> - assigned-clock-rates: true
> -
> clocks:
> description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> index d9b7815650fdb890418fc96c828acc9147dfb6e8..ece1e17fe34553671e61c965eb1833c5eb08131b 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> @@ -26,10 +26,6 @@ properties:
> description: I2C address
> maxItems: 1
>
> - assigned-clocks: true
> - assigned-clock-parents: true
> - assigned-clock-rates: true
> -
> clocks:
> description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz
> maxItems: 1
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-10-12 17:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 15:02 [PATCH 0/2] media: i2c: Cleanup assigned-clocks and endpoint: properties: unevaluatedProperties: false Bryan O'Donoghue
2024-10-12 15:02 ` [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema Bryan O'Donoghue
2024-10-12 17:24 ` Laurent Pinchart [this message]
2024-10-14 7:43 ` Krzysztof Kozlowski
2024-10-14 8:29 ` Bryan O'Donoghue
2024-10-14 8:44 ` Krzysztof Kozlowski
2024-10-14 10:08 ` Bryan O'Donoghue
2024-10-14 10:20 ` Sakari Ailus
2024-10-14 10:34 ` Krzysztof Kozlowski
2024-10-14 10:46 ` Sakari Ailus
2024-10-14 20:34 ` Laurent Pinchart
2024-10-15 6:13 ` Krzysztof Kozlowski
2024-10-15 11:29 ` Laurent Pinchart
2024-10-15 16:46 ` Rob Herring
2024-10-16 7:47 ` Krzysztof Kozlowski
2024-10-12 15:02 ` [PATCH 2/2] media: dt-bindings: Use additionalProperties: false for endpoint: properties: Bryan O'Donoghue
2024-10-12 18:09 ` Laurent Pinchart
2024-10-13 10:44 ` Bryan O'Donoghue
2024-10-14 7:45 ` Krzysztof Kozlowski
2024-10-14 8:31 ` Bryan O'Donoghue
2024-10-14 8:47 ` Krzysztof Kozlowski
2024-10-14 9:03 ` Bryan O'Donoghue
2024-10-14 10:37 ` Krzysztof Kozlowski
2024-10-14 20:29 ` Laurent Pinchart
2024-10-15 6:11 ` Krzysztof Kozlowski
2024-10-15 11:28 ` Laurent Pinchart
2024-10-15 11:51 ` Krzysztof Kozlowski
2024-10-16 9:27 ` Laurent Pinchart
2024-10-15 19:44 ` Rob Herring
2024-10-15 22:45 ` Bryan O'Donoghue
2024-10-16 9:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012172430.GB5212@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alain.volmat@foss.st.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniele.alessandrelli@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.hecht@avnet.eu \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=paul.j.murphy@intel.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=quentin.schulz@theobroma-systems.com \
--cc=ribalda@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=todor.too@gmail.com \
--cc=tomm.merciai@gmail.com \
--cc=umang.jain@ideasonboard.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox