[PATCH v2 1/5] ARM: dts: lpc32xx: remove usb bus and elevate all children nodes

[PATCH v2 1/5] ARM: dts: lpc32xx: remove usb bus and elevate all children nodes

[Frank Li]

Remove usb bus and elevate all children nodes because usb bus is not
existed and only group usb devices logically.

Update register address and related full node name.

Fix below CHECK_DTBS warnings:
arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: usb (simple-bus): $nodename:0: 'usb' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
        from schema $id: http://devicetree.org/schemas/simple-bus.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- elevate usb children node
- fab leave unchange now utils finish discussion.
---
 arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 77 ++++++++++++--------------
 1 file changed, 35 insertions(+), 42 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
index 4dff0d7694322..d6243adbc05bc 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
+++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
@@ -86,51 +86,44 @@ dma: dma-controller@31000000 {
 			#dma-cells = <2>;
 		};
 
-		usb {
-			#address-cells = <1>;
-			#size-cells = <1>;
-			compatible = "simple-bus";
-			ranges = <0x0 0x31020000 0x00001000>;
-
-			/*
-			 * Enable either ohci or usbd (gadget)!
-			 */
-			ohci: usb@0 {
-				compatible = "nxp,ohci-nxp", "usb-ohci";
-				reg = <0x0 0x300>;
-				interrupt-parent = <&sic1>;
-				interrupts = <27 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&usbclk LPC32XX_USB_CLK_HOST>;
-				status = "disabled";
-			};
+		/*
+		 * Enable either ohci or usbd (gadget)!
+		 */
+		ohci: usb@31020000 {
+			compatible = "nxp,ohci-nxp", "usb-ohci";
+			reg = <0x31020000 0x300>;
+			interrupt-parent = <&sic1>;
+			interrupts = <27 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&usbclk LPC32XX_USB_CLK_HOST>;
+			status = "disabled";
+		};
 
-			usbd: usbd@0 {
-				compatible = "nxp,lpc3220-udc";
-				reg = <0x0 0x300>;
-				interrupt-parent = <&sic1>;
-				interrupts = <29 IRQ_TYPE_LEVEL_HIGH>,
-					     <30 IRQ_TYPE_LEVEL_HIGH>,
-					     <28 IRQ_TYPE_LEVEL_HIGH>,
-					     <26 IRQ_TYPE_LEVEL_LOW>;
-				clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>;
-				status = "disabled";
-			};
+		usbd: usbd@31020000 {
+			compatible = "nxp,lpc3220-udc";
+			reg = <0x31020000 0x300>;
+			interrupt-parent = <&sic1>;
+			interrupts = <29 IRQ_TYPE_LEVEL_HIGH>,
+				     <30 IRQ_TYPE_LEVEL_HIGH>,
+				     <28 IRQ_TYPE_LEVEL_HIGH>,
+				     <26 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>;
+			status = "disabled";
+		};
 
-			i2cusb: i2c@300 {
-				compatible = "nxp,pnx-i2c";
-				reg = <0x300 0x100>;
-				interrupt-parent = <&sic1>;
-				interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&usbclk LPC32XX_USB_CLK_I2C>;
-				#address-cells = <1>;
-				#size-cells = <0>;
-			};
+		i2cusb: i2c@31020300 {
+			compatible = "nxp,pnx-i2c";
+			reg = <0x31020300 0x100>;
+			interrupt-parent = <&sic1>;
+			interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&usbclk LPC32XX_USB_CLK_I2C>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
 
-			usbclk: clock-controller@f00 {
-				compatible = "nxp,lpc3220-usb-clk";
-				reg = <0xf00 0x100>;
-				#clock-cells = <1>;
-			};
+		usbclk: clock-controller@31020f00 {
+			compatible = "nxp,lpc3220-usb-clk";
+			reg = <0x31020f00 0x100>;
+			#clock-cells = <1>;
 		};
 
 		clcd: clcd@31040000 {
-- 
2.34.1

[PATCH v2 2/5] ARM: dts: lpc3250-ea3250: add key- prefix for gpio-keys

[Frank Li]

Add key- prefix to fix below CHECK_DTB warning:
  arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: gpio-keys (gpio-keys): 'joy0', ... do not match any of the regexes: '^(button|...)$', 'pinctrl-[0-9]+

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Changes in v2
- add Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
---
 arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts
index 63c6f17bb7c9f..837a3cfa8e7c8 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts
+++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts
@@ -27,55 +27,55 @@ button {
 			gpios = <&gpio 4 1 0>; /* GPI_P3 1 */
 		};
 
-		key1 {
+		key-1 {
 			label = "KEY1";
 			linux,code = <1>;
 			gpios = <&pca9532 0 0>;
 		};
 
-		key2 {
+		key-2 {
 			label = "KEY2";
 			linux,code = <2>;
 			gpios = <&pca9532 1 0>;
 		};
 
-		key3 {
+		key-3 {
 			label = "KEY3";
 			linux,code = <3>;
 			gpios = <&pca9532 2 0>;
 		};
 
-		key4 {
+		key-4 {
 			label = "KEY4";
 			linux,code = <4>;
 			gpios = <&pca9532 3 0>;
 		};
 
-		joy0 {
+		key-joy0 {
 			label = "Joystick Key 0";
 			linux,code = <10>;
 			gpios = <&gpio 2 0 0>; /* P2.0 */
 		};
 
-		joy1 {
+		key-joy1 {
 			label = "Joystick Key 1";
 			linux,code = <11>;
 			gpios = <&gpio 2 1 0>; /* P2.1 */
 		};
 
-		joy2 {
+		key-joy2 {
 			label = "Joystick Key 2";
 			linux,code = <12>;
 			gpios = <&gpio 2 2 0>; /* P2.2 */
 		};
 
-		joy3 {
+		key-joy3 {
 			label = "Joystick Key 3";
 			linux,code = <13>;
 			gpios = <&gpio 2 3 0>; /* P2.3 */
 		};
 
-		joy4 {
+		key-joy4 {
 			label = "Joystick Key 4";
 			linux,code = <14>;
 			gpios = <&gpio 2 4 0>; /* P2.4 */
-- 
2.34.1

[PATCH v2 3/5] ARM: dts: lpc3250-phy3250: add at25 required properties

[Frank Li]

Add at25 required properties (size, address-width and pagesize), which
duplicate deprecated properties.

Fix below CHECK_DTB warning:
  arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): 'pagesize' is a required property
  arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): $nodename: 'anyOf' conditional failed, one must be fixed:

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- move node name change to new patch
---
 arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
index 21a6d0bca1e8a..732d590f6cfdf 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
+++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
@@ -216,6 +216,10 @@ eeprom: at25@0 {
 		at25,byte-len = <0x8000>;
 		at25,addr-mode = <2>;
 		at25,page-size = <64>;
+
+		size = <0x8000>;
+		address-width = <16>;
+		pagesize = <64>;
 	};
 };
 
-- 
2.34.1

Re: [PATCH v2 3/5] ARM: dts: lpc3250-phy3250: add at25 required properties

[Vladimir Zapolskiy]

Hi Frank.

On 11/14/25 19:47, Frank Li wrote:
> Add at25 required properties (size, address-width and pagesize), which
> duplicate deprecated properties.
> 
> Fix below CHECK_DTB warning:
>    arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): 'pagesize' is a required property
>    arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): $nodename: 'anyOf' conditional failed, one must be fixed:
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - move node name change to new patch
> ---
>   arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> index 21a6d0bca1e8a..732d590f6cfdf 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> @@ -216,6 +216,10 @@ eeprom: at25@0 {
>   		at25,byte-len = <0x8000>;
>   		at25,addr-mode = <2>;
>   		at25,page-size = <64>;
> +
> +		size = <0x8000>;
> +		address-width = <16>;
> +		pagesize = <64>;
>   	};
>   };
>   

I see that I was imprecise in my ask, please replace (remove) the deprecated
properties with the new ones added. There is no reason to keep both, forward
compatibility should not be supported.

Sorry for any caused confusion.

-- 
Best wishes,
Vladimir

[PATCH v2 4/5] ARM: dts: lpc3250-phy3250: rename nodename at@0 to eeprom@0

[Frank Li]

Rename nodename at@0 to eeprom@0 to fix below CHECK_DTBS warnings:
arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): $nodename: 'anyOf' conditional failed, one must be fixed:
	'at25@0' does not match '^eeprom@[0-9a-f]{1,2}$'
	'at25@0' does not match '^fram@[0-9a-f]{1,2}$'

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- new patch
---
 arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
index 732d590f6cfdf..15463a96938cc 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
+++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
@@ -200,7 +200,7 @@ &ssp0 {
 	cs-gpios = <&gpio 3 5 0>;
 	status = "okay";
 
-	eeprom: at25@0 {
+	eeprom: eeprom@0 {
 		compatible = "atmel,at25";
 		reg = <0>;
 		spi-max-frequency = <5000000>;
-- 
2.34.1

Re: [PATCH v2 4/5] ARM: dts: lpc3250-phy3250: rename nodename at@0 to eeprom@0

[Vladimir Zapolskiy]

On 11/14/25 19:47, Frank Li wrote:
> Rename nodename at@0 to eeprom@0 to fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): $nodename: 'anyOf' conditional failed, one must be fixed:
> 	'at25@0' does not match '^eeprom@[0-9a-f]{1,2}$'
> 	'at25@0' does not match '^fram@[0-9a-f]{1,2}$'
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - new patch
> ---
>   arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> index 732d590f6cfdf..15463a96938cc 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> @@ -200,7 +200,7 @@ &ssp0 {
>   	cs-gpios = <&gpio 3 5 0>;
>   	status = "okay";
>   
> -	eeprom: at25@0 {
> +	eeprom: eeprom@0 {
>   		compatible = "atmel,at25";
>   		reg = <0>;
>   		spi-max-frequency = <5000000>;

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

-- 
Best wishes,
Vladimir

[PATCH v2 5/5] ARM: dts: lpc3250-phy3250: remove deprecated at25* property

[Frank Li]

Remove duplicated deprecated at25* property because the same common
property already were added.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
changes in v2
- new patch
---
 arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
index 15463a96938cc..0f96ea0337a1f 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
+++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
@@ -213,10 +213,6 @@ eeprom: eeprom@0 {
 		pl022,wait-state = <0>;
 		pl022,duplex = <0>;
 
-		at25,byte-len = <0x8000>;
-		at25,addr-mode = <2>;
-		at25,page-size = <64>;
-
 		size = <0x8000>;
 		address-width = <16>;
 		pagesize = <64>;
-- 
2.34.1

Re: [PATCH v2 5/5] ARM: dts: lpc3250-phy3250: remove deprecated at25* property

[Vladimir Zapolskiy]

On 11/14/25 19:47, Frank Li wrote:
> Remove duplicated deprecated at25* property because the same common
> property already were added.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> changes in v2
> - new patch
> ---
>   arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> index 15463a96938cc..0f96ea0337a1f 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> @@ -213,10 +213,6 @@ eeprom: eeprom@0 {
>   		pl022,wait-state = <0>;
>   		pl022,duplex = <0>;
>   
> -		at25,byte-len = <0x8000>;
> -		at25,addr-mode = <2>;
> -		at25,page-size = <64>;
> -
>   		size = <0x8000>;
>   		address-width = <16>;
>   		pagesize = <64>;

Just squash this change with the 3/5 from the series, or I can do it on
patch application.

My ask about splitting the changes was about a separation of the 4/5 change,
and it was done as expected, thank you.

--
Best wishes,
Vladimir

Re: [PATCH v2 5/5] ARM: dts: lpc3250-phy3250: remove deprecated at25* property

[Frank Li]

On Sat, Nov 15, 2025 at 02:23:50AM +0200, Vladimir Zapolskiy wrote:
> On 11/14/25 19:47, Frank Li wrote:
> > Remove duplicated deprecated at25* property because the same common
> > property already were added.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > changes in v2
> > - new patch
> > ---
> >   arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ----
> >   1 file changed, 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> > index 15463a96938cc..0f96ea0337a1f 100644
> > --- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> > +++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> > @@ -213,10 +213,6 @@ eeprom: eeprom@0 {
> >   		pl022,wait-state = <0>;
> >   		pl022,duplex = <0>;
> > -		at25,byte-len = <0x8000>;
> > -		at25,addr-mode = <2>;
> > -		at25,page-size = <64>;
> > -
> >   		size = <0x8000>;
> >   		address-width = <16>;
> >   		pagesize = <64>;
>
> Just squash this change with the 3/5 from the series, or I can do it on
> patch application.

Yes, you can squash when apply.

Frank
>
> My ask about splitting the changes was about a separation of the 4/5 change,
> and it was done as expected, thank you.
>
> --
> Best wishes,
> Vladimir

Re: [PATCH v2 5/5] ARM: dts: lpc3250-phy3250: remove deprecated at25* property

[Vladimir Zapolskiy]

On 11/17/25 18:12, Frank Li wrote:
> On Sat, Nov 15, 2025 at 02:23:50AM +0200, Vladimir Zapolskiy wrote:
>> On 11/14/25 19:47, Frank Li wrote:
>>> Remove duplicated deprecated at25* property because the same common
>>> property already were added.
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>> changes in v2
>>> - new patch
>>> ---
>>>    arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ----
>>>    1 file changed, 4 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
>>> index 15463a96938cc..0f96ea0337a1f 100644
>>> --- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
>>> +++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
>>> @@ -213,10 +213,6 @@ eeprom: eeprom@0 {
>>>    		pl022,wait-state = <0>;
>>>    		pl022,duplex = <0>;
>>> -		at25,byte-len = <0x8000>;
>>> -		at25,addr-mode = <2>;
>>> -		at25,page-size = <64>;
>>> -
>>>    		size = <0x8000>;
>>>    		address-width = <16>;
>>>    		pagesize = <64>;
>>
>> Just squash this change with the 3/5 from the series, or I can do it on
>> patch application.
> 
> Yes, you can squash when apply.
> 

Good, no need to resend these changes for you, but I would skip sending
a PR for v6.19, the patches will be targeted for v6.20.

>>
>> My ask about splitting the changes was about a separation of the 4/5 change,
>> and it was done as expected, thank you.

-- 
Best wishes,
Vladimir

Re: [PATCH v2 1/5] ARM: dts: lpc32xx: remove usb bus and elevate all children nodes

[Vladimir Zapolskiy]

Hi Frank.

On 11/14/25 19:47, Frank Li wrote:
> Remove usb bus and elevate all children nodes because usb bus is not
> existed and only group usb devices logically.
> 
> Update register address and related full node name.
> 
> Fix below CHECK_DTBS warnings:
> arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: usb (simple-bus): $nodename:0: 'usb' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
>          from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - elevate usb children node
> - fab leave unchange now utils finish discussion.
> ---
>   arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 77 ++++++++++++--------------
>   1 file changed, 35 insertions(+), 42 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 4dff0d7694322..d6243adbc05bc 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -86,51 +86,44 @@ dma: dma-controller@31000000 {
>   			#dma-cells = <2>;
>   		};
>   
> -		usb {
> -			#address-cells = <1>;
> -			#size-cells = <1>;
> -			compatible = "simple-bus";
> -			ranges = <0x0 0x31020000 0x00001000>;
> -
> -			/*
> -			 * Enable either ohci or usbd (gadget)!
> -			 */
> -			ohci: usb@0 {
> -				compatible = "nxp,ohci-nxp", "usb-ohci";
> -				reg = <0x0 0x300>;
> -				interrupt-parent = <&sic1>;
> -				interrupts = <27 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&usbclk LPC32XX_USB_CLK_HOST>;
> -				status = "disabled";
> -			};
> +		/*
> +		 * Enable either ohci or usbd (gadget)!
> +		 */
> +		ohci: usb@31020000 {
> +			compatible = "nxp,ohci-nxp", "usb-ohci";
> +			reg = <0x31020000 0x300>;
> +			interrupt-parent = <&sic1>;
> +			interrupts = <27 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&usbclk LPC32XX_USB_CLK_HOST>;
> +			status = "disabled";
> +		};
>   
> -			usbd: usbd@0 {
> -				compatible = "nxp,lpc3220-udc";
> -				reg = <0x0 0x300>;
> -				interrupt-parent = <&sic1>;
> -				interrupts = <29 IRQ_TYPE_LEVEL_HIGH>,
> -					     <30 IRQ_TYPE_LEVEL_HIGH>,
> -					     <28 IRQ_TYPE_LEVEL_HIGH>,
> -					     <26 IRQ_TYPE_LEVEL_LOW>;
> -				clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>;
> -				status = "disabled";
> -			};
> +		usbd: usbd@31020000 {
> +			compatible = "nxp,lpc3220-udc";
> +			reg = <0x31020000 0x300>;
> +			interrupt-parent = <&sic1>;
> +			interrupts = <29 IRQ_TYPE_LEVEL_HIGH>,
> +				     <30 IRQ_TYPE_LEVEL_HIGH>,
> +				     <28 IRQ_TYPE_LEVEL_HIGH>,
> +				     <26 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>;
> +			status = "disabled";
> +		};
>   
> -			i2cusb: i2c@300 {
> -				compatible = "nxp,pnx-i2c";
> -				reg = <0x300 0x100>;
> -				interrupt-parent = <&sic1>;
> -				interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&usbclk LPC32XX_USB_CLK_I2C>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -			};
> +		i2cusb: i2c@31020300 {
> +			compatible = "nxp,pnx-i2c";
> +			reg = <0x31020300 0x100>;
> +			interrupt-parent = <&sic1>;
> +			interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&usbclk LPC32XX_USB_CLK_I2C>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +		};
>   
> -			usbclk: clock-controller@f00 {
> -				compatible = "nxp,lpc3220-usb-clk";
> -				reg = <0xf00 0x100>;
> -				#clock-cells = <1>;
> -			};
> +		usbclk: clock-controller@31020f00 {
> +			compatible = "nxp,lpc3220-usb-clk";
> +			reg = <0x31020f00 0x100>;
> +			#clock-cells = <1>;
>   		};
>   
>   		clcd: clcd@31040000 {

As for me the change looks good, but I need some time to do
a regression testing, I'll do it over the weekend.

Thank you for the contribution!

-- 
Best wishes,
Vladimir