Re: [PATCH v2 12/18] arm64: dts: ti: k3-j722s-evm: Add overlay for dual Arducam V3link fusion

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The v2 changelog claims to 'Fix minor DTS styling and whitespace inconsistencies in port definitions', but an improperly indented closing bracket remains.
--

--- Patch [12]: [PATCH v2 12/18] arm64: dts: ti: k3-j722s-evm: Add overlay for dual Arducam V3link fusion ---
commit aaa6a2127a8b86a7d8034ebb013436530699b645
Author: Vaishnav Achath <vaishnav.a@ti.com>

arm64: dts: ti: k3-j722s-evm: Add overlay for dual Arducam V3link fusion

This commit adds a device tree overlay for two Arducam V3Link mini fusion
boards, connecting them to the two CSI RX inputs on the J722S EVM. Each
board features a single DS90UB960 deserializer capable of aggregating input
from up to four cameras.

> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm-v3link-fusion.dtso b/arch/arm64/boot/dts/ti/k3-j722s-evm-v3link-fusion.dtso
> new file mode 100644
> index 0000000000000..b27c53015e6ce
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm-v3link-fusion.dtso

[ ... ]

> +	/* CAM1 I2C */
> +	i2c@1 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <1>;
> +
> +		deser@30 {
> +			compatible = "ti,ds90ub960-q1";
> +			reg = <0x30>;
> +
> +			clock-names = "refclk";
> +			clocks = <&clk_fusion_25M_fixed>;
> +
> +			i2c-alias-pool = <0x5a 0x5b 0x5c 0x5d 0x5e 0x5f>;
> +
> +			deserializer_1_ports: ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					status = "disabled";
> +					};

[Severity: Low]
This isn't a functional bug, but the v2 changelog claims to "Fix minor DTS
styling and whitespace inconsistencies in port definitions". Was this extra
indentation on the closing bracket for port@0 missed during that cleanup?

> +
> +				port@1 {
> +					reg = <1>;
> +					status = "disabled";
> +				};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713113423.2310443-1-y-abhilashchandra@ti.com?part=12