Re: [PATCH v2 14/18] arm64: dts: ti: k3-j722s-evm: Add overlay for J7EXPA01EVM Fusion2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Incomplete fix of whitespace and styling inconsistencies despite commit message claims.
- [Low] Assigning `pinctrl-0` directly to the shared `&main_gpio0` controller makes the overlay fragile and prone to silent conflicts.
--

--- Patch [14]: [PATCH v2 14/18] arm64: dts: ti: k3-j722s-evm: Add overlay for J7EXPA01EVM Fusion2 ---
commit f6225e8592b3763543d75d2b7569bdc1e8dfb921
Author: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>

arm64: dts: ti: k3-j722s-evm: Add overlay for J7EXPA01EVM Fusion2

This commit adds a device tree overlay to support the J7EXPA01EVM Fusion2
serial capture expansion board on the J722S-EVM. It defines configurations
for 3 UB9702 deserializers aggregating data over the FPDLink-IV interface.

> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-iv-fusion.dtso b/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-iv-fusion.dtso
> new file mode 100644
> index 0000000000000..ed8fdfa65005e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-iv-fusion.dtso
[ ... ]
> +&main_gpio0 {
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&csi_expansion_interface_reset>;

[Severity: Low]
Is it safe to assign pinctrl-0 directly to the shared &main_gpio0 controller
in an overlay?

Since DT overlays overwrite target properties, if another overlay also
relies on main_gpio0 and sets pinctrl-0, wouldn't they unconditionally
clobber each other's pinmux configurations? Should this be scoped strictly
to the localized line68-hog node instead?

Also, this isn't a bug, but there appear to be 8 spaces used for indentation
here rather than tabs. The v2 changelog mentioned fixing whitespace
inconsistencies, was this one missed?

> +
> +	line68-hog{

[Severity: Low]
This isn't a bug, but there is a missing space before the brace here.

> +		gpio-hog;
> +		gpios = <68 GPIO_ACTIVE_HIGH>;
[ ... ]
> +		deser@3d {
> +			compatible = "ti,ds90ub9702-q1";
> +			reg = <0x3d>;
> +			clocks = <&clk_fusion_25M_fixed>;
> +			clock-names = "refclk";
> +			i2c-alias-pool = <0x4a 0x4b 0x4c 0x4d 0x4e 0x4f>;
> +
> +			deserializer_0_ports: ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0{
> +					reg= <0>;
> +					status = "disabled";
> +				};

[Severity: Low]
This isn't a bug, but the v2 changelog claims to fix DTS styling and
whitespace inconsistencies in port definitions.

It looks like there are still missing spaces before the braces and
after the equal sign for reg in the deser@3d port definitions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713113423.2310443-1-y-abhilashchandra@ti.com?part=14