From: sashiko-bot@kernel.org
To: "Yannic Moog" <y.moog@phytec.de>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: fsl: add phyFLEX-Libra i.MX 8M Plus FPSC
Date: Mon, 16 Nov 2026 11:02:48 +0000 [thread overview]
Message-ID: <sashiko-outbox-216827@kernel.org> (raw)
In-Reply-To: <20261116-imx8mp-phyflex-v1-1-4adcf8b4d373@phytec.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: arm: fsl: wrong YAML sequence indentation under
oneOf items
--
commit c45415521ffaa99c1a93405ffd739350149edce7
Author: Yannic Moog <y.moog@phytec.de>
dt-bindings: fsl: add phyFLEX-Libra i.MX 8M Plus FPSC
This commit adds devicetree compatible bindings for the PHYTEC
phyFLEX-i.MX 8M Plus FPSC SoM and the phyFLEX-Libra RDK carrier board.
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..2d21a1949d949 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1225,12 +1225,18 @@ properties:
> - const: kontron,imx8mp-osm-s # Kontron i.MX8MP OSM-S SoM
> - const: fsl,imx8mp
>
> - - description: PHYTEC phyCORE-i.MX8MP FPSC based boards
> - items:
> - - enum:
> - - phytec,imx8mp-libra-rdk-fpsc # i.MX 8M Plus Libra RDK
> - - const: phytec,imx8mp-phycore-fpsc # phyCORE-i.MX 8M Plus FPSC
> - - const: fsl,imx8mp
> + - description: PHYTEC i.MX8MP FPSC based boards
> + oneOf:
> + - items:
> + - enum:
> + - phytec,imx8mp-libra-rdk-fpsc # i.MX 8M Plus Libra RDK
> + - const: phytec,imx8mp-phycore-fpsc # phyCORE-i.MX 8M Plus FPSC
> + - const: fsl,imx8mp
> + - items:
> + - enum:
> + - phytec,imx8mp-phyflex-libra-rdk # phyFLEX-Libra i.MX 8M Plus RDK
> + - const: phytec,imx8mp-phyflex-fpsc-g # phyFLEX-i.MX 8M Plus FPSC
> + - const: fsl,imx8mp
[Severity: Low]
Should the sequence entries under both - items: blocks be indented by two
additional spaces (14 spaces for - enum: and - const:, and 18 spaces for
the enum values)? Documentation/devicetree/bindings/.yamllint configures
spaces: 2 with indent-sequences: true, so aligning - enum: and - const:
with items: at 12 spaces causes make dt_binding_check to fail with
yamllint indentation errors.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-imx8mp-phyflex-v1-0-4adcf8b4d373@phytec.de?part=1
next prev parent reply other threads:[~2026-11-16 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:54 [PATCH 0/5] arm64: add new phyFLEX-Libra i.MX 8M Plus FPSC hardware Yannic Moog
2026-11-16 10:54 ` [PATCH 1/5] dt-bindings: fsl: add phyFLEX-Libra i.MX 8M Plus FPSC Yannic Moog
2026-11-16 11:02 ` sashiko-bot [this message]
2026-11-16 16:23 ` Rob Herring (Arm)
2026-11-16 10:54 ` [PATCH 2/5] arm64: dts: Add " Yannic Moog
2026-11-16 11:36 ` sashiko-bot
2026-11-16 10:54 ` [PATCH 3/5] arm64: dts: imx8mp-phyflex-libra: add display overlays Yannic Moog
2026-11-16 11:51 ` sashiko-bot
2026-11-16 10:54 ` [PATCH 4/5] arm64: dts: remove Libra phyCORE-i.MX 8M Plus FPSC Yannic Moog
2026-11-16 10:54 ` [PATCH 5/5] dt-bindings: fsl: remove " Yannic Moog
2026-11-16 12:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216827@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox