Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yannic Moog" <y.moog@phytec.de>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 5/5] dt-bindings: fsl: remove phyCORE-i.MX 8M Plus FPSC
Date: Mon, 16 Nov 2026 12:02:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-216974@kernel.org> (raw)
In-Reply-To: <20261116-imx8mp-phyflex-v1-5-4adcf8b4d373@phytec.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: fsl: redundant single-entry oneOf and yamllint
  indent error
--

commit f303b3d397f1c2b535993718e5b16c7dfc14c6a7
Author: Yannic Moog <y.moog@phytec.de>

dt-bindings: fsl: remove phyCORE-i.MX 8M Plus FPSC

This commit removes the compatible entries for the prototype
phyCORE-i.MX 8M Plus FPSC SoM and its Libra RDK board from fsl.yaml.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 2d21a1949d949..ae823a7670b02 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1227,11 +1227,6 @@ properties:
>  
>        - description: PHYTEC i.MX8MP FPSC based boards
>          oneOf:
> -          - items:
> -            - enum:
> -                - phytec,imx8mp-libra-rdk-fpsc  # i.MX 8M Plus Libra RDK
> -            - const: phytec,imx8mp-phycore-fpsc # phyCORE-i.MX 8M Plus FPSC
> -            - const: fsl,imx8mp
>            - items:
>              - enum:
>                  - phytec,imx8mp-phyflex-libra-rdk # phyFLEX-Libra i.MX 8M Plus RDK

[Severity: Low]
Should the oneOf wrapper also be removed now that only a single items list
remains under PHYTEC i.MX8MP FPSC based boards?

In addition to leaving a single-entry oneOf, the remaining "- enum:" and
"- const:" sequence entries are indented at the same column as "items:",
which fails yamllint (indent-sequences: true in
Documentation/devicetree/bindings/.yamllint) during make dt_binding_check.
Dropping oneOf and placing items directly under description avoids both
issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-imx8mp-phyflex-v1-0-4adcf8b4d373@phytec.de?part=5

      reply	other threads:[~2026-11-16 12:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:54 [PATCH 0/5] arm64: add new phyFLEX-Libra i.MX 8M Plus FPSC hardware Yannic Moog
2026-11-16 10:54 ` [PATCH 1/5] dt-bindings: fsl: add phyFLEX-Libra i.MX 8M Plus FPSC Yannic Moog
2026-11-16 11:02   ` sashiko-bot
2026-11-16 16:23   ` Rob Herring (Arm)
2026-11-16 10:54 ` [PATCH 2/5] arm64: dts: Add " Yannic Moog
2026-11-16 11:36   ` sashiko-bot
2026-11-16 10:54 ` [PATCH 3/5] arm64: dts: imx8mp-phyflex-libra: add display overlays Yannic Moog
2026-11-16 11:51   ` sashiko-bot
2026-11-16 10:54 ` [PATCH 4/5] arm64: dts: remove Libra phyCORE-i.MX 8M Plus FPSC Yannic Moog
2026-11-16 10:54 ` [PATCH 5/5] dt-bindings: fsl: remove " Yannic Moog
2026-11-16 12:02   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216974@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=y.moog@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox