Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yannic Moog" <y.moog@phytec.de>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: imx8mp-phyflex-libra: add display overlays
Date: Mon, 16 Nov 2026 11:51:11 +0000	[thread overview]
Message-ID: <sashiko-outbox-216961@kernel.org> (raw)
In-Reply-To: <20261116-imx8mp-phyflex-v1-3-4adcf8b4d373@phytec.de>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] arm64: dts: imx8mp-phyflex-libra: sound and sai5 left disabled
  on PEB-AV-10
- [High] arm64: dts: imx8mp-phyflex-libra: wrong backlight enable-gpios
  on PEB-AV-10
- [Low] arm64: dts: imx8mp-phyflex-libra: unused reg_vcc_12v and shared
  backlight_lvds
--

commit 19f62dd057ed6706b50af0f2de5fcf9ee9c1e80f
Author: Yannic Moog <y.moog@phytec.de>

arm64: dts: imx8mp-phyflex-libra: add display overlays

This commit adds devicetree overlays for the Powertip ph128800t006-zhc01 LVDS
panel connected to the Libra baseboard or the PEB-AV-10 expansion board, as
well as a standalone overlay for the PEB-AV-10 expansion board.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyflex-libra-rdk-peb-av-10-ph128800t006.dtso b/arch/arm64/boot/dts/freescale/imx8mp-phyflex-libra-rdk-peb-av-10-ph128800t006.dtso
> new file mode 100644
> index 0000000000000..33677601789bd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyflex-libra-rdk-peb-av-10-ph128800t006.dtso
> @@ -0,0 +1,45 @@
[ ... ]
> +&backlight_lvds {
> +	brightness-levels = <0 8 16 32 64 128 255>;
> +	default-brightness-level = <8>;
> +	enable-gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>;
> +	num-interpolated-steps = <2>;
> +	pwms = <&pwm1 0 66667 0>;
> +	status = "okay";
> +};

[Severity: High]
Should enable-gpios reference <&gpio4 28 GPIO_ACTIVE_HIGH> here instead of
<&gpio5 1 GPIO_ACTIVE_HIGH>?

In imx8mp-phyflex-libra-rdk-peb-av-10.dtsi, backlight_lvds is assigned
pinctrl_lvds2, which muxes MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 rather than
GPIO5_IO01, so the pwm-backlight driver will drive the wrong pin and fail to
enable the PEB-AV-10 display backlight.

[ ... ]

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyflex-libra-rdk-peb-av-10.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phyflex-libra-rdk-peb-av-10.dtsi
> new file mode 100644
> index 0000000000000..e94ce6691a620
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyflex-libra-rdk-peb-av-10.dtsi
> @@ -0,0 +1,152 @@
[ ... ]
> +&{/} {
> +	panel_lvds2: panel-lvds2 {
> +		backlight = <&backlight_lvds>;
> +		power-supply = <&reg_vdd_3v3>;
> +		status = "disabled";
> +
> +		port {
> +			panel2_in: endpoint {
> +				remote-endpoint = <&ldb_lvds_ch1>;
> +			};
> +		};
> +	};
> +
> +	reg_vcc_12v: regulator-12v {
> +		compatible = "regulator-fixed";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-max-microvolt = <12000000>;
> +		regulator-min-microvolt = <12000000>;
> +		regulator-name = "VCC_12V";
> +	};

[Severity: Low]
reg_vcc_12v is defined here but never referenced anywhere, while panel_lvds2
reuses the baseboard's backlight_lvds node (which uses reg_vdd_12v0) and
overwrites its pinctrl-0 with pinctrl_lvds2 even when only the standalone
PEB-AV-10 audio overlay is applied.  Was a dedicated backlight node supplied
by reg_vcc_12v intended for panel_lvds2, or can reg_vcc_12v be dropped and the
backlight_lvds pinctrl override moved to
imx8mp-phyflex-libra-rdk-peb-av-10-ph128800t006.dtso?

[ ... ]

> +	sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "snd-peb-av-10";
[ ... ]
> +		status = "disabled";
> +
> +		simple-audio-card,codec {
> +			sound-dai = <&codec>;
> +		};
> +
> +		dailink_master: simple-audio-card,cpu {
> +			sound-dai = <&sai5>;
> +		};
> +	};
> +};
[ ... ]
> +&sai5 {
> +	assigned-clocks = <&clk IMX8MP_CLK_SAI5>;
> +	assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL1_OUT>;
> +	assigned-clock-rates = <12288000>;
> +	clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI5_IPG>,
> +		 <&clk IMX8MP_CLK_DUMMY>,
> +		 <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI5_MCLK1>,
> +		 <&clk IMX8MP_CLK_DUMMY>,
> +		 <&clk IMX8MP_CLK_DUMMY>,
> +		 <&clk IMX8MP_AUDIO_PLL1_OUT>,
> +		 <&clk IMX8MP_AUDIO_PLL2_OUT>;
> +	clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3", "pll8k",
> +		      "pll11k";
> +	#sound-dai-cells = <0>;
> +	fsl,sai-mclk-direction-output;
> +};

[Severity: High]
Does this leave both the sound card and sai5 disabled when the PEB-AV-10
overlays are applied?

The sound node here sets status = "disabled", and &sai5 omits status = "okay"
(leaving it disabled as defined in imx8mp.dtsi).  Neither
imx8mp-phyflex-libra-rdk-peb-av-10.dtso nor
imx8mp-phyflex-libra-rdk-peb-av-10-ph128800t006.dtso enables either node, so
the PEB-AV-10 audio device will not probe.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-imx8mp-phyflex-v1-0-4adcf8b4d373@phytec.de?part=3

  reply	other threads:[~2026-11-16 11:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:54 [PATCH 0/5] arm64: add new phyFLEX-Libra i.MX 8M Plus FPSC hardware Yannic Moog
2026-11-16 10:54 ` [PATCH 1/5] dt-bindings: fsl: add phyFLEX-Libra i.MX 8M Plus FPSC Yannic Moog
2026-11-16 11:02   ` sashiko-bot
2026-11-16 16:23   ` Rob Herring (Arm)
2026-11-16 10:54 ` [PATCH 2/5] arm64: dts: Add " Yannic Moog
2026-11-16 11:36   ` sashiko-bot
2026-11-16 10:54 ` [PATCH 3/5] arm64: dts: imx8mp-phyflex-libra: add display overlays Yannic Moog
2026-11-16 11:51   ` sashiko-bot [this message]
2026-11-16 10:54 ` [PATCH 4/5] arm64: dts: remove Libra phyCORE-i.MX 8M Plus FPSC Yannic Moog
2026-11-16 10:54 ` [PATCH 5/5] dt-bindings: fsl: remove " Yannic Moog
2026-11-16 12:02   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216961@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=y.moog@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox