* [PATCH] deal with nfs in fstab-sys
@ 2012-01-30 6:44 Dave Young
2012-01-30 8:20 ` Cong Wang
0 siblings, 1 reply; 9+ messages in thread
From: Dave Young @ 2012-01-30 6:44 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA
If we need to mount nonroot nfs in fstab we also need to launch rpc processes
Add nfs-start-rpc code, also do not check and fsck $_dev in this case
Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
modules.d/95fstab-sys/mount-sys.sh | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
Index: dracut/modules.d/95fstab-sys/mount-sys.sh
===================================================================
--- dracut.orig/modules.d/95fstab-sys/mount-sys.sh
+++ dracut/modules.d/95fstab-sys/mount-sys.sh
@@ -11,12 +11,17 @@ fstab_mount() {
info "Mounting from $1"
while read _dev _mp _fs _opts _dump _pass _rest; do
[ -z "${_dev%%#*}" ] && continue # Skip comment lines
- if [ ! -e "$_dev" ]; then
- warn "Device $_dev doesn't exist, skipping mount."
- continue
- fi
- if [ "$_pass" -gt 0 ] && ! strstr "$_opts" _netdev; then
- fsck_single "$_dev" "$_fs"
+ if [[ ! "$_fs" =~ "nfs" ]]; then
+ if [ ! -e "$_dev" ]; then
+ warn "Device $_dev doesn't exist, skipping mount."
+ continue
+ fi
+ if [ "$_pass" -gt 0 ] && ! strstr "$_opts" _netdev; then
+ fsck_single "$_dev" "$_fs"
+ fi
+ else
+ . /sbin/nfs-start-rpc
+ nfsstart $_fs
fi
_fs=$(det_fs "$_dev" "$_fs")
info "Mounting $_dev"
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] deal with nfs in fstab-sys 2012-01-30 6:44 [PATCH] deal with nfs in fstab-sys Dave Young @ 2012-01-30 8:20 ` Cong Wang 2012-01-30 8:41 ` Dave Young 0 siblings, 1 reply; 9+ messages in thread From: Cong Wang @ 2012-01-30 8:20 UTC (permalink / raw) To: initramfs-u79uwXL29TY76Z2rM5mHXA On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: > If we need to mount nonroot nfs in fstab we also need to launch rpc processes > Add nfs-start-rpc code, also do not check and fsck $_dev in this case Isn't it nfs module's responsibility to call nfs-start-rpc code? Why do you put it in fs-systab? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] deal with nfs in fstab-sys 2012-01-30 8:20 ` Cong Wang @ 2012-01-30 8:41 ` Dave Young [not found] ` <4F2657B4.3030200-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Dave Young @ 2012-01-30 8:41 UTC (permalink / raw) To: Cong Wang; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 04:20 PM, Cong Wang wrote: > On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >> If we need to mount nonroot nfs in fstab we also need to launch rpc processes >> Add nfs-start-rpc code, also do not check and fsck $_dev in this case > > Isn't it nfs module's responsibility to call nfs-start-rpc code? > Why do you put it in fs-systab? nfs know nothing about fstab mount, it only deal with nfsroot thing. So I have to do this in fstab-sys > > -- > To unsubscribe from this list: send the line "unsubscribe initramfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks Dave ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4F2657B4.3030200-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] deal with nfs in fstab-sys [not found] ` <4F2657B4.3030200-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2012-01-30 8:43 ` Cong Wang [not found] ` <4F26581B.4040305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Cong Wang @ 2012-01-30 8:43 UTC (permalink / raw) To: Dave Young; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 04:41 PM, Dave Young wrote: > On 01/30/2012 04:20 PM, Cong Wang wrote: > >> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young<dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >>> If we need to mount nonroot nfs in fstab we also need to launch rpc processes >>> Add nfs-start-rpc code, also do not check and fsck $_dev in this case >> >> Isn't it nfs module's responsibility to call nfs-start-rpc code? >> Why do you put it in fs-systab? > > > nfs know nothing about fstab mount, it only deal with nfsroot thing. So > I have to do this in fstab-sys Sure, but nfs module knows it needs to start rpc before mounting NFS. So, what's the problem if we call nfs-start-rpc script in pre-pivot hook of nfs module (before mount-sys.sh, of course)? ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4F26581B.4040305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] deal with nfs in fstab-sys [not found] ` <4F26581B.4040305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2012-01-30 9:02 ` Dave Young [not found] ` <4F265CAA.2080804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Dave Young @ 2012-01-30 9:02 UTC (permalink / raw) To: Cong Wang; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 04:43 PM, Cong Wang wrote: > On 01/30/2012 04:41 PM, Dave Young wrote: >> On 01/30/2012 04:20 PM, Cong Wang wrote: >> >>> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young<dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >>>> If we need to mount nonroot nfs in fstab we also need to launch rpc >>>> processes >>>> Add nfs-start-rpc code, also do not check and fsck $_dev in this case >>> >>> Isn't it nfs module's responsibility to call nfs-start-rpc code? >>> Why do you put it in fs-systab? >> >> >> nfs know nothing about fstab mount, it only deal with nfsroot thing. So >> I have to do this in fstab-sys > > Sure, but nfs module knows it needs to start rpc before mounting NFS. > > So, what's the problem if we call nfs-start-rpc script in pre-pivot hook > of nfs module (before mount-sys.sh, of course)? Actually nfs-start-rpc need to know the fs is nfs or nfs4, If add it as a hook, how does it accept the argument? > -- > To unsubscribe from this list: send the line "unsubscribe initramfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks Dave ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4F265CAA.2080804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] deal with nfs in fstab-sys [not found] ` <4F265CAA.2080804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2012-01-30 9:12 ` Cong Wang [not found] ` <4F265EE1.7010505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Cong Wang @ 2012-01-30 9:12 UTC (permalink / raw) To: Dave Young; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 05:02 PM, Dave Young wrote: > On 01/30/2012 04:43 PM, Cong Wang wrote: > >> On 01/30/2012 04:41 PM, Dave Young wrote: >>> On 01/30/2012 04:20 PM, Cong Wang wrote: >>> >>>> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young<dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >>>>> If we need to mount nonroot nfs in fstab we also need to launch rpc >>>>> processes >>>>> Add nfs-start-rpc code, also do not check and fsck $_dev in this case >>>> >>>> Isn't it nfs module's responsibility to call nfs-start-rpc code? >>>> Why do you put it in fs-systab? >>> >>> >>> nfs know nothing about fstab mount, it only deal with nfsroot thing. So >>> I have to do this in fstab-sys >> >> Sure, but nfs module knows it needs to start rpc before mounting NFS. >> >> So, what's the problem if we call nfs-start-rpc script in pre-pivot hook >> of nfs module (before mount-sys.sh, of course)? > > > Actually nfs-start-rpc need to know the fs is nfs or nfs4, If add it as > a hook, how does it accept the argument? I think you can start rpc daemons unconditionally, no matter if it is nfs4 or nfs. ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4F265EE1.7010505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] deal with nfs in fstab-sys [not found] ` <4F265EE1.7010505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2012-01-30 9:20 ` Dave Young [not found] ` <4F2660DB.8030105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Dave Young @ 2012-01-30 9:20 UTC (permalink / raw) To: Cong Wang; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 05:12 PM, Cong Wang wrote: > On 01/30/2012 05:02 PM, Dave Young wrote: >> On 01/30/2012 04:43 PM, Cong Wang wrote: >> >>> On 01/30/2012 04:41 PM, Dave Young wrote: >>>> On 01/30/2012 04:20 PM, Cong Wang wrote: >>>> >>>>> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young<dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>>>> wrote: >>>>>> If we need to mount nonroot nfs in fstab we also need to launch rpc >>>>>> processes >>>>>> Add nfs-start-rpc code, also do not check and fsck $_dev in this case >>>>> >>>>> Isn't it nfs module's responsibility to call nfs-start-rpc code? >>>>> Why do you put it in fs-systab? >>>> >>>> >>>> nfs know nothing about fstab mount, it only deal with nfsroot thing. So >>>> I have to do this in fstab-sys >>> >>> Sure, but nfs module knows it needs to start rpc before mounting NFS. >>> >>> So, what's the problem if we call nfs-start-rpc script in pre-pivot hook >>> of nfs module (before mount-sys.sh, of course)? >> >> >> Actually nfs-start-rpc need to know the fs is nfs or nfs4, If add it as >> a hook, how does it accept the argument? > > I think you can start rpc daemons unconditionally, no matter if it is > nfs4 or nfs. This will means once nfs module is installed in initramfs, the rpc daemons will be started even if no nfs mount options in fstab or nfsroot It looks not good to me :( -- Thanks Dave ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4F2660DB.8030105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] deal with nfs in fstab-sys [not found] ` <4F2660DB.8030105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2012-01-30 9:27 ` Cong Wang [not found] ` <4F266282.8040204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Cong Wang @ 2012-01-30 9:27 UTC (permalink / raw) To: Dave Young; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 05:20 PM, Dave Young wrote: > On 01/30/2012 05:12 PM, Cong Wang wrote: > >> On 01/30/2012 05:02 PM, Dave Young wrote: >>> On 01/30/2012 04:43 PM, Cong Wang wrote: >>> >>>> On 01/30/2012 04:41 PM, Dave Young wrote: >>>>> On 01/30/2012 04:20 PM, Cong Wang wrote: >>>>> >>>>>> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young<dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>>>>> wrote: >>>>>>> If we need to mount nonroot nfs in fstab we also need to launch rpc >>>>>>> processes >>>>>>> Add nfs-start-rpc code, also do not check and fsck $_dev in this case >>>>>> >>>>>> Isn't it nfs module's responsibility to call nfs-start-rpc code? >>>>>> Why do you put it in fs-systab? >>>>> >>>>> >>>>> nfs know nothing about fstab mount, it only deal with nfsroot thing. So >>>>> I have to do this in fstab-sys >>>> >>>> Sure, but nfs module knows it needs to start rpc before mounting NFS. >>>> >>>> So, what's the problem if we call nfs-start-rpc script in pre-pivot hook >>>> of nfs module (before mount-sys.sh, of course)? >>> >>> >>> Actually nfs-start-rpc need to know the fs is nfs or nfs4, If add it as >>> a hook, how does it accept the argument? >> >> I think you can start rpc daemons unconditionally, no matter if it is >> nfs4 or nfs. > > > This will means once nfs module is installed in initramfs, the rpc > daemons will be started even if no nfs mount options in fstab or nfsroot Sure, but they will be killed soon, by nfsroot-cleanup.sh. :) ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4F266282.8040204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] deal with nfs in fstab-sys [not found] ` <4F266282.8040204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2012-01-31 9:56 ` Dave Young 0 siblings, 0 replies; 9+ messages in thread From: Dave Young @ 2012-01-31 9:56 UTC (permalink / raw) To: Cong Wang; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA On 01/30/2012 05:27 PM, Cong Wang wrote: > On 01/30/2012 05:20 PM, Dave Young wrote: >> On 01/30/2012 05:12 PM, Cong Wang wrote: >> >>> On 01/30/2012 05:02 PM, Dave Young wrote: >>>> On 01/30/2012 04:43 PM, Cong Wang wrote: >>>> >>>>> On 01/30/2012 04:41 PM, Dave Young wrote: >>>>>> On 01/30/2012 04:20 PM, Cong Wang wrote: >>>>>> >>>>>>> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young<dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>>>>>> wrote: >>>>>>>> If we need to mount nonroot nfs in fstab we also need to launch rpc >>>>>>>> processes >>>>>>>> Add nfs-start-rpc code, also do not check and fsck $_dev in this >>>>>>>> case >>>>>>> >>>>>>> Isn't it nfs module's responsibility to call nfs-start-rpc code? >>>>>>> Why do you put it in fs-systab? >>>>>> >>>>>> >>>>>> nfs know nothing about fstab mount, it only deal with nfsroot >>>>>> thing. So >>>>>> I have to do this in fstab-sys >>>>> >>>>> Sure, but nfs module knows it needs to start rpc before mounting NFS. >>>>> >>>>> So, what's the problem if we call nfs-start-rpc script in pre-pivot >>>>> hook >>>>> of nfs module (before mount-sys.sh, of course)? >>>> >>>> >>>> Actually nfs-start-rpc need to know the fs is nfs or nfs4, If add it as >>>> a hook, how does it accept the argument? >>> >>> I think you can start rpc daemons unconditionally, no matter if it is >>> nfs4 or nfs. >> >> >> This will means once nfs module is installed in initramfs, the rpc >> daemons will be started even if no nfs mount options in fstab or nfsroot > > Sure, but they will be killed soon, by nfsroot-cleanup.sh. :) Rethink about this, unconditionally start rpc daemons make more sense than do it in fstab-sys. Will change in v2 -- Thanks Dave ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-01-31 9:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 6:44 [PATCH] deal with nfs in fstab-sys Dave Young
2012-01-30 8:20 ` Cong Wang
2012-01-30 8:41 ` Dave Young
[not found] ` <4F2657B4.3030200-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-01-30 8:43 ` Cong Wang
[not found] ` <4F26581B.4040305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-30 9:02 ` Dave Young
[not found] ` <4F265CAA.2080804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-01-30 9:12 ` Cong Wang
[not found] ` <4F265EE1.7010505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-30 9:20 ` Dave Young
[not found] ` <4F2660DB.8030105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-01-30 9:27 ` Cong Wang
[not found] ` <4F266282.8040204-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-31 9:56 ` Dave Young
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox