[Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck

[Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck

[Baoquan He]

The fsck is ignored when replace emergency_shell with action_on_fail,
now add it.

Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 modules.d/99fs-lib/fs-lib.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules.d/99fs-lib/fs-lib.sh b/modules.d/99fs-lib/fs-lib.sh
index e1f3074..88e7348 100755
--- a/modules.d/99fs-lib/fs-lib.sh
+++ b/modules.d/99fs-lib/fs-lib.sh
@@ -7,14 +7,14 @@ type getarg >/dev/null 2>&1 || . /lib/dracut-lib.sh
 fsck_ask_reboot() {
     info "note - fsck suggests reboot, if you"
     info "leave shell, booting will continue normally"
-    emergency_shell -n "(reboot ?)"
+    action_on_fail -n "(reboot ?)"
 }
 
 fsck_ask_err() {
     warn "*** An error occurred during the file system check."
     warn "*** Dropping you to a shell; the system will try"
     warn "*** to mount the filesystem(s), when you leave the shell."
-    emergency_shell -n "(Repair filesystem)"
+    action_on_fail -n "(Repair filesystem)"
 }
 
 # inherits: _ret _drv _out
-- 
1.7.1

[Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan He]

If failed to mount /sysroot, triggering OnFailure= dependencies
of initrd-xxx.service, then dracut-emergency will be started by
systemd and enter into emergency shell.

Here add a judgement in dracut-emergency. If user specify
"action_on_fail=continue", continue though mount root failed.
Otherwise enter into interactive shell.

v1-v2->
      action_on_fail function can't be used directly here, discard
      it. Instead add a judgement to handle this.

Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 modules.d/98systemd/dracut-emergency.sh |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/modules.d/98systemd/dracut-emergency.sh b/modules.d/98systemd/dracut-emergency.sh
index 8ab045e..51e1f80 100755
--- a/modules.d/98systemd/dracut-emergency.sh
+++ b/modules.d/98systemd/dracut-emergency.sh
@@ -30,7 +30,12 @@ if getargbool 1 rd.shell -d -y rdshell || getarg rd.break -d rdbreak; then
     echo
     [ -f /etc/profile ] && . /etc/profile
     [ -z "$PS1" ] && export PS1="$_name:\${PWD}# "
-    exec sh -i -l
+    if [ "$(getarg action_on_fail=)" = "continue" ]; then
+        echo "Systemd is starting dracut emergency"
+        echo "NoT dropping to emergency shell, because 'action_on_fail=continue' was set on kernel command line"
+    else
+        exec sh -i -l
+    fi
 else
     warn "$action has failed. To debug this issue add \"rd.shell rd.debug\" to the kernel command line."
     exit 1
-- 
1.7.1

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan]

On 05/29/2013 04:38 PM, Baoquan He wrote:

> If failed to mount /sysroot, triggering OnFailure= dependencies
> of initrd-xxx.service, then dracut-emergency will be started by
> systemd and enter into emergency shell.
> 
> Here add a judgement in dracut-emergency. If user specify
> "action_on_fail=continue", continue though mount root failed.
> Otherwise enter into interactive shell.
> 
> v1-v2->
>       action_on_fail function can't be used directly here, discard
>       it. Instead add a judgement to handle this.
> 
> Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/98systemd/dracut-emergency.sh |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/modules.d/98systemd/dracut-emergency.sh b/modules.d/98systemd/dracut-emergency.sh
> index 8ab045e..51e1f80 100755
> --- a/modules.d/98systemd/dracut-emergency.sh
> +++ b/modules.d/98systemd/dracut-emergency.sh
> @@ -30,7 +30,12 @@ if getargbool 1 rd.shell -d -y rdshell || getarg rd.break -d rdbreak; then
>      echo
>      [ -f /etc/profile ] && . /etc/profile
>      [ -z "$PS1" ] && export PS1="$_name:\${PWD}# "
> -    exec sh -i -l
> +    if [ "$(getarg action_on_fail=)" = "continue" ]; then
> +        echo "Systemd is starting dracut emergency"
> +        echo "NoT dropping to emergency shell, because 'action_on_fail=continue' was set on kernel command line"
> +    else
> +        exec sh -i -l
> +    fi
>  else
>      warn "$action has failed. To debug this issue add \"rd.shell rd.debug\" to the kernel command line."
>      exit 1


Hi Harald,

Since adding ConditionKernelCommandLine=!action_on_fail=continue doesn't
work, do you mind applying this patch? Or do you have other suggestions?

Baoquan
Thanks a lot

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Harald Hoyer]

On 05/30/2013 10:50 AM, Baoquan wrote:
> On 05/29/2013 04:38 PM, Baoquan He wrote:
> 
>> If failed to mount /sysroot, triggering OnFailure= dependencies
>> of initrd-xxx.service, then dracut-emergency will be started by
>> systemd and enter into emergency shell.
>>
>> Here add a judgement in dracut-emergency. If user specify
>> "action_on_fail=continue", continue though mount root failed.
>> Otherwise enter into interactive shell.
>>
>> v1-v2->
>>       action_on_fail function can't be used directly here, discard
>>       it. Instead add a judgement to handle this.
>>
>> Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>  modules.d/98systemd/dracut-emergency.sh |    7 ++++++-
>>  1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/modules.d/98systemd/dracut-emergency.sh b/modules.d/98systemd/dracut-emergency.sh
>> index 8ab045e..51e1f80 100755
>> --- a/modules.d/98systemd/dracut-emergency.sh
>> +++ b/modules.d/98systemd/dracut-emergency.sh
>> @@ -30,7 +30,12 @@ if getargbool 1 rd.shell -d -y rdshell || getarg rd.break -d rdbreak; then
>>      echo
>>      [ -f /etc/profile ] && . /etc/profile
>>      [ -z "$PS1" ] && export PS1="$_name:\${PWD}# "
>> -    exec sh -i -l
>> +    if [ "$(getarg action_on_fail=)" = "continue" ]; then
>> +        echo "Systemd is starting dracut emergency"
>> +        echo "NoT dropping to emergency shell, because 'action_on_fail=continue' was set on kernel command line"
>> +    else
>> +        exec sh -i -l
>> +    fi
>>  else
>>      warn "$action has failed. To debug this issue add \"rd.shell rd.debug\" to the kernel command line."
>>      exit 1
> 
> 
> Hi Harald,
> 
> Since adding ConditionKernelCommandLine=!action_on_fail=continue doesn't
> work, do you mind applying this patch? Or do you have other suggestions?
> 
> Baoquan
> Thanks a lot

Hmm, "ConditionKernelCommandLine=!action_on_fail=continue" _has_ to work.
Otherwise I would consider that a serious bug in systemd.

Care to elaborate how you tested it?

If you are dropped to the shell, can you run:

# systemctl status dracut-emergency.service
# systemctl status emergency.service

to confirm you are not dropped to the emergency.service, which I think this is
the case in your test setup.

So, we have to add "ConditionKernelCommandLine=!action_on_fail=continue" to
emergency.service, too.

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan]

On 05/30/2013 05:15 PM, Harald Hoyer wrote:

>> > Hi Harald,
>> > 
>> > Since adding ConditionKernelCommandLine=!action_on_fail=continue doesn't
>> > work, do you mind applying this patch? Or do you have other suggestions?
>> > 
>> > Baoquan
>> > Thanks a lot
> Hmm, "ConditionKernelCommandLine=!action_on_fail=continue" _has_ to work.
> Otherwise I would consider that a serious bug in systemd.
> 
> Care to elaborate how you tested it?
> 
> If you are dropped to the shell, can you run:
> 
> # systemctl status dracut-emergency.service
> # systemctl status emergency.service
> 
> to confirm you are not dropped to the emergency.service, which I think this is
> the case in your test setup.
> 
> So, we have to add "ConditionKernelCommandLine=!action_on_fail=continue" to
> emergency.service, too.
> 


Hi Harald,

I added this to dracut-emergency.service, and add
action_on_fail=continue to kdump command line, then change
dracut_initqueue.sh to make the RDENTRY=0, then mount won't succeed.

From my side, the ConditionKernelCommandLine=!action_on_fail=continue
doesn't work.

And I also tried ConditionKernelCommandLine=action_on_fail=continue, but
remove the kdump command line action_on_fail=continue, it didn't work
either.


Baoquan
Thanks a lot

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Harald Hoyer]

On 05/30/2013 12:15 PM, Baoquan wrote:
> On 05/30/2013 05:15 PM, Harald Hoyer wrote:
> 
>>>> Hi Harald,
>>>>
>>>> Since adding ConditionKernelCommandLine=!action_on_fail=continue doesn't
>>>> work, do you mind applying this patch? Or do you have other suggestions?
>>>>
>>>> Baoquan
>>>> Thanks a lot
>> Hmm, "ConditionKernelCommandLine=!action_on_fail=continue" _has_ to work.
>> Otherwise I would consider that a serious bug in systemd.
>>
>> Care to elaborate how you tested it?
>>
>> If you are dropped to the shell, can you run:
>>
>> # systemctl status dracut-emergency.service
>> # systemctl status emergency.service
>>
>> to confirm you are not dropped to the emergency.service, which I think this is
>> the case in your test setup.
>>
>> So, we have to add "ConditionKernelCommandLine=!action_on_fail=continue" to
>> emergency.service, too.
>>
> 
> 
> Hi Harald,
> 
> I added this to dracut-emergency.service, and add
> action_on_fail=continue to kdump command line, then change
> dracut_initqueue.sh to make the RDENTRY=0, then mount won't succeed.
> 
> From my side, the ConditionKernelCommandLine=!action_on_fail=continue
> doesn't work.
> 
> And I also tried ConditionKernelCommandLine=action_on_fail=continue, but
> remove the kdump command line action_on_fail=continue, it didn't work
> either.
> 
> 
> Baoquan
> Thanks a lot
> 
> 

worksforme... with
http://git.kernel.org/cgit/boot/dracut/dracut.git/commit/?id=b78e6ac2c328c76057b17059a761ab44707f9aa0
and
"rd.shell rd.break action_on_fail=continue"

dracut-pre-pivot[227]: /lib/dracut-lib.sh@933(_emergency_shell): systemctl start
dracut-emergency.service
Trying to enqueue job dracut-emergency.service/start/replace
Installed new job dracut-emergency.service/start as 39
Enqueued job dracut-emergency.service/start as 39
Starting of dracut-emergency.service requested but condition failed. Ignoring.
Job dracut-emergency.service/start finished, result=done

.. no rd.shell on rd.break...

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan]

On 05/30/2013 06:33 PM, Harald Hoyer wrote:

> worksforme... with
> http://git.kernel.org/cgit/boot/dracut/dracut.git/commit/?id=b78e6ac2c328c76057b17059a761ab44707f9aa0
> and
> "rd.shell rd.break action_on_fail=continue"
> 
> dracut-pre-pivot[227]: /lib/dracut-lib.sh@933(_emergency_shell): systemctl start
> dracut-emergency.service
> Trying to enqueue job dracut-emergency.service/start/replace
> Installed new job dracut-emergency.service/start as 39
> Enqueued job dracut-emergency.service/start as 39
> Starting of dracut-emergency.service requested but condition failed. Ignoring.
> Job dracut-emergency.service/start finished, result=done
> 
> .. no rd.shell on rd.break...
> 


Hi Harald,

I tried your method, add


1)"rd.break=pre-pivot action_on_fail=continue" to kernel cmdline;

2)add "ConditionKernelCommandLine=!action_on_fail=continue" into
dracut-emergency.service

it works very well, won't drop into shell. And this works for 1st kernel
and kdump kernel.

However, when I tried the mount failed method, it doesn't work.

1)"rd.break=pre-pivot action_on_fail=continue" to kernel cmdline;

2)add "ConditionKernelCommandLine=!action_on_fail=continue" into
dracut-emergency.service

3)change root to a wrong name in /proc/cmdline to make mount root failed.

:/# cat /proc/cmdline
root=/dev/mapper/fedora-root111 action_on_fail=continue .....

In this way, it always drops into shell.

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Harald Hoyer]

On 05/31/2013 09:16 AM, Baoquan wrote:
> On 05/30/2013 06:33 PM, Harald Hoyer wrote:
> 
>> worksforme... with
>> http://git.kernel.org/cgit/boot/dracut/dracut.git/commit/?id=b78e6ac2c328c76057b17059a761ab44707f9aa0
>> and
>> "rd.shell rd.break action_on_fail=continue"
>>
>> dracut-pre-pivot[227]: /lib/dracut-lib.sh@933(_emergency_shell): systemctl start
>> dracut-emergency.service
>> Trying to enqueue job dracut-emergency.service/start/replace
>> Installed new job dracut-emergency.service/start as 39
>> Enqueued job dracut-emergency.service/start as 39
>> Starting of dracut-emergency.service requested but condition failed. Ignoring.
>> Job dracut-emergency.service/start finished, result=done
>>
>> .. no rd.shell on rd.break...
>>
> 
> 
> Hi Harald,
> 
> I tried your method, add
> 
> 
> 1)"rd.break=pre-pivot action_on_fail=continue" to kernel cmdline;
> 
> 2)add "ConditionKernelCommandLine=!action_on_fail=continue" into
> dracut-emergency.service
> 
> it works very well, won't drop into shell. And this works for 1st kernel
> and kdump kernel.
> 
> However, when I tried the mount failed method, it doesn't work.
> 
> 1)"rd.break=pre-pivot action_on_fail=continue" to kernel cmdline;
> 
> 2)add "ConditionKernelCommandLine=!action_on_fail=continue" into
> dracut-emergency.service
> 
> 3)change root to a wrong name in /proc/cmdline to make mount root failed.
> 
> :/# cat /proc/cmdline
> root=/dev/mapper/fedora-root111 action_on_fail=continue .....
> 
> In this way, it always drops into shell.

This is why I said to double check, if you are dropped to
dracut-emergency.service versus emergency.service.

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan]

On 05/30/2013 05:15 PM, Harald Hoyer wrote:

> Hmm, "ConditionKernelCommandLine=!action_on_fail=continue" _has_ to work.
> Otherwise I would consider that a serious bug in systemd.
> 
> Care to elaborate how you tested it?
> 
> If you are dropped to the shell, can you run:
> 
> # systemctl status dracut-emergency.service
> # systemctl status emergency.service
> 
> to confirm you are not dropped to the emergency.service, which I think this is
> the case in your test setup.
> 
> So, we have to add "ConditionKernelCommandLine=!action_on_fail=continue" to
> emergency.service, too.


Hi Harald,

It is emergency.service takes care of emergency. Now I add
"ConditionKernelCommandLine=!action_on_fail=continue" to
emergency.service, the process just hang there. below is the console output:

[    1.366071] bio: create slab <bio-1> at 1
dracut-initqueue[124]: Warning: Could not boot.
dracut-initqueue[124]: Warning: Not dropping to emergency shell, because
'action_on_fail=continue' was set on the kernel command line.
[  OK  ] Started dracut initqueue hook.
         Mounting /sysroot...
[FAILED] Failed to mount /sysroot.
See 'systemctl status sysroot.mount' for details.
[DEPEND] Dependency failed for Initrd Root File System.
[DEPEND] Dependency failed for Reload Configuration from the Real Root.
[  185.641729] systemd[1]: Unit sysroot.mount entered failed state.
[  185.642906] systemd[1]: Starting Journal Service...
[  185.644860] systemd[1]: Stopped udev Kernel Device Manager.
[  185.645337] systemd[1]: Stopping dracut pre-udev hook...
[  185.645743] systemd[1]: Stopped dracut pre-udev hook.
[  185.647077] systemd[1]: Stopping dracut cmdline hook...
[  185.647498] systemd[1]: Stopped dracut cmdline hook.
[  185.647884] systemd[1]: Starting Setup Virtual Console...
[  185.649641] systemd-journald[49]: Received SIGTERM
[  185.650284] systemd[1]: Stopping udev Kernel Socket.
[  185.650690] systemd[1]: Closed udev Kernel Socket.
[  185.652039] systemd[1]: Stopping udev Control Socket.
[  185.652469] systemd[1]: Closed udev Control Socket.
[  185.656516] systemd[1]: Starting Journal Service...
[  185.657075] systemd[1]: Started Journal Service.


Baoquan
Thanks

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Harald Hoyer]

On 05/31/2013 11:39 AM, Baoquan wrote:
> On 05/30/2013 05:15 PM, Harald Hoyer wrote:
> 
>> Hmm, "ConditionKernelCommandLine=!action_on_fail=continue" _has_ to work.
>> Otherwise I would consider that a serious bug in systemd.
>>
>> Care to elaborate how you tested it?
>>
>> If you are dropped to the shell, can you run:
>>
>> # systemctl status dracut-emergency.service
>> # systemctl status emergency.service
>>
>> to confirm you are not dropped to the emergency.service, which I think this is
>> the case in your test setup.
>>
>> So, we have to add "ConditionKernelCommandLine=!action_on_fail=continue" to
>> emergency.service, too.
> 
> 
> Hi Harald,
> 
> It is emergency.service takes care of emergency. Now I add
> "ConditionKernelCommandLine=!action_on_fail=continue" to
> emergency.service, the process just hang there. below is the console output:
> 
> [    1.366071] bio: create slab <bio-1> at 1
> dracut-initqueue[124]: Warning: Could not boot.
> dracut-initqueue[124]: Warning: Not dropping to emergency shell, because
> 'action_on_fail=continue' was set on the kernel command line.
> [  OK  ] Started dracut initqueue hook.
>          Mounting /sysroot...
> [FAILED] Failed to mount /sysroot.
> See 'systemctl status sysroot.mount' for details.
> [DEPEND] Dependency failed for Initrd Root File System.
> [DEPEND] Dependency failed for Reload Configuration from the Real Root.
> [  185.641729] systemd[1]: Unit sysroot.mount entered failed state.
> [  185.642906] systemd[1]: Starting Journal Service...
> [  185.644860] systemd[1]: Stopped udev Kernel Device Manager.
> [  185.645337] systemd[1]: Stopping dracut pre-udev hook...
> [  185.645743] systemd[1]: Stopped dracut pre-udev hook.
> [  185.647077] systemd[1]: Stopping dracut cmdline hook...
> [  185.647498] systemd[1]: Stopped dracut cmdline hook.
> [  185.647884] systemd[1]: Starting Setup Virtual Console...
> [  185.649641] systemd-journald[49]: Received SIGTERM
> [  185.650284] systemd[1]: Stopping udev Kernel Socket.
> [  185.650690] systemd[1]: Closed udev Kernel Socket.
> [  185.652039] systemd[1]: Stopping udev Control Socket.
> [  185.652469] systemd[1]: Closed udev Control Socket.
> [  185.656516] systemd[1]: Starting Journal Service...
> [  185.657075] systemd[1]: Started Journal Service.
> 
> 
> Baoquan
> Thanks
> 

emergency.service is the last resort emergency.

[harald@lenovo rules (master)]$ fgrep OnFail /lib/systemd/system/*.target
/lib/systemd/system/initrd-fs.target:OnFailure=emergency.target
/lib/systemd/system/initrd-fs.target:OnFailureIsolate=yes
/lib/systemd/system/initrd-root-fs.target:OnFailure=emergency.target
/lib/systemd/system/initrd-root-fs.target:OnFailureIsolate=yes
/lib/systemd/system/initrd.target:OnFailure=emergency.target
/lib/systemd/system/initrd.target:OnFailureIsolate=yes

Maybe we should refrain from isolating to the emergency.target, which starts
emergency.service.

I'll ask on the systemd-devel list.

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan]

On 05/31/2013 05:45 PM, Harald Hoyer wrote:

> emergency.service is the last resort emergency.
> 
> [harald@lenovo rules (master)]$ fgrep OnFail /lib/systemd/system/*.target
> /lib/systemd/system/initrd-fs.target:OnFailure=emergency.target
> /lib/systemd/system/initrd-fs.target:OnFailureIsolate=yes
> /lib/systemd/system/initrd-root-fs.target:OnFailure=emergency.target
> /lib/systemd/system/initrd-root-fs.target:OnFailureIsolate=yes
> /lib/systemd/system/initrd.target:OnFailure=emergency.target
> /lib/systemd/system/initrd.target:OnFailureIsolate=yes
> 
> Maybe we should refrain from isolating to the emergency.target, which starts
> emergency.service.
> 
> I'll ask on the systemd-devel list.


I tried set these OnFailureIsolate=no, seems services not started any
more and systemd hang there.

Re: [Patch v2 2/2] let user specify action after systemd start dracut-emergency

[Baoquan]

On 06/03/2013 11:04 AM, Baoquan wrote:

> On 05/31/2013 05:45 PM, Harald Hoyer wrote:
> 
>> emergency.service is the last resort emergency.
>>
>> [harald@lenovo rules (master)]$ fgrep OnFail /lib/systemd/system/*.target
>> /lib/systemd/system/initrd-fs.target:OnFailure=emergency.target
>> /lib/systemd/system/initrd-fs.target:OnFailureIsolate=yes
>> /lib/systemd/system/initrd-root-fs.target:OnFailure=emergency.target
>> /lib/systemd/system/initrd-root-fs.target:OnFailureIsolate=yes
>> /lib/systemd/system/initrd.target:OnFailure=emergency.target
>> /lib/systemd/system/initrd.target:OnFailureIsolate=yes
>>
>> Maybe we should refrain from isolating to the emergency.target, which starts
>> emergency.service.
>>
>> I'll ask on the systemd-devel list.
> 
> 
> I tried set these OnFailureIsolate=no, seems services not started any
> more and systemd hang there.

Hi Harald,

About this issue, do you have any further suggestion?

Baoquan
Thanks a lot

Re: [Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck

[Vivek Goyal]

On Wed, May 29, 2013 at 04:38:31PM +0800, Baoquan He wrote:
> The fsck is ignored when replace emergency_shell with action_on_fail,
> now add it.

should action_on_fail be named rd.action_on_fail to make it explicit that
this is an initramfs option and not a kernel command line option as such.

Vivek

> 
> Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/99fs-lib/fs-lib.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules.d/99fs-lib/fs-lib.sh b/modules.d/99fs-lib/fs-lib.sh
> index e1f3074..88e7348 100755
> --- a/modules.d/99fs-lib/fs-lib.sh
> +++ b/modules.d/99fs-lib/fs-lib.sh
> @@ -7,14 +7,14 @@ type getarg >/dev/null 2>&1 || . /lib/dracut-lib.sh
>  fsck_ask_reboot() {
>      info "note - fsck suggests reboot, if you"
>      info "leave shell, booting will continue normally"
> -    emergency_shell -n "(reboot ?)"
> +    action_on_fail -n "(reboot ?)"
>  }
>  
>  fsck_ask_err() {
>      warn "*** An error occurred during the file system check."
>      warn "*** Dropping you to a shell; the system will try"
>      warn "*** to mount the filesystem(s), when you leave the shell."
> -    emergency_shell -n "(Repair filesystem)"
> +    action_on_fail -n "(Repair filesystem)"
>  }
>  
>  # inherits: _ret _drv _out
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck

[Harald Hoyer]

On 05/30/2013 07:02 PM, Vivek Goyal wrote:
> On Wed, May 29, 2013 at 04:38:31PM +0800, Baoquan He wrote:
>> The fsck is ignored when replace emergency_shell with action_on_fail,
>> now add it.
> 
> should action_on_fail be named rd.action_on_fail to make it explicit that
> this is an initramfs option and not a kernel command line option as such.
> 
> Vivek

Yes, please