* Bug in dracut-functions.sh@225(print_vars)
@ 2014-04-06 11:38 Sebastian Köln
[not found] ` <201404061338.54350.skoeln-4JCb7EXykGJ5qnkD1ooD3mPhZIeI7moD@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Köln @ 2014-04-06 11:38 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA
Hello,
I stubled upon the following bug (dracut --verbose output):
> ...
> //usr/lib/dracut/modules.d/10i18n/module-setup.sh@132(install_local_i18n):
EXT_KEYMAPS='backspace keypad euro2'
> ...
> /usr/lib/dracut/dracut-functions.sh@224(print_vars): eval printf -v _value
%s '$EXT_KEYMAPS'
> //usr/lib/dracut/dracut-functions.sh@224(print_vars): printf -v _value %s
backspace keypad euro2
> /usr/lib/dracut/dracut-functions.sh@225(print_vars): [[ -n
backspacekeypadeuro2 ]]
> /usr/lib/dracut/dracut-functions.sh@225(print_vars): printf '%s=\"%s\"\n'
EXT_KEYMAPS backspacekeypadeuro2
the "eval" line of print_vars
needs to re replaced by
> eval printf -v _value "%s" \""\$$_var"\"
the modified function is then:
> # Function prints global variables in format name=value line by line.
> # $@ = list of global variables' name
> print_vars() {
> local _var _value
>
> for _var in "$@"
> do
> eval printf -v _value "%s" \""\$$_var"\"
> [[ ${_value} ]] && printf '%s="%s"\n' "$_var" "$_value"
> done
> }
this produces the correct result.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug in dracut-functions.sh@225(print_vars)
[not found] ` <201404061338.54350.skoeln-4JCb7EXykGJ5qnkD1ooD3mPhZIeI7moD@public.gmane.org>
@ 2014-05-20 11:28 ` Harald Hoyer
0 siblings, 0 replies; 2+ messages in thread
From: Harald Hoyer @ 2014-05-20 11:28 UTC (permalink / raw)
To: Sebastian Köln, initramfs-u79uwXL29TY76Z2rM5mHXA
On 06.04.2014 13:38, Sebastian Köln wrote:
> Hello,
>
> I stubled upon the following bug (dracut --verbose output):
>
>> ...
>> //usr/lib/dracut/modules.d/10i18n/module-setup.sh@132(install_local_i18n):
> EXT_KEYMAPS='backspace keypad euro2'
>> ...
>> /usr/lib/dracut/dracut-functions.sh@224(print_vars): eval printf -v _value
> %s '$EXT_KEYMAPS'
>> //usr/lib/dracut/dracut-functions.sh@224(print_vars): printf -v _value %s
> backspace keypad euro2
>> /usr/lib/dracut/dracut-functions.sh@225(print_vars): [[ -n
> backspacekeypadeuro2 ]]
>> /usr/lib/dracut/dracut-functions.sh@225(print_vars): printf '%s=\"%s\"\n'
> EXT_KEYMAPS backspacekeypadeuro2
>
> the "eval" line of print_vars
> needs to re replaced by
>> eval printf -v _value "%s" \""\$$_var"\"
>
> the modified function is then:
>
>> # Function prints global variables in format name=value line by line.
>> # $@ = list of global variables' name
>> print_vars() {
>> local _var _value
>>
>> for _var in "$@"
>> do
>> eval printf -v _value "%s" \""\$$_var"\"
>> [[ ${_value} ]] && printf '%s="%s"\n' "$_var" "$_value"
>> done
>> }
>
> this produces the correct result.
Thanks!
http://git.kernel.org/cgit/boot/dracut/dracut.git/commit/?id=7a94a4326f0641396125acb2b444b562224457a1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-20 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-06 11:38 Bug in dracut-functions.sh@225(print_vars) Sebastian Köln
[not found] ` <201404061338.54350.skoeln-4JCb7EXykGJ5qnkD1ooD3mPhZIeI7moD@public.gmane.org>
2014-05-20 11:28 ` Harald Hoyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox