* [PATCH] drm/i915: Squelch nop wait-for-idle trace
@ 2019-07-23 9:12 Chris Wilson
2019-07-23 10:35 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-07-23 9:12 UTC (permalink / raw)
To: intel-gfx
If the system is already idle, omit the GEM_TRACE saying we are about to
wait for idle. It looks confusing in the logs to see a continual stream
of wait-for-idle, as one immediately assumes it is stuck in a loop.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index c6ba350e6e4f..01dd0d1d9bf6 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -951,15 +951,15 @@ wait_for_timelines(struct drm_i915_private *i915,
int i915_gem_wait_for_idle(struct drm_i915_private *i915,
unsigned int flags, long timeout)
{
+ /* If the device is asleep, we have no requests outstanding */
+ if (!READ_ONCE(i915->gt.awake))
+ return 0;
+
GEM_TRACE("flags=%x (%s), timeout=%ld%s, awake?=%s\n",
flags, flags & I915_WAIT_LOCKED ? "locked" : "unlocked",
timeout, timeout == MAX_SCHEDULE_TIMEOUT ? " (forever)" : "",
yesno(i915->gt.awake));
- /* If the device is asleep, we have no requests outstanding */
- if (!READ_ONCE(i915->gt.awake))
- return 0;
-
timeout = wait_for_timelines(i915, flags, timeout);
if (timeout < 0)
return timeout;
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Squelch nop wait-for-idle trace 2019-07-23 9:12 [PATCH] drm/i915: Squelch nop wait-for-idle trace Chris Wilson @ 2019-07-23 10:35 ` Patchwork 2019-07-23 12:26 ` ✓ Fi.CI.IGT: " Patchwork 2019-07-23 15:54 ` [PATCH] " Summers, Stuart 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2019-07-23 10:35 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch nop wait-for-idle trace URL : https://patchwork.freedesktop.org/series/64066/ State : success == Summary == CI Bug Log - changes from CI_DRM_6537 -> Patchwork_13719 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/ Known issues ------------ Here are the changes found in Patchwork_13719 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_reloc@basic-cpu: - fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-icl-u3/igt@gem_exec_reloc@basic-cpu.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-icl-u3/igt@gem_exec_reloc@basic-cpu.html * igt@i915_selftest@live_execlists: - fi-bwr-2160: [PASS][3] -> [DMESG-WARN][4] ([fdo#111115]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-bwr-2160/igt@i915_selftest@live_execlists.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-bwr-2160/igt@i915_selftest@live_execlists.html * igt@i915_selftest@live_hangcheck: - fi-bwr-2160: [PASS][5] -> [DMESG-FAIL][6] ([fdo#111115]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html #### Possible fixes #### * igt@gem_basic@create-close: - fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-icl-u3/igt@gem_basic@create-close.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-icl-u3/igt@gem_basic@create-close.html * igt@i915_module_load@reload: - fi-blb-e6850: [INCOMPLETE][9] ([fdo#107718]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-blb-e6850/igt@i915_module_load@reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-blb-e6850/igt@i915_module_load@reload.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-7567u: [WARN][11] ([fdo#109380]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-dsi: [FAIL][13] ([fdo#103167]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-icl-dsi/igt@kms_frontbuffer_tracking@basic.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-icl-dsi/igt@kms_frontbuffer_tracking@basic.html - fi-hsw-peppy: [DMESG-WARN][15] ([fdo#102614]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@read-crc-pipe-c: - fi-kbl-7567u: [SKIP][17] ([fdo#109271]) -> [PASS][18] +23 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html * igt@prime_vgem@basic-fence-flip: - fi-ilk-650: [DMESG-WARN][19] ([fdo#106387]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380 [fdo#111115]: https://bugs.freedesktop.org/show_bug.cgi?id=111115 Participating hosts (51 -> 46) ------------------------------ Additional (1): fi-byt-j1900 Missing (6): fi-byt-squawks fi-bsw-cyan fi-cfl-8109u fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_6537 -> Patchwork_13719 CI_DRM_6537: efc5709a1e0f5050b197b51c3fce4cbcc95fe319 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13719: 82379ef704cf88f5e0310e83dc168ed5ba9efc79 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 82379ef704cf drm/i915: Squelch nop wait-for-idle trace == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Squelch nop wait-for-idle trace 2019-07-23 9:12 [PATCH] drm/i915: Squelch nop wait-for-idle trace Chris Wilson 2019-07-23 10:35 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-07-23 12:26 ` Patchwork 2019-07-23 15:54 ` [PATCH] " Summers, Stuart 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2019-07-23 12:26 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch nop wait-for-idle trace URL : https://patchwork.freedesktop.org/series/64066/ State : success == Summary == CI Bug Log - changes from CI_DRM_6537_full -> Patchwork_13719_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_13719_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_workarounds@suspend-resume: - shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-kbl6/igt@gem_workarounds@suspend-resume.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-kbl6/igt@gem_workarounds@suspend-resume.html * igt@kms_busy@basic-modeset-c: - shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb2/igt@kms_busy@basic-modeset-c.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb1/igt@kms_busy@basic-modeset-c.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([fdo#109507]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu: - shard-snb: [PASS][7] -> [SKIP][8] ([fdo#109271]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-blt: - shard-iclb: [PASS][11] -> [INCOMPLETE][12] ([fdo#106978] / [fdo#107713]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-blt.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-apl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_psr@psr2_dpms: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb2/igt@kms_psr@psr2_dpms.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb7/igt@kms_psr@psr2_dpms.html * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend: - shard-skl: [PASS][17] -> [INCOMPLETE][18] ([fdo#104108]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-skl9/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html #### Possible fixes #### * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][19] ([fdo#110854]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb6/igt@gem_exec_balancer@smoke.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb4/igt@gem_exec_balancer@smoke.html * igt@gem_softpin@noreloc-s3: - shard-skl: [INCOMPLETE][21] ([fdo#104108]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-skl5/igt@gem_softpin@noreloc-s3.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-skl4/igt@gem_softpin@noreloc-s3.html * igt@i915_suspend@debugfs-reader: - shard-apl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-apl4/igt@i915_suspend@debugfs-reader.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-apl4/igt@i915_suspend@debugfs-reader.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][25] ([fdo#105363]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][27] ([fdo#105363]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu: - shard-apl: [INCOMPLETE][29] ([fdo#103927]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move: - shard-iclb: [FAIL][31] ([fdo#103167]) -> [PASS][32] +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][35] ([fdo#108145]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [FAIL][37] ([fdo#103166]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][39] ([fdo#109642] / [fdo#111068]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb5/igt@kms_psr2_su@page_flip.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42] +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6537/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 Participating hosts (9 -> 9) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6537 -> Patchwork_13719 CI-20190529: 20190529 CI_DRM_6537: efc5709a1e0f5050b197b51c3fce4cbcc95fe319 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13719: 82379ef704cf88f5e0310e83dc168ed5ba9efc79 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13719/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Squelch nop wait-for-idle trace 2019-07-23 9:12 [PATCH] drm/i915: Squelch nop wait-for-idle trace Chris Wilson 2019-07-23 10:35 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-07-23 12:26 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-07-23 15:54 ` Summers, Stuart 2 siblings, 0 replies; 4+ messages in thread From: Summers, Stuart @ 2019-07-23 15:54 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk [-- Attachment #1.1: Type: text/plain, Size: 1509 bytes --] On Tue, 2019-07-23 at 10:12 +0100, Chris Wilson wrote: > If the system is already idle, omit the GEM_TRACE saying we are about > to > wait for idle. It looks confusing in the logs to see a continual > stream > of wait-for-idle, as one immediately assumes it is stuck in a loop. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Stuart Summers <stuart.summers@intel.com> > --- > drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > b/drivers/gpu/drm/i915/i915_gem.c > index c6ba350e6e4f..01dd0d1d9bf6 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -951,15 +951,15 @@ wait_for_timelines(struct drm_i915_private > *i915, > int i915_gem_wait_for_idle(struct drm_i915_private *i915, > unsigned int flags, long timeout) > { > + /* If the device is asleep, we have no requests outstanding */ > + if (!READ_ONCE(i915->gt.awake)) > + return 0; > + > GEM_TRACE("flags=%x (%s), timeout=%ld%s, awake?=%s\n", > flags, flags & I915_WAIT_LOCKED ? "locked" : > "unlocked", > timeout, timeout == MAX_SCHEDULE_TIMEOUT ? " > (forever)" : "", > yesno(i915->gt.awake)); > > - /* If the device is asleep, we have no requests outstanding */ > - if (!READ_ONCE(i915->gt.awake)) > - return 0; > - > timeout = wait_for_timelines(i915, flags, timeout); > if (timeout < 0) > return timeout; [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3270 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-23 15:54 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-23 9:12 [PATCH] drm/i915: Squelch nop wait-for-idle trace Chris Wilson 2019-07-23 10:35 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-07-23 12:26 ` ✓ Fi.CI.IGT: " Patchwork 2019-07-23 15:54 ` [PATCH] " Summers, Stuart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox