From: "Vudum, Lakshminarayana" <lakshminarayana.vudum@intel.com>
To: "Saarinen, Jani" <jani.saarinen@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Deak, Imre" <imre.deak@intel.com>
Cc: "Lee, Shawn C" <shawn.c.lee@intel.com>,
"Almahallawy, Khaled" <khaled.almahallawy@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Chiou, Cooper" <cooper.chiou@intel.com>,
"Tseng, William" <william.tseng@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result
Date: Mon, 23 Aug 2021 15:13:14 +0000 [thread overview]
Message-ID: <04a5e1d8e2b54893adaab9298d77da66@intel.com> (raw)
In-Reply-To: <DM8PR11MB565526AB906B71F99CE24C8BE0C49@DM8PR11MB5655.namprd11.prod.outlook.com>
Here is the gitlab issue https://gitlab.freedesktop.org/drm/intel/-/issues/4002
Lakshmi.
-----Original Message-----
From: Saarinen, Jani <jani.saarinen@intel.com>
Sent: Monday, August 23, 2021 1:39 AM
To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Deak, Imre <imre.deak@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Cc: Lee, Shawn C <shawn.c.lee@intel.com>; Almahallawy, Khaled <khaled.almahallawy@intel.com>; intel-gfx@lists.freedesktop.org; Chiou, Cooper <cooper.chiou@intel.com>; Tseng, William <william.tseng@intel.com>
Subject: RE: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result
Hi,
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Ville Syrjälä
> Sent: lauantai 21. elokuuta 2021 1.20
> To: Deak, Imre <imre.deak@intel.com>
> Cc: Lee, Shawn C <shawn.c.lee@intel.com>; Almahallawy, Khaled
> <khaled.almahallawy@intel.com>; intel-gfx@lists.freedesktop.org;
> Chiou, Cooper <cooper.chiou@intel.com>; Tseng, William
> <william.tseng@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link
> training result
>
> On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote:
> > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote:
> > > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> > > >On Tue, 2021-07-07, Almahallawy, Khaled
> > > ><khaled.almahallawy@intel.com>
> wrote:
> > > >>I believe Imre's LT fallback:
> > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix
> > > >>and Chrome
> user space fix:
> > > >>https://chromium-review.googlesource.com/c/chromium/src/+/300348
> > > >>7 should address Chrome concerns for LT failure and LTTPRs
> > > >>
> > > >
> > > >Thanks for comment! The new fallback patch should help on this DPRX problem.
> > > >One more thing. If driver did not handle DPRX link train failed properly.
> > > >It would impact link layer compliance test case in below.
> > > >
> > > >400.3.1.3
> > > >400.3.1.4
> > > >400.3.1.6
> > > >400.3.1.12
> > > >400.3.1.13
> > > >400.3.1.14
> > > >
> > > >Best regards,
> > > >Shawn
> > > >
> > >
> > > Hi all, before Imre's patch series land on upstream driver. The
> > > link train failed handling works for LTTPR only. But DPRX does
> > > not. Could you please consider to have this change as temporary solution? Thanks!
> >
> > I sent already fixing this, see
> > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak
> > @i
> > ntel.com/
> >
> > but it fell through the cracks. Applied now your patch, thanks.
>
> We seem to have a tgl that fails consistently at DPRX link training:
> https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html
Yes, @Vudum, Lakshminarayana what is gitlab issue for this?
[Lakshmi] https://gitlab.freedesktop.org/drm/intel/-/issues/4002
>
> Previously the error went unnoticed.
>
> --
> Ville Syrjälä
> Intel
prev parent reply other threads:[~2021-08-23 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 15:25 [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Lee Shawn C
2021-07-06 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-06 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-07-06 23:21 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled
2021-07-07 1:33 ` Lee, Shawn C
2021-08-18 15:09 ` Lee, Shawn C
2021-08-18 16:17 ` Imre Deak
2021-08-20 22:20 ` Ville Syrjälä
2021-08-20 23:02 ` Imre Deak
2021-08-26 17:31 ` Rodrigo Vivi
2021-08-30 6:45 ` Imre Deak
2021-08-30 7:05 ` Saarinen, Jani
2021-08-23 8:38 ` Saarinen, Jani
2021-08-23 15:13 ` Vudum, Lakshminarayana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04a5e1d8e2b54893adaab9298d77da66@intel.com \
--to=lakshminarayana.vudum@intel.com \
--cc=cooper.chiou@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=khaled.almahallawy@intel.com \
--cc=shawn.c.lee@intel.com \
--cc=ville.syrjala@linux.intel.com \
--cc=william.tseng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox