From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: "Lee, Shawn C" <shawn.c.lee@intel.com>,
"Almahallawy, Khaled" <khaled.almahallawy@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Chiou, Cooper" <cooper.chiou@intel.com>,
"Tseng, William" <william.tseng@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result
Date: Sat, 21 Aug 2021 01:20:04 +0300 [thread overview]
Message-ID: <YSAqlKSixZ9CNWNz@intel.com> (raw)
In-Reply-To: <20210818161712.GA2831921@ideak-desk.fi.intel.com>
On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote:
> On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote:
> > On Tue, 2021-07-07, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> > >On Tue, 2021-07-07, Almahallawy, Khaled <khaled.almahallawy@intel.com> wrote:
> > >>I believe Imre's LT fallback:
> > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix:
> > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487
> > >>should address Chrome concerns for LT failure and LTTPRs
> > >>
> > >
> > >Thanks for comment! The new fallback patch should help on this DPRX problem.
> > >One more thing. If driver did not handle DPRX link train failed properly.
> > >It would impact link layer compliance test case in below.
> > >
> > >400.3.1.3
> > >400.3.1.4
> > >400.3.1.6
> > >400.3.1.12
> > >400.3.1.13
> > >400.3.1.14
> > >
> > >Best regards,
> > >Shawn
> > >
> >
> > Hi all, before Imre's patch series land on upstream driver. The link train failed
> > handling works for LTTPR only. But DPRX does not. Could you please consider to have
> > this change as temporary solution? Thanks!
>
> I sent already fixing this, see
> https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/
>
> but it fell through the cracks. Applied now your patch, thanks.
We seem to have a tgl that fails consistently at DPRX link training:
https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html
Previously the error went unnoticed.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-08-20 22:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 15:25 [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result Lee Shawn C
2021-07-06 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-06 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-07-06 23:21 ` [Intel-gfx] [PATCH] " Almahallawy, Khaled
2021-07-07 1:33 ` Lee, Shawn C
2021-08-18 15:09 ` Lee, Shawn C
2021-08-18 16:17 ` Imre Deak
2021-08-20 22:20 ` Ville Syrjälä [this message]
2021-08-20 23:02 ` Imre Deak
2021-08-26 17:31 ` Rodrigo Vivi
2021-08-30 6:45 ` Imre Deak
2021-08-30 7:05 ` Saarinen, Jani
2021-08-23 8:38 ` Saarinen, Jani
2021-08-23 15:13 ` Vudum, Lakshminarayana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSAqlKSixZ9CNWNz@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=cooper.chiou@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=khaled.almahallawy@intel.com \
--cc=shawn.c.lee@intel.com \
--cc=william.tseng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox