From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup the plane->pipe fixup code
Date: Sat, 08 Sep 2012 20:00:37 +0100 [thread overview]
Message-ID: <051c15$48abv5@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1347120892-1063-1-git-send-email-daniel.vetter@ffwll.ch>
On Sat, 8 Sep 2012 18:14:52 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> We need to check whether the _other plane is on our pipe, not whether
> our plane is on the other pipe. Otherwise if not both pipes/planes are
> active, we won't properly clean up the mess and set up our desired
> plane->pipe mapping.
>
> v2: Fixup the logic, I've totally fumbled it. Noticed by Chris Wilson.
Frankly I'd be happier if we did both as that way we should be
idiotproof, and more importantly obviously safe.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-09-08 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 20:09 [PATCH] drm/i915: fixup the plane->pipe fixup code Daniel Vetter
2012-09-07 9:46 ` Chris Wilson
2012-09-08 16:14 ` Daniel Vetter
2012-09-08 19:00 ` Chris Wilson [this message]
2012-09-11 6:17 ` Daniel Vetter
2012-09-12 10:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='051c15$48abv5@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox