Re: [PATCH v3 1/6] drm/display: Add missing aux less alpm wake related bits

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2024-03-13 at 11:14 +0000, Manna, Animesh wrote:
> 
> 
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@intel.com>
> > Sent: Wednesday, March 6, 2024 4:15 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>; Manna, Animesh
> > <animesh.manna@intel.com>; Murthy, Arun R
> > <arun.r.murthy@intel.com>;
> > Hogander, Jouni <jouni.hogander@intel.com>
> > Subject: [PATCH v3 1/6] drm/display: Add missing aux less alpm wake
> > related
> > bits
> > 
> > eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and
> > DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these.
> 
> Good to add this patch with the patch series where _CAP and _CONFIG
> registers will be used.

Ok, I will drop it from this set.

BR,

Jouni Högander
> 
> Regards,
> Animesh
> 
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >  include/drm/display/drm_dp.h | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/drm/display/drm_dp.h
> > b/include/drm/display/drm_dp.h
> > index 4891bd916d26..651d117d636d 100644
> > --- a/include/drm/display/drm_dp.h
> > +++ b/include/drm/display/drm_dp.h
> > @@ -232,6 +232,8 @@
> > 
> >  #define DP_RECEIVER_ALPM_CAP               0x02e   /* eDP 1.4 */
> >  # define DP_ALPM_CAP                       (1 << 0)
> > +# define DP_ALPM_PM_STATE_2A_SUPPORT       (1 << 1) /* eDP 1.5 */
> > +# define DP_ALPM_AUX_LESS_CAP              (1 << 2) /* eDP 1.5 */
> > 
> >  #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CAP   0x02f   /* eDP 1.4 */
> >  # define DP_AUX_FRAME_SYNC_CAP             (1 << 0)
> > @@ -677,7 +679,8 @@
> > 
> >  #define DP_RECEIVER_ALPM_CONFIG                    0x116   /* eDP
> > 1.4 */
> >  # define DP_ALPM_ENABLE                            (1 << 0)
> > -# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE  (1 << 1)
> > +# define DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE  (1 << 1) /* eDP 1.5 */
> > +# define DP_ALPM_MODE_AUX_LESS             (1 << 2) /* eDP 1.5 */
> > 
> >  #define DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF  0x117   /* eDP 1.4 */
> >  # define DP_AUX_FRAME_SYNC_ENABLE          (1 << 0)
> > --
> > 2.34.1
>