From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Animesh Manna" <animesh.manna@intel.com>,
"Arun R Murthy" <arun.r.murthy@intel.com>,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for PSR1 or DP2.0 Panel Replay
Date: Wed, 6 Mar 2024 12:45:13 +0200 [thread overview]
Message-ID: <20240306104513.2129442-7-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240306104513.2129442-1-jouni.hogander@intel.com>
No need to write ALPM configuration for DP2.0 Panel Replay or PSR1.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 4cd2bad5241f..c7bda37444f0 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1699,7 +1699,8 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp)
struct intel_psr *psr = &intel_dp->psr;
u32 alpm_ctl;
- if (DISPLAY_VER(dev_priv) < 20)
+ if (DISPLAY_VER(dev_priv) < 20 || (!intel_dp->psr.psr2_enabled &&
+ !intel_dp_is_edp(intel_dp)))
return;
if (intel_dp->psr.panel_replay_enabled && intel_dp_is_edp(intel_dp)) {
--
2.34.1
next prev parent reply other threads:[~2024-03-06 10:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 10:45 [PATCH v3 0/6] ALPM AUX-Less Jouni Högander
2024-03-06 10:45 ` [PATCH v3 1/6] drm/display: Add missing aux less alpm wake related bits Jouni Högander
2024-03-13 11:14 ` Manna, Animesh
2024-03-13 12:05 ` Hogander, Jouni
2024-03-06 10:45 ` [PATCH v3 2/6] drm/i915/psr: Add missing ALPM AUX-Less register definitions Jouni Högander
2024-03-06 10:45 ` [PATCH v3 3/6] drm/i915/psr: Calculate aux less wake time Jouni Högander
2024-03-13 11:14 ` Manna, Animesh
2024-03-13 12:11 ` Hogander, Jouni
2024-03-06 10:45 ` [PATCH v3 4/6] drm/i915/psr: Silence period and lfps half cycle Jouni Högander
2024-03-06 10:45 ` [PATCH v3 5/6] drm/i915/psr: Enable ALPM for eDP Panel replay Jouni Högander
2024-03-13 11:15 ` Manna, Animesh
2024-03-13 12:15 ` Hogander, Jouni
2024-03-06 10:45 ` Jouni Högander [this message]
2024-03-13 11:18 ` [PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for PSR1 or DP2.0 Panel Replay Manna, Animesh
2024-03-13 12:23 ` Hogander, Jouni
2024-03-06 20:03 ` ✗ Fi.CI.CHECKPATCH: warning for ALPM AUX-Less (rev3) Patchwork
2024-03-06 20:03 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-06 20:17 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-07 15:11 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306104513.2129442-7-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox