Re: [RFC 2/4] drm/i915/perf: Add support for collecting 64 bit timestamps with OA reports

From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Sourab Gupta <sourab.gupta@intel.com>,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [RFC 2/4] drm/i915/perf: Add support for collecting 64 bit timestamps with OA reports
Date: Wed, 6 Dec 2017 16:01:53 +0000	[thread overview]
Message-ID: <0808a708-ab6a-5188-19d0-9ad7f9618fe6@intel.com> (raw)
In-Reply-To: <1510748034-14034-3-git-send-email-sagar.a.kamble@intel.com>

On 15/11/17 12:13, Sagar Arun Kamble wrote:
> --- a/include/uapi/drm/i915_drm.h
> +++ b/include/uapi/drm/i915_drm.h
> @@ -1447,6 +1447,12 @@ enum drm_i915_perf_property_id {
>   	DRM_I915_PERF_PROP_SAMPLE_OA,
>   
>   	/**
> +	 * The value of this property set to 1 requests inclusion of GPU
> +	 * timestamp in the perf sample data.
> +	 */
> +	DRM_I915_PERF_PROP_SAMPLE_GPU_TS,
> +
> +	/**
>   	 * The value specifies which set of OA unit metrics should be
>   	 * be configured, defining the contents of any OA unit reports.
>   	 */

Inserting this, not at the end of this enum break API/ABI.
This applies to other patches too.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx