Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "Intel-gfx@lists.freedesktop.org"
	<Intel-gfx@lists.freedesktop.org>,
	"Hogander, Jouni" <jouni.hogander@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/psr: Remove inappropriate DSC slice alignment warning
Date: Tue, 1 Nov 2022 20:00:52 +0000	[thread overview]
Message-ID: <0839ad26187a137e1a1afb80ea6dc40d5dc9e3f0.camel@intel.com> (raw)
In-Reply-To: <20221021054922.2753034-1-jouni.hogander@intel.com>

On Fri, 2022-10-21 at 08:49 +0300, Jouni Högander wrote:
> Selective update area is now aligned with DSC slice height when
> DSC is enabled. Remove inappropriate warning about missing DSC
> alignment.
> 
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Mika Kahola <mika.kahola@intel.com>
> 
> Fixes: 47d4ae2192cb ("drm/i915/mtl: Extend PSR support")
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7212
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 904a1049eff3..64e9e134fdca 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1678,9 +1678,6 @@ static void intel_psr2_sel_fetch_pipe_alignment(const struct intel_crtc_state *c
>  	pipe_clip->y1 -= pipe_clip->y1 % y_alignment;
>  	if (pipe_clip->y2 % y_alignment)
>  		pipe_clip->y2 = ((pipe_clip->y2 / y_alignment) + 1) * y_alignment;
> -
> -	if (IS_ALDERLAKE_P(dev_priv) && crtc_state->dsc.compression_enable)
> -		drm_warn(&dev_priv->drm, "Missing PSR2 sel fetch alignment with DSC\n");

It is necessary check if DSC alignment and PSR2 alignment matches, if not PSR2 can't be enabled.

>  }
>  
>  /*


  parent reply	other threads:[~2022-11-01 20:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  5:49 [Intel-gfx] [PATCH] drm/i915/psr: Remove inappropriate DSC slice alignment warning Jouni Högander
2022-10-21  7:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-10-21  8:17 ` [Intel-gfx] [PATCH] " Kahola, Mika
2022-10-21 11:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2022-10-24 15:34 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2022-11-01 20:00 ` Souza, Jose [this message]
2022-11-01 20:55   ` [Intel-gfx] [PATCH] " Hogander, Jouni
2022-11-01 21:02     ` Souza, Jose
2022-11-02 17:48       ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0839ad26187a137e1a1afb80ea6dc40d5dc9e3f0.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox