Re: [PATCH] drm/i915: Remove i915_execbuffer_params

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 03/02/2017 12:45, Joonas Lahtinen wrote:
> On pe, 2017-02-03 at 10:46 +0000, Chris Wilson wrote:
>> On Fri, Feb 03, 2017 at 10:33:44AM +0000, Tvrtko Ursulin wrote:
>>>
>>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Tidy i915_gem_do_execbuffer by removing the structure which
>>> is under no plans to be used any longer.
>>>
>>> This improves the redability of the code, decreases lines
>>> of source and shrinks the binary.
>>
>> If you put them alongside the params we pass along, it is even better.
>>
>> https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler&id=33dc0f3f6d065cf76abd9ad9778c182519fb49a8
>>
>> is what I've been trying to get in for the year or so.
>
> Well, the remaining bits could be moved like that, yep.
>
> But I'd do it as a second patch on top of this, for easier review.

I was thinking the same. If nothing else every time I stumble upon that 
poorly aligned params assignment block I feel bad so that was the 
motivation to clean it up.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx