From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove i915_execbuffer_params
Date: Fri, 03 Feb 2017 14:45:23 +0200 [thread overview]
Message-ID: <1486125923.2953.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170203104655.GM17696@nuc-i3427.alporthouse.com>
On pe, 2017-02-03 at 10:46 +0000, Chris Wilson wrote:
> On Fri, Feb 03, 2017 at 10:33:44AM +0000, Tvrtko Ursulin wrote:
> >
> > > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > Tidy i915_gem_do_execbuffer by removing the structure which
> > is under no plans to be used any longer.
> >
> > This improves the redability of the code, decreases lines
> > of source and shrinks the binary.
>
> If you put them alongside the params we pass along, it is even better.
>
> https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=prescheduler&id=33dc0f3f6d065cf76abd9ad9778c182519fb49a8
>
> is what I've been trying to get in for the year or so.
Well, the remaining bits could be moved like that, yep.
But I'd do it as a second patch on top of this, for easier review.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-03 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 10:33 [PATCH] drm/i915: Remove i915_execbuffer_params Tvrtko Ursulin
2017-02-03 10:46 ` Chris Wilson
2017-02-03 12:45 ` Joonas Lahtinen [this message]
2017-02-08 14:47 ` Tvrtko Ursulin
2017-02-03 12:24 ` ✗ Fi.CI.BAT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486125923.2953.3.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox