* Rework TTMs busy handling
@ 2024-01-04 15:05 Christian König
2024-01-04 15:05 ` [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
` (7 more replies)
0 siblings, 8 replies; 11+ messages in thread
From: Christian König @ 2024-01-04 15:05 UTC (permalink / raw)
To: dri-devel, intel-gfx, thomas.hellstrom, nouveau, jani.nikula,
kherbst, lyude, zackr
Hi guys,
I'm trying to make this functionality a bit more useful for years now
since we multiple reports that behavior of drivers can be suboptimal
when multiple placements be given.
So basically instead of hacking around the TTM behavior in the driver
once more I've gone ahead and changed the idle/busy placement list
into idle/busy placement flags. This not only saves a bunch of code,
but also allows setting some placements as fallback which are used if
allocating from the preferred ones didn't worked.
Intel CI seems to be happy with those patches, so any more comments?
Regards,
Christian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
2024-01-04 15:05 Rework TTMs busy handling Christian König
@ 2024-01-04 15:05 ` Christian König
2024-01-04 15:05 ` [PATCH 2/4] drm/ttm: replace busy placement with flags v4 Christian König
` (6 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Christian König @ 2024-01-04 15:05 UTC (permalink / raw)
To: dri-devel, intel-gfx, thomas.hellstrom, nouveau, jani.nikula,
kherbst, lyude, zackr
Only convert it to ENOMEM in ttm_bo_validate.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index edf10618fe2b..8c1eaa74fa21 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -830,7 +830,7 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
goto error;
}
- ret = -ENOMEM;
+ ret = -ENOSPC;
if (!type_found) {
pr_err(TTM_PFX "No compatible memory type found\n");
ret = -EINVAL;
@@ -916,6 +916,9 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
return -EINVAL;
ret = ttm_bo_move_buffer(bo, placement, ctx);
+ /* For backward compatibility with userspace */
+ if (ret == -ENOSPC)
+ return -ENOMEM;
if (ret)
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/4] drm/ttm: replace busy placement with flags v4
2024-01-04 15:05 Rework TTMs busy handling Christian König
2024-01-04 15:05 ` [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
@ 2024-01-04 15:05 ` Christian König
2024-01-04 20:02 ` Zack Rusin
2024-01-04 15:05 ` [PATCH 3/4] drm/ttm: improve idle/busy handling v2 Christian König
` (5 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: Christian König @ 2024-01-04 15:05 UTC (permalink / raw)
To: dri-devel, intel-gfx, thomas.hellstrom, nouveau, jani.nikula,
kherbst, lyude, zackr
From: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
Instead of a list of separate busy placement add flags which indicate
that a placement should only be used when there is room or if we need to
evict.
v2: add missing TTM_PL_FLAG_IDLE for i915
v3: fix auto build test ERROR on drm-tip/drm-tip
v4: fix some typos pointed out by checkpatch
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 +--
drivers/gpu/drm/drm_gem_vram_helper.c | 2 -
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 37 ++++----
drivers/gpu/drm/loongson/lsdc_ttm.c | 2 -
drivers/gpu/drm/nouveau/nouveau_bo.c | 59 +++++--------
drivers/gpu/drm/nouveau/nouveau_bo.h | 1 -
drivers/gpu/drm/qxl/qxl_object.c | 2 -
drivers/gpu/drm/qxl/qxl_ttm.c | 2 -
drivers/gpu/drm/radeon/radeon_object.c | 2 -
drivers/gpu/drm/radeon/radeon_ttm.c | 8 +-
drivers/gpu/drm/radeon/radeon_uvd.c | 1 -
drivers/gpu/drm/ttm/ttm_bo.c | 21 +++--
drivers/gpu/drm/ttm/ttm_resource.c | 73 ++++------------
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 -
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 99 +++++++++++++++++-----
include/drm/ttm/ttm_placement.h | 10 ++-
include/drm/ttm/ttm_resource.h | 8 +-
18 files changed, 159 insertions(+), 187 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index cef920a93924..aa0dd6dad068 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -220,9 +220,6 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
placement->num_placement = c;
placement->placement = places;
-
- placement->num_busy_placement = c;
- placement->busy_placement = places;
}
/**
@@ -1406,8 +1403,7 @@ vm_fault_t amdgpu_bo_fault_reserve_notify(struct ttm_buffer_object *bo)
AMDGPU_GEM_DOMAIN_GTT);
/* Avoid costly evictions; only set GTT as a busy placement */
- abo->placement.num_busy_placement = 1;
- abo->placement.busy_placement = &abo->placements[1];
+ abo->placements[0].flags |= TTM_PL_FLAG_IDLE;
r = ttm_bo_validate(bo, &abo->placement, &ctx);
if (unlikely(r == -EBUSY || r == -ERESTARTSYS))
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 05991c5c8ddb..9a6a00b1af40 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -102,23 +102,19 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
/* Don't handle scatter gather BOs */
if (bo->type == ttm_bo_type_sg) {
placement->num_placement = 0;
- placement->num_busy_placement = 0;
return;
}
/* Object isn't an AMDGPU object so ignore */
if (!amdgpu_bo_is_amdgpu_bo(bo)) {
placement->placement = &placements;
- placement->busy_placement = &placements;
placement->num_placement = 1;
- placement->num_busy_placement = 1;
return;
}
abo = ttm_to_amdgpu_bo(bo);
if (abo->flags & AMDGPU_GEM_CREATE_DISCARDABLE) {
placement->num_placement = 0;
- placement->num_busy_placement = 0;
return;
}
@@ -128,13 +124,13 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
case AMDGPU_PL_OA:
case AMDGPU_PL_DOORBELL:
placement->num_placement = 0;
- placement->num_busy_placement = 0;
return;
case TTM_PL_VRAM:
if (!adev->mman.buffer_funcs_enabled) {
/* Move to system memory */
amdgpu_bo_placement_from_domain(abo, AMDGPU_GEM_DOMAIN_CPU);
+
} else if (!amdgpu_gmc_vram_full_visible(&adev->gmc) &&
!(abo->flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) &&
amdgpu_bo_in_cpu_visible_vram(abo)) {
@@ -149,8 +145,7 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
AMDGPU_GEM_DOMAIN_CPU);
abo->placements[0].fpfn = adev->gmc.visible_vram_size >> PAGE_SHIFT;
abo->placements[0].lpfn = 0;
- abo->placement.busy_placement = &abo->placements[1];
- abo->placement.num_busy_placement = 1;
+ abo->placements[0].flags |= TTM_PL_FLAG_IDLE;
} else {
/* Move to GTT memory */
amdgpu_bo_placement_from_domain(abo, AMDGPU_GEM_DOMAIN_GTT |
@@ -967,8 +962,6 @@ int amdgpu_ttm_alloc_gart(struct ttm_buffer_object *bo)
/* allocate GART space */
placement.num_placement = 1;
placement.placement = &placements;
- placement.num_busy_placement = 1;
- placement.busy_placement = &placements;
placements.fpfn = 0;
placements.lpfn = adev->gmc.gart_size >> PAGE_SHIFT;
placements.mem_type = TTM_PL_TT;
diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
index b67eafa55715..75f2eaf0d5b6 100644
--- a/drivers/gpu/drm/drm_gem_vram_helper.c
+++ b/drivers/gpu/drm/drm_gem_vram_helper.c
@@ -147,7 +147,6 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
invariant_flags = TTM_PL_FLAG_TOPDOWN;
gbo->placement.placement = gbo->placements;
- gbo->placement.busy_placement = gbo->placements;
if (pl_flag & DRM_GEM_VRAM_PL_FLAG_VRAM) {
gbo->placements[c].mem_type = TTM_PL_VRAM;
@@ -160,7 +159,6 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
}
gbo->placement.num_placement = c;
- gbo->placement.num_busy_placement = c;
for (i = 0; i < c; ++i) {
gbo->placements[i].fpfn = 0;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 9227f8146a58..48fc9779fd50 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -65,8 +65,6 @@ static const struct ttm_place sys_placement_flags = {
static struct ttm_placement i915_sys_placement = {
.num_placement = 1,
.placement = &sys_placement_flags,
- .num_busy_placement = 1,
- .busy_placement = &sys_placement_flags,
};
/**
@@ -157,32 +155,28 @@ i915_ttm_place_from_region(const struct intel_memory_region *mr,
static void
i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
- struct ttm_place *requested,
- struct ttm_place *busy,
+ struct ttm_place *places,
struct ttm_placement *placement)
{
unsigned int num_allowed = obj->mm.n_placements;
unsigned int flags = obj->flags;
unsigned int i;
- placement->num_placement = 1;
+ places[0].flags |= TTM_PL_FLAG_IDLE;
i915_ttm_place_from_region(num_allowed ? obj->mm.placements[0] :
- obj->mm.region, requested, obj->bo_offset,
+ obj->mm.region, &places[0], obj->bo_offset,
obj->base.size, flags);
/* Cache this on object? */
- placement->num_busy_placement = num_allowed;
- for (i = 0; i < placement->num_busy_placement; ++i)
- i915_ttm_place_from_region(obj->mm.placements[i], busy + i,
- obj->bo_offset, obj->base.size, flags);
-
- if (num_allowed == 0) {
- *busy = *requested;
- placement->num_busy_placement = 1;
+ for (i = 0; i < num_allowed; ++i) {
+ i915_ttm_place_from_region(obj->mm.placements[i],
+ &places[i + 1], obj->bo_offset,
+ obj->base.size, flags);
+ places[i + 1].flags |= TTM_PL_FLAG_BUSY;
}
- placement->placement = requested;
- placement->busy_placement = busy;
+ placement->num_placement = num_allowed + 1;
+ placement->placement = places;
}
static int i915_ttm_tt_shmem_populate(struct ttm_device *bdev,
@@ -789,7 +783,8 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
int ret;
/* First try only the requested placement. No eviction. */
- real_num_busy = fetch_and_zero(&placement->num_busy_placement);
+ real_num_busy = placement->num_placement;
+ placement->num_placement = 1;
ret = ttm_bo_validate(bo, placement, &ctx);
if (ret) {
ret = i915_ttm_err_to_gem(ret);
@@ -805,7 +800,7 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
* If the initial attempt fails, allow all accepted placements,
* evicting if necessary.
*/
- placement->num_busy_placement = real_num_busy;
+ placement->num_placement = real_num_busy;
ret = ttm_bo_validate(bo, placement, &ctx);
if (ret)
return i915_ttm_err_to_gem(ret);
@@ -839,7 +834,7 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
{
- struct ttm_place requested, busy[I915_TTM_MAX_PLACEMENTS];
+ struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1];
struct ttm_placement placement;
/* restricted by sg_alloc_table */
@@ -849,7 +844,7 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
GEM_BUG_ON(obj->mm.n_placements > I915_TTM_MAX_PLACEMENTS);
/* Move to the requested placement. */
- i915_ttm_placement_from_obj(obj, &requested, busy, &placement);
+ i915_ttm_placement_from_obj(obj, places, &placement);
return __i915_ttm_get_pages(obj, &placement);
}
@@ -879,9 +874,7 @@ static int __i915_ttm_migrate(struct drm_i915_gem_object *obj,
i915_ttm_place_from_region(mr, &requested, obj->bo_offset,
obj->base.size, flags);
placement.num_placement = 1;
- placement.num_busy_placement = 1;
placement.placement = &requested;
- placement.busy_placement = &requested;
ret = __i915_ttm_get_pages(obj, &placement);
if (ret)
diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c
index bf79dc55afa4..465f622ac05d 100644
--- a/drivers/gpu/drm/loongson/lsdc_ttm.c
+++ b/drivers/gpu/drm/loongson/lsdc_ttm.c
@@ -54,7 +54,6 @@ static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
pflags |= TTM_PL_FLAG_TOPDOWN;
lbo->placement.placement = lbo->placements;
- lbo->placement.busy_placement = lbo->placements;
if (domain & LSDC_GEM_DOMAIN_VRAM) {
lbo->placements[c].mem_type = TTM_PL_VRAM;
@@ -77,7 +76,6 @@ static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
}
lbo->placement.num_placement = c;
- lbo->placement.num_busy_placement = c;
for (i = 0; i < c; ++i) {
lbo->placements[i].fpfn = 0;
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index b7dda486a7ea..575875b6e47e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -403,27 +403,6 @@ nouveau_bo_new(struct nouveau_cli *cli, u64 size, int align,
return 0;
}
-static void
-set_placement_list(struct ttm_place *pl, unsigned *n, uint32_t domain)
-{
- *n = 0;
-
- if (domain & NOUVEAU_GEM_DOMAIN_VRAM) {
- pl[*n].mem_type = TTM_PL_VRAM;
- pl[*n].flags = 0;
- (*n)++;
- }
- if (domain & NOUVEAU_GEM_DOMAIN_GART) {
- pl[*n].mem_type = TTM_PL_TT;
- pl[*n].flags = 0;
- (*n)++;
- }
- if (domain & NOUVEAU_GEM_DOMAIN_CPU) {
- pl[*n].mem_type = TTM_PL_SYSTEM;
- pl[(*n)++].flags = 0;
- }
-}
-
static void
set_placement_range(struct nouveau_bo *nvbo, uint32_t domain)
{
@@ -451,10 +430,6 @@ set_placement_range(struct nouveau_bo *nvbo, uint32_t domain)
nvbo->placements[i].fpfn = fpfn;
nvbo->placements[i].lpfn = lpfn;
}
- for (i = 0; i < nvbo->placement.num_busy_placement; ++i) {
- nvbo->busy_placements[i].fpfn = fpfn;
- nvbo->busy_placements[i].lpfn = lpfn;
- }
}
}
@@ -462,15 +437,32 @@ void
nouveau_bo_placement_set(struct nouveau_bo *nvbo, uint32_t domain,
uint32_t busy)
{
- struct ttm_placement *pl = &nvbo->placement;
+ unsigned int *n = &nvbo->placement.num_placement;
+ struct ttm_place *pl = nvbo->placements;
- pl->placement = nvbo->placements;
- set_placement_list(nvbo->placements, &pl->num_placement, domain);
+ domain |= busy;
- pl->busy_placement = nvbo->busy_placements;
- set_placement_list(nvbo->busy_placements, &pl->num_busy_placement,
- domain | busy);
+ *n = 0;
+ if (domain & NOUVEAU_GEM_DOMAIN_VRAM) {
+ pl[*n].mem_type = TTM_PL_VRAM;
+ pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_VRAM ?
+ TTM_PL_FLAG_BUSY : 0;
+ (*n)++;
+ }
+ if (domain & NOUVEAU_GEM_DOMAIN_GART) {
+ pl[*n].mem_type = TTM_PL_TT;
+ pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_GART ?
+ TTM_PL_FLAG_BUSY : 0;
+ (*n)++;
+ }
+ if (domain & NOUVEAU_GEM_DOMAIN_CPU) {
+ pl[*n].mem_type = TTM_PL_SYSTEM;
+ pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_CPU ?
+ TTM_PL_FLAG_BUSY : 0;
+ (*n)++;
+ }
+ nvbo->placement.placement = nvbo->placements;
set_placement_range(nvbo, domain);
}
@@ -1313,11 +1305,6 @@ vm_fault_t nouveau_ttm_fault_reserve_notify(struct ttm_buffer_object *bo)
nvbo->placements[i].lpfn = mappable;
}
- for (i = 0; i < nvbo->placement.num_busy_placement; ++i) {
- nvbo->busy_placements[i].fpfn = 0;
- nvbo->busy_placements[i].lpfn = mappable;
- }
-
nouveau_bo_placement_set(nvbo, NOUVEAU_GEM_DOMAIN_VRAM, 0);
}
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.h b/drivers/gpu/drm/nouveau/nouveau_bo.h
index 70c551921a9e..e9dfab6a8156 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.h
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.h
@@ -15,7 +15,6 @@ struct nouveau_bo {
struct ttm_placement placement;
u32 valid_domains;
struct ttm_place placements[3];
- struct ttm_place busy_placements[3];
bool force_coherent;
struct ttm_bo_kmap_obj kmap;
struct list_head head;
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index 06a58dad5f5c..1e46b0a6e478 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -66,7 +66,6 @@ void qxl_ttm_placement_from_domain(struct qxl_bo *qbo, u32 domain)
pflag |= TTM_PL_FLAG_TOPDOWN;
qbo->placement.placement = qbo->placements;
- qbo->placement.busy_placement = qbo->placements;
if (domain == QXL_GEM_DOMAIN_VRAM) {
qbo->placements[c].mem_type = TTM_PL_VRAM;
qbo->placements[c++].flags = pflag;
@@ -86,7 +85,6 @@ void qxl_ttm_placement_from_domain(struct qxl_bo *qbo, u32 domain)
qbo->placements[c++].flags = 0;
}
qbo->placement.num_placement = c;
- qbo->placement.num_busy_placement = c;
for (i = 0; i < c; ++i) {
qbo->placements[i].fpfn = 0;
qbo->placements[i].lpfn = 0;
diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
index 1a82629bce3f..765a144cea14 100644
--- a/drivers/gpu/drm/qxl/qxl_ttm.c
+++ b/drivers/gpu/drm/qxl/qxl_ttm.c
@@ -60,9 +60,7 @@ static void qxl_evict_flags(struct ttm_buffer_object *bo,
if (!qxl_ttm_bo_is_qxl_bo(bo)) {
placement->placement = &placements;
- placement->busy_placement = &placements;
placement->num_placement = 1;
- placement->num_busy_placement = 1;
return;
}
qbo = to_qxl_bo(bo);
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index 10c0fbd9d2b4..a955f8a2f7fe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -78,7 +78,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
u32 c = 0, i;
rbo->placement.placement = rbo->placements;
- rbo->placement.busy_placement = rbo->placements;
if (domain & RADEON_GEM_DOMAIN_VRAM) {
/* Try placing BOs which don't need CPU access outside of the
* CPU accessible part of VRAM
@@ -114,7 +113,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
rbo->placement.num_placement = c;
- rbo->placement.num_busy_placement = c;
for (i = 0; i < c; ++i) {
if ((rbo->flags & RADEON_GEM_CPU_ACCESS) &&
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index de4e6d78f1e1..d641f3040117 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -92,9 +92,7 @@ static void radeon_evict_flags(struct ttm_buffer_object *bo,
if (!radeon_ttm_bo_is_radeon_bo(bo)) {
placement->placement = &placements;
- placement->busy_placement = &placements;
placement->num_placement = 1;
- placement->num_busy_placement = 1;
return;
}
rbo = container_of(bo, struct radeon_bo, tbo);
@@ -114,15 +112,11 @@ static void radeon_evict_flags(struct ttm_buffer_object *bo,
*/
radeon_ttm_placement_from_domain(rbo, RADEON_GEM_DOMAIN_VRAM |
RADEON_GEM_DOMAIN_GTT);
- rbo->placement.num_busy_placement = 0;
for (i = 0; i < rbo->placement.num_placement; i++) {
if (rbo->placements[i].mem_type == TTM_PL_VRAM) {
if (rbo->placements[i].fpfn < fpfn)
rbo->placements[i].fpfn = fpfn;
- } else {
- rbo->placement.busy_placement =
- &rbo->placements[i];
- rbo->placement.num_busy_placement = 1;
+ rbo->placements[0].flags |= TTM_PL_FLAG_IDLE;
}
}
} else
diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
index a2cda184b2b2..058a1c8451b2 100644
--- a/drivers/gpu/drm/radeon/radeon_uvd.c
+++ b/drivers/gpu/drm/radeon/radeon_uvd.c
@@ -324,7 +324,6 @@ void radeon_uvd_force_into_uvd_segment(struct radeon_bo *rbo,
rbo->placements[1].fpfn += (256 * 1024 * 1024) >> PAGE_SHIFT;
rbo->placements[1].lpfn += (256 * 1024 * 1024) >> PAGE_SHIFT;
rbo->placement.num_placement++;
- rbo->placement.num_busy_placement++;
}
void radeon_uvd_free_handles(struct radeon_device *rdev, struct drm_file *filp)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 8c1eaa74fa21..aa12bd5cfd17 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -410,8 +410,8 @@ static int ttm_bo_bounce_temp_buffer(struct ttm_buffer_object *bo,
struct ttm_resource *hop_mem;
int ret;
- hop_placement.num_placement = hop_placement.num_busy_placement = 1;
- hop_placement.placement = hop_placement.busy_placement = hop;
+ hop_placement.num_placement = 1;
+ hop_placement.placement = hop;
/* find space in the bounce domain */
ret = ttm_bo_mem_space(bo, &hop_placement, &hop_mem, ctx);
@@ -440,10 +440,9 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
dma_resv_assert_held(bo->base.resv);
placement.num_placement = 0;
- placement.num_busy_placement = 0;
bdev->funcs->evict_flags(bo, &placement);
- if (!placement.num_placement && !placement.num_busy_placement) {
+ if (!placement.num_placement) {
ret = ttm_bo_wait_ctx(bo, ctx);
if (ret)
return ret;
@@ -791,6 +790,9 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
const struct ttm_place *place = &placement->placement[i];
struct ttm_resource_manager *man;
+ if (place->flags & TTM_PL_FLAG_BUSY)
+ continue;
+
man = ttm_manager_type(bdev, place->mem_type);
if (!man || !ttm_resource_manager_used(man))
continue;
@@ -813,10 +815,13 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
return 0;
}
- for (i = 0; i < placement->num_busy_placement; ++i) {
- const struct ttm_place *place = &placement->busy_placement[i];
+ for (i = 0; i < placement->num_placement; ++i) {
+ const struct ttm_place *place = &placement->placement[i];
struct ttm_resource_manager *man;
+ if (place->flags & TTM_PL_FLAG_IDLE)
+ continue;
+
man = ttm_manager_type(bdev, place->mem_type);
if (!man || !ttm_resource_manager_used(man))
continue;
@@ -904,11 +909,11 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
/*
* Remove the backing store if no placement is given.
*/
- if (!placement->num_placement && !placement->num_busy_placement)
+ if (!placement->num_placement)
return ttm_bo_pipeline_gutting(bo);
/* Check whether we need to move buffer. */
- if (bo->resource && ttm_resource_compat(bo->resource, placement))
+ if (bo->resource && ttm_resource_compatible(bo->resource, placement))
return 0;
/* Moving of pinned BOs is forbidden */
diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
index 02b96d23fdb9..fb14f7716cf8 100644
--- a/drivers/gpu/drm/ttm/ttm_resource.c
+++ b/drivers/gpu/drm/ttm/ttm_resource.c
@@ -291,37 +291,15 @@ bool ttm_resource_intersects(struct ttm_device *bdev,
}
/**
- * ttm_resource_compatible - test for compatibility
+ * ttm_resource_compatible - check if resource is compatible with placement
*
- * @bdev: TTM device structure
- * @res: The resource to test
- * @place: The placement to test
- * @size: How many bytes the new allocation needs.
- *
- * Test if @res compatible with @place and @size.
+ * @res: the resource to check
+ * @placement: the placement to check against
*
- * Returns true if the res placement compatible with @place and @size.
+ * Returns true if the placement is compatible.
*/
-bool ttm_resource_compatible(struct ttm_device *bdev,
- struct ttm_resource *res,
- const struct ttm_place *place,
- size_t size)
-{
- struct ttm_resource_manager *man;
-
- if (!res || !place)
- return false;
-
- man = ttm_manager_type(bdev, res->mem_type);
- if (!man->func->compatible)
- return true;
-
- return man->func->compatible(man, res, place, size);
-}
-
-static bool ttm_resource_places_compat(struct ttm_resource *res,
- const struct ttm_place *places,
- unsigned num_placement)
+bool ttm_resource_compatible(struct ttm_resource *res,
+ struct ttm_placement *placement)
{
struct ttm_buffer_object *bo = res->bo;
struct ttm_device *bdev = bo->bdev;
@@ -330,44 +308,25 @@ static bool ttm_resource_places_compat(struct ttm_resource *res,
if (res->placement & TTM_PL_FLAG_TEMPORARY)
return false;
- for (i = 0; i < num_placement; i++) {
- const struct ttm_place *heap = &places[i];
+ for (i = 0; i < placement->num_placement; i++) {
+ const struct ttm_place *place = &placement->placement[i];
+ struct ttm_resource_manager *man;
- if (!ttm_resource_compatible(bdev, res, heap, bo->base.size))
+ if (res->mem_type != place->mem_type)
+ continue;
+
+ man = ttm_manager_type(bdev, res->mem_type);
+ if (man->func->compatible &&
+ !man->func->compatible(man, res, place, bo->base.size))
continue;
- if ((res->mem_type == heap->mem_type) &&
- (!(heap->flags & TTM_PL_FLAG_CONTIGUOUS) ||
+ if ((!(place->flags & TTM_PL_FLAG_CONTIGUOUS) ||
(res->placement & TTM_PL_FLAG_CONTIGUOUS)))
return true;
}
return false;
}
-/**
- * ttm_resource_compat - check if resource is compatible with placement
- *
- * @res: the resource to check
- * @placement: the placement to check against
- *
- * Returns true if the placement is compatible.
- */
-bool ttm_resource_compat(struct ttm_resource *res,
- struct ttm_placement *placement)
-{
- if (ttm_resource_places_compat(res, placement->placement,
- placement->num_placement))
- return true;
-
- if ((placement->busy_placement != placement->placement ||
- placement->num_busy_placement > placement->num_placement) &&
- ttm_resource_places_compat(res, placement->busy_placement,
- placement->num_busy_placement))
- return true;
-
- return false;
-}
-
void ttm_resource_set_bo(struct ttm_resource *res,
struct ttm_buffer_object *bo)
{
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
index 2bfac3aad7b7..7d7b33fcb5cf 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
@@ -821,8 +821,6 @@ void vmw_bo_placement_set(struct vmw_bo *bo, u32 domain, u32 busy_domain)
__func__, bo->tbo.resource->mem_type, domain);
}
- pl->busy_placement = bo->busy_places;
- pl->num_busy_placement = set_placement_list(bo->busy_places, busy_domain);
}
void vmw_bo_placement_set_default_accelerated(struct vmw_bo *bo)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
index af8562c95cc3..e243c9266453 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
@@ -36,6 +36,49 @@ static const struct ttm_place vram_placement_flags = {
.flags = 0
};
+struct ttm_placement vmw_vram_placement = {
+ .num_placement = 1,
+ .placement = &vram_placement_flags,
+};
+
+static const struct ttm_place vram_gmr_placement_flags[] = {
+ {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = TTM_PL_VRAM,
+ .flags = TTM_PL_FLAG_IDLE
+ }, {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = VMW_PL_GMR,
+ .flags = 0
+ }
+};
+
+struct ttm_placement vmw_vram_gmr_placement = {
+ .num_placement = 2,
+ .placement = vram_gmr_placement_flags,
+};
+
+static const struct ttm_place vram_sys_placement_flags[] = {
+ {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = TTM_PL_VRAM,
+ .flags = TTM_PL_FLAG_IDLE
+ }, {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = TTM_PL_SYSTEM,
+ .flags = TTM_PL_FLAG_BUSY
+ }
+};
+
+struct ttm_placement vmw_vram_sys_placement = {
+ .num_placement = 2,
+ .placement = vram_sys_placement_flags,
+};
+
static const struct ttm_place sys_placement_flags = {
.fpfn = 0,
.lpfn = 0,
@@ -43,46 +86,64 @@ static const struct ttm_place sys_placement_flags = {
.flags = 0
};
-static const struct ttm_place gmr_placement_flags = {
+struct ttm_placement vmw_sys_placement = {
+ .num_placement = 1,
+ .placement = &sys_placement_flags,
+};
+
+static const struct ttm_place vmw_sys_placement_flags = {
.fpfn = 0,
.lpfn = 0,
- .mem_type = VMW_PL_GMR,
+ .mem_type = VMW_PL_SYSTEM,
.flags = 0
};
-struct ttm_placement vmw_vram_placement = {
+struct ttm_placement vmw_pt_sys_placement = {
.num_placement = 1,
- .placement = &vram_placement_flags,
- .num_busy_placement = 1,
- .busy_placement = &vram_placement_flags
+ .placement = &vmw_sys_placement_flags,
};
-static const struct ttm_place vram_gmr_placement_flags[] = {
+static const struct ttm_place gmr_vram_placement_flags[] = {
{
.fpfn = 0,
.lpfn = 0,
- .mem_type = TTM_PL_VRAM,
+ .mem_type = VMW_PL_GMR,
.flags = 0
}, {
.fpfn = 0,
.lpfn = 0,
- .mem_type = VMW_PL_GMR,
- .flags = 0
+ .mem_type = TTM_PL_VRAM,
+ .flags = TTM_PL_FLAG_BUSY
}
};
-struct ttm_placement vmw_vram_gmr_placement = {
+struct ttm_placement vmw_srf_placement = {
.num_placement = 2,
- .placement = vram_gmr_placement_flags,
- .num_busy_placement = 1,
- .busy_placement = &gmr_placement_flags
+ .placement = gmr_vram_placement_flags
};
-struct ttm_placement vmw_sys_placement = {
- .num_placement = 1,
- .placement = &sys_placement_flags,
- .num_busy_placement = 1,
- .busy_placement = &sys_placement_flags
+static const struct ttm_place nonfixed_placement_flags[] = {
+ {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = TTM_PL_SYSTEM,
+ .flags = 0
+ }, {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = VMW_PL_GMR,
+ .flags = TTM_PL_FLAG_IDLE
+ }, {
+ .fpfn = 0,
+ .lpfn = 0,
+ .mem_type = VMW_PL_MOB,
+ .flags = TTM_PL_FLAG_IDLE
+ }
+};
+
+struct ttm_placement vmw_nonfixed_placement = {
+ .num_placement = 3,
+ .placement = nonfixed_placement_flags,
};
const size_t vmw_tt_size = sizeof(struct vmw_ttm_tt);
diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm/ttm_placement.h
index 8074d0f6cae5..c70e489e1f1e 100644
--- a/include/drm/ttm/ttm_placement.h
+++ b/include/drm/ttm/ttm_placement.h
@@ -64,6 +64,12 @@
/* For multihop handling */
#define TTM_PL_FLAG_TEMPORARY (1 << 2)
+/* Placement is never used during eviction */
+#define TTM_PL_FLAG_IDLE (1 << 3)
+
+/* Placement is only used during eviction */
+#define TTM_PL_FLAG_BUSY (1 << 4)
+
/**
* struct ttm_place
*
@@ -86,16 +92,12 @@ struct ttm_place {
*
* @num_placement: number of preferred placements
* @placement: preferred placements
- * @num_busy_placement: number of preferred placements when need to evict buffer
- * @busy_placement: preferred placements when need to evict buffer
*
* Structure indicating the placement you request for an object.
*/
struct ttm_placement {
unsigned num_placement;
const struct ttm_place *placement;
- unsigned num_busy_placement;
- const struct ttm_place *busy_placement;
};
#endif
diff --git a/include/drm/ttm/ttm_resource.h b/include/drm/ttm/ttm_resource.h
index 78a226eba953..1afa13f0c22b 100644
--- a/include/drm/ttm/ttm_resource.h
+++ b/include/drm/ttm/ttm_resource.h
@@ -365,12 +365,8 @@ bool ttm_resource_intersects(struct ttm_device *bdev,
struct ttm_resource *res,
const struct ttm_place *place,
size_t size);
-bool ttm_resource_compatible(struct ttm_device *bdev,
- struct ttm_resource *res,
- const struct ttm_place *place,
- size_t size);
-bool ttm_resource_compat(struct ttm_resource *res,
- struct ttm_placement *placement);
+bool ttm_resource_compatible(struct ttm_resource *res,
+ struct ttm_placement *placement);
void ttm_resource_set_bo(struct ttm_resource *res,
struct ttm_buffer_object *bo);
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/4] drm/ttm: improve idle/busy handling v2
2024-01-04 15:05 Rework TTMs busy handling Christian König
2024-01-04 15:05 ` [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
2024-01-04 15:05 ` [PATCH 2/4] drm/ttm: replace busy placement with flags v4 Christian König
@ 2024-01-04 15:05 ` Christian König
2024-01-04 15:05 ` [PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT Christian König
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Christian König @ 2024-01-04 15:05 UTC (permalink / raw)
To: dri-devel, intel-gfx, thomas.hellstrom, nouveau, jani.nikula,
kherbst, lyude, zackr
Previously we would never try to move a BO into the preferred placements
when it ever landed in a busy placement since those were considered
compatible.
Rework the whole handling and finally unify the idle and busy handling.
ttm_bo_validate() is now responsible to try idle placement first and then
use the busy placement if that didn't worked.
Drawback is that we now always try the idle placement first for each
validation which might cause some additional CPU overhead on overcommit.
v2: fix kerneldoc warning and coding style
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
drivers/gpu/drm/ttm/ttm_bo.c | 131 ++++++++-------------
drivers/gpu/drm/ttm/ttm_resource.c | 15 ++-
include/drm/ttm/ttm_bo.h | 3 +-
include/drm/ttm/ttm_resource.h | 3 +-
6 files changed, 65 insertions(+), 91 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index aa0dd6dad068..f110dfdc4feb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -404,7 +404,7 @@ int amdgpu_bo_create_kernel_at(struct amdgpu_device *adev,
(*bo_ptr)->placements[i].lpfn = (offset + size) >> PAGE_SHIFT;
}
r = ttm_bo_mem_space(&(*bo_ptr)->tbo, &(*bo_ptr)->placement,
- &(*bo_ptr)->tbo.resource, &ctx);
+ &(*bo_ptr)->tbo.resource, &ctx, false);
if (r)
goto error;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 9a6a00b1af40..00da9a81cf6c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -967,7 +967,7 @@ int amdgpu_ttm_alloc_gart(struct ttm_buffer_object *bo)
placements.mem_type = TTM_PL_TT;
placements.flags = bo->resource->placement;
- r = ttm_bo_mem_space(bo, &placement, &tmp, &ctx);
+ r = ttm_bo_mem_space(bo, &placement, &tmp, &ctx, true);
if (unlikely(r))
return r;
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index aa12bd5cfd17..17bfc252f76d 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -414,7 +414,7 @@ static int ttm_bo_bounce_temp_buffer(struct ttm_buffer_object *bo,
hop_placement.placement = hop;
/* find space in the bounce domain */
- ret = ttm_bo_mem_space(bo, &hop_placement, &hop_mem, ctx);
+ ret = ttm_bo_mem_space(bo, &hop_placement, &hop_mem, ctx, true);
if (ret)
return ret;
/* move to the bounce domain */
@@ -454,7 +454,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
return ttm_bo_pipeline_gutting(bo);
}
- ret = ttm_bo_mem_space(bo, &placement, &evict_mem, ctx);
+ ret = ttm_bo_mem_space(bo, &placement, &evict_mem, ctx, true);
if (ret) {
if (ret != -ERESTARTSYS) {
pr_err("Failed to find memory space for buffer 0x%p eviction\n",
@@ -724,37 +724,6 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,
return ret;
}
-/*
- * Repeatedly evict memory from the LRU for @mem_type until we create enough
- * space, or we've evicted everything and there isn't enough space.
- */
-static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
- const struct ttm_place *place,
- struct ttm_resource **mem,
- struct ttm_operation_ctx *ctx)
-{
- struct ttm_device *bdev = bo->bdev;
- struct ttm_resource_manager *man;
- struct ww_acquire_ctx *ticket;
- int ret;
-
- man = ttm_manager_type(bdev, place->mem_type);
- ticket = dma_resv_locking_ctx(bo->base.resv);
- do {
- ret = ttm_resource_alloc(bo, place, mem);
- if (likely(!ret))
- break;
- if (unlikely(ret != -ENOSPC))
- return ret;
- ret = ttm_mem_evict_first(bdev, man, place, ctx,
- ticket);
- if (unlikely(ret != 0))
- return ret;
- } while (1);
-
- return ttm_bo_add_move_fence(bo, man, *mem, ctx->no_wait_gpu);
-}
-
/**
* ttm_bo_mem_space
*
@@ -763,6 +732,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
* @placement: Proposed new placement for the buffer object.
* @mem: A struct ttm_resource.
* @ctx: if and how to sleep, lock buffers and alloc memory
+ * @force_space: If we should evict buffers to force space
*
* Allocate memory space for the buffer object pointed to by @bo, using
* the placement flags in @placement, potentially evicting other idle buffer objects.
@@ -776,12 +746,14 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
int ttm_bo_mem_space(struct ttm_buffer_object *bo,
struct ttm_placement *placement,
struct ttm_resource **mem,
- struct ttm_operation_ctx *ctx)
+ struct ttm_operation_ctx *ctx,
+ bool force_space)
{
struct ttm_device *bdev = bo->bdev;
- bool type_found = false;
+ struct ww_acquire_ctx *ticket;
int i, ret;
+ ticket = dma_resv_locking_ctx(bo->base.resv);
ret = dma_resv_reserve_fences(bo->base.resv, 1);
if (unlikely(ret))
return ret;
@@ -790,19 +762,30 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
const struct ttm_place *place = &placement->placement[i];
struct ttm_resource_manager *man;
- if (place->flags & TTM_PL_FLAG_BUSY)
- continue;
-
man = ttm_manager_type(bdev, place->mem_type);
if (!man || !ttm_resource_manager_used(man))
continue;
- type_found = true;
- ret = ttm_resource_alloc(bo, place, mem);
- if (ret == -ENOSPC)
+ if (place->flags & (force_space ? TTM_PL_FLAG_IDLE :
+ TTM_PL_FLAG_BUSY))
+ continue;
+
+ do {
+ ret = ttm_resource_alloc(bo, place, mem);
+ if (unlikely(ret != -ENOSPC))
+ return ret;
+ if (likely(!ret) || !force_space)
+ break;
+
+ ret = ttm_mem_evict_first(bdev, man, place, ctx,
+ ticket);
+ if (unlikely(ret == -EBUSY))
+ break;
+ if (unlikely(ret))
+ return ret;
+ } while (1);
+ if (ret)
continue;
- if (unlikely(ret))
- goto error;
ret = ttm_bo_add_move_fence(bo, man, *mem, ctx->no_wait_gpu);
if (unlikely(ret)) {
@@ -810,45 +793,19 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
if (ret == -EBUSY)
continue;
- goto error;
+ return ret;
}
return 0;
}
- for (i = 0; i < placement->num_placement; ++i) {
- const struct ttm_place *place = &placement->placement[i];
- struct ttm_resource_manager *man;
-
- if (place->flags & TTM_PL_FLAG_IDLE)
- continue;
-
- man = ttm_manager_type(bdev, place->mem_type);
- if (!man || !ttm_resource_manager_used(man))
- continue;
-
- type_found = true;
- ret = ttm_bo_mem_force_space(bo, place, mem, ctx);
- if (likely(!ret))
- return 0;
-
- if (ret && ret != -EBUSY)
- goto error;
- }
-
- ret = -ENOSPC;
- if (!type_found) {
- pr_err(TTM_PFX "No compatible memory type found\n");
- ret = -EINVAL;
- }
-
-error:
- return ret;
+ return -ENOSPC;
}
EXPORT_SYMBOL(ttm_bo_mem_space);
static int ttm_bo_move_buffer(struct ttm_buffer_object *bo,
struct ttm_placement *placement,
- struct ttm_operation_ctx *ctx)
+ struct ttm_operation_ctx *ctx,
+ bool force_space)
{
struct ttm_resource *mem;
struct ttm_place hop;
@@ -865,7 +822,7 @@ static int ttm_bo_move_buffer(struct ttm_buffer_object *bo,
* stop and the driver will be called to make
* the second hop.
*/
- ret = ttm_bo_mem_space(bo, placement, &mem, ctx);
+ ret = ttm_bo_mem_space(bo, placement, &mem, ctx, force_space);
if (ret)
return ret;
bounce:
@@ -902,6 +859,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
struct ttm_placement *placement,
struct ttm_operation_ctx *ctx)
{
+ bool force_space;
int ret;
dma_resv_assert_held(bo->base.resv);
@@ -912,20 +870,27 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
if (!placement->num_placement)
return ttm_bo_pipeline_gutting(bo);
- /* Check whether we need to move buffer. */
- if (bo->resource && ttm_resource_compatible(bo->resource, placement))
- return 0;
+ force_space = false;
+ do {
+ /* Check whether we need to move buffer. */
+ if (bo->resource &&
+ ttm_resource_compatible(bo->resource, placement,
+ force_space))
+ return 0;
+
+ /* Moving of pinned BOs is forbidden */
+ if (bo->pin_count)
+ return -EINVAL;
- /* Moving of pinned BOs is forbidden */
- if (bo->pin_count)
- return -EINVAL;
+ ret = ttm_bo_move_buffer(bo, placement, ctx, force_space);
+ if (ret && ret != -ENOSPC)
+ return ret;
- ret = ttm_bo_move_buffer(bo, placement, ctx);
+ force_space = !force_space;
+ } while (force_space);
/* For backward compatibility with userspace */
if (ret == -ENOSPC)
return -ENOMEM;
- if (ret)
- return ret;
/*
* We might need to add a TTM.
diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
index fb14f7716cf8..67052891314c 100644
--- a/drivers/gpu/drm/ttm/ttm_resource.c
+++ b/drivers/gpu/drm/ttm/ttm_resource.c
@@ -295,11 +295,13 @@ bool ttm_resource_intersects(struct ttm_device *bdev,
*
* @res: the resource to check
* @placement: the placement to check against
+ * @busy: controls which places to check
*
* Returns true if the placement is compatible.
*/
bool ttm_resource_compatible(struct ttm_resource *res,
- struct ttm_placement *placement)
+ struct ttm_placement *placement,
+ bool busy)
{
struct ttm_buffer_object *bo = res->bo;
struct ttm_device *bdev = bo->bdev;
@@ -315,14 +317,19 @@ bool ttm_resource_compatible(struct ttm_resource *res,
if (res->mem_type != place->mem_type)
continue;
+ if (place->flags & (busy ? TTM_PL_FLAG_IDLE : TTM_PL_FLAG_BUSY))
+ continue;
+
+ if (place->flags & TTM_PL_FLAG_CONTIGUOUS &&
+ !(res->placement & TTM_PL_FLAG_CONTIGUOUS))
+ continue;
+
man = ttm_manager_type(bdev, res->mem_type);
if (man->func->compatible &&
!man->func->compatible(man, res, place, bo->base.size))
continue;
- if ((!(place->flags & TTM_PL_FLAG_CONTIGUOUS) ||
- (res->placement & TTM_PL_FLAG_CONTIGUOUS)))
- return true;
+ return true;
}
return false;
}
diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
index 0223a41a64b2..64d738f152d1 100644
--- a/include/drm/ttm/ttm_bo.h
+++ b/include/drm/ttm/ttm_bo.h
@@ -397,7 +397,8 @@ vm_fault_t ttm_bo_vm_dummy_page(struct vm_fault *vmf, pgprot_t prot);
int ttm_bo_mem_space(struct ttm_buffer_object *bo,
struct ttm_placement *placement,
struct ttm_resource **mem,
- struct ttm_operation_ctx *ctx);
+ struct ttm_operation_ctx *ctx,
+ bool force_space);
void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo);
/*
diff --git a/include/drm/ttm/ttm_resource.h b/include/drm/ttm/ttm_resource.h
index 1afa13f0c22b..514858c49848 100644
--- a/include/drm/ttm/ttm_resource.h
+++ b/include/drm/ttm/ttm_resource.h
@@ -366,7 +366,8 @@ bool ttm_resource_intersects(struct ttm_device *bdev,
const struct ttm_place *place,
size_t size);
bool ttm_resource_compatible(struct ttm_resource *res,
- struct ttm_placement *placement);
+ struct ttm_placement *placement,
+ bool busy);
void ttm_resource_set_bo(struct ttm_resource *res,
struct ttm_buffer_object *bo);
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT
2024-01-04 15:05 Rework TTMs busy handling Christian König
` (2 preceding siblings ...)
2024-01-04 15:05 ` [PATCH 3/4] drm/ttm: improve idle/busy handling v2 Christian König
@ 2024-01-04 15:05 ` Christian König
2024-01-04 15:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Christian König @ 2024-01-04 15:05 UTC (permalink / raw)
To: dri-devel, intel-gfx, thomas.hellstrom, nouveau, jani.nikula,
kherbst, lyude, zackr
Try to fill up VRAM as well by setting the busy flag on GTT allocations.
This fixes the issue that when VRAM was evacuated for suspend it's never
filled up again unless the application is restarted.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index f110dfdc4feb..979cecf18f17 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -173,6 +173,12 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
abo->flags & AMDGPU_GEM_CREATE_PREEMPTIBLE ?
AMDGPU_PL_PREEMPT : TTM_PL_TT;
places[c].flags = 0;
+ /*
+ * When GTT is just an alternative to VRAM make sure that we
+ * only use it as fallback and still try to fill up VRAM first.
+ */
+ if (domain & abo->preferred_domains & AMDGPU_GEM_DOMAIN_VRAM)
+ places[c].flags |= TTM_PL_FLAG_BUSY;
c++;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
2024-01-04 15:05 Rework TTMs busy handling Christian König
` (3 preceding siblings ...)
2024-01-04 15:05 ` [PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT Christian König
@ 2024-01-04 15:39 ` Patchwork
2024-01-04 15:39 ` ✗ Fi.CI.SPARSE: " Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-01-04 15:39 UTC (permalink / raw)
To: Christian König; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
URL : https://patchwork.freedesktop.org/series/128207/
State : warning
== Summary ==
Error: dim checkpatch failed
dcccad5f8257 drm/ttm: return ENOSPC from ttm_bo_mem_space
-:35: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <ckoenig.leichtzumerken@gmail.com>' != 'Signed-off-by: Christian König <christian.koenig@amd.com>'
total: 0 errors, 1 warnings, 0 checks, 17 lines checked
ac91c231c08a drm/ttm: replace busy placement with flags v4
c48eb531579e drm/ttm: improve idle/busy handling v2
-:347: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <ckoenig.leichtzumerken@gmail.com>' != 'Signed-off-by: Christian König <christian.koenig@amd.com>'
total: 0 errors, 1 warnings, 0 checks, 284 lines checked
107fe4c67a08 drm/amdgpu: use GTT only as fallback for VRAM|GTT
-:32: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Christian König" <ckoenig.leichtzumerken@gmail.com>' != 'Signed-off-by: Christian König <christian.koenig@amd.com>'
total: 0 errors, 1 warnings, 0 checks, 12 lines checked
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
2024-01-04 15:05 Rework TTMs busy handling Christian König
` (4 preceding siblings ...)
2024-01-04 15:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Patchwork
@ 2024-01-04 15:39 ` Patchwork
2024-01-04 15:55 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-04 17:04 ` ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-01-04 15:39 UTC (permalink / raw)
To: Christian König; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
URL : https://patchwork.freedesktop.org/series/128207/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
2024-01-04 15:05 Rework TTMs busy handling Christian König
` (5 preceding siblings ...)
2024-01-04 15:39 ` ✗ Fi.CI.SPARSE: " Patchwork
@ 2024-01-04 15:55 ` Patchwork
2024-01-04 17:04 ` ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-01-04 15:55 UTC (permalink / raw)
To: Christian König; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4985 bytes --]
== Series Details ==
Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
URL : https://patchwork.freedesktop.org/series/128207/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14078 -> Patchwork_128207v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/index.html
Participating hosts (38 -> 37)
------------------------------
Additional (2): bat-rpls-2 fi-pnv-d510
Missing (3): bat-mtlp-8 bat-kbl-2 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_128207v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@gem_lmem_swapping@basic:
- fi-pnv-d510: NOTRUN -> [SKIP][2] ([fdo#109271]) +28 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/fi-pnv-d510/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlm-1: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-adlm-1/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@workarounds:
- bat-adlm-1: NOTRUN -> [INCOMPLETE][5] ([i915#9413])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-adlm-1/igt@i915_selftest@live@workarounds.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-rpls-2: NOTRUN -> [SKIP][6] ([i915#4103]) +1 other test skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#3555] / [i915#3840] / [i915#9886])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][8] ([fdo#109285])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][9] ([i915#5354])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_pm_rpm@basic-rte:
- bat-rpls-2: NOTRUN -> [ABORT][10] ([i915#8668] / [i915#9368] / [i915#9897])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/bat-rpls-2/igt@kms_pm_rpm@basic-rte.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9368]: https://gitlab.freedesktop.org/drm/intel/issues/9368
[i915#9413]: https://gitlab.freedesktop.org/drm/intel/issues/9413
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886
[i915#9897]: https://gitlab.freedesktop.org/drm/intel/issues/9897
Build changes
-------------
* Linux: CI_DRM_14078 -> Patchwork_128207v1
CI-20190529: 20190529
CI_DRM_14078: 1baf990bc673f31d9eba7dfcb597ac0cb7420b14 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7655: ddf7cf40a00caa7d02f3729e1e50f78f102463d9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_128207v1: 1baf990bc673f31d9eba7dfcb597ac0cb7420b14 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
1006f1804b9a drm/amdgpu: use GTT only as fallback for VRAM|GTT
6e81b857f5ae drm/ttm: improve idle/busy handling v2
6e69b7b92bbb drm/ttm: replace busy placement with flags v4
1d9e06ad89ab drm/ttm: return ENOSPC from ttm_bo_mem_space
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/index.html
[-- Attachment #2: Type: text/html, Size: 5858 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
2024-01-04 15:05 Rework TTMs busy handling Christian König
` (6 preceding siblings ...)
2024-01-04 15:55 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2024-01-04 17:04 ` Patchwork
7 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-01-04 17:04 UTC (permalink / raw)
To: Christian König; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 87237 bytes --]
== Series Details ==
Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space
URL : https://patchwork.freedesktop.org/series/128207/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14078_full -> Patchwork_128207v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_128207v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_128207v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/index.html
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_128207v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_create@create-ext-cpu-access-big:
- shard-dg2: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg2-3/igt@gem_create@create-ext-cpu-access-big.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-2/igt@gem_create@create-ext-cpu-access-big.html
* igt@gem_lmem_swapping@heavy-verify-random-ccs@lmem0:
- shard-dg2: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_lmem_swapping@heavy-verify-random-ccs@lmem0.html
* igt@i915_selftest@live@gt_pm:
- shard-rkl: [PASS][4] -> [DMESG-FAIL][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/igt@i915_selftest@live@gt_pm.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/igt@i915_selftest@live@gt_pm.html
Known issues
------------
Here are the changes found in Patchwork_128207v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-rkl: ([PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [FAIL][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53]) ([i915#8293])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-4/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@blit-reloc-keep-cache:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#8411])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@api_intel_bb@blit-reloc-keep-cache.html
* igt@api_intel_bb@blit-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#8411])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@api_intel_bb@blit-reloc-purge-cache.html
* igt@drm_fdinfo@busy-idle-check-all@ccs3:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#8414]) +30 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@drm_fdinfo@busy-idle-check-all@ccs3.html
* igt@drm_fdinfo@virtual-busy-all:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#8414])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@drm_fdinfo@virtual-busy-all.html
* igt@drm_fdinfo@virtual-busy-idle-all:
- shard-dg1: NOTRUN -> [SKIP][58] ([i915#8414])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@drm_fdinfo@virtual-busy-idle-all.html
* igt@gem_ccs@ctrl-surf-copy:
- shard-mtlp: NOTRUN -> [SKIP][59] ([i915#3555])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_ccs@ctrl-surf-copy.html
* igt@gem_ccs@suspend-resume:
- shard-dg1: NOTRUN -> [SKIP][60] ([i915#9323])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_ccs@suspend-resume.html
* igt@gem_close_race@multigpu-basic-threads:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#7697])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_close_race@multigpu-basic-threads.html
* igt@gem_ctx_persistence@heartbeat-close:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#8555])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_ctx_persistence@heartbeat-close.html
* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#8555])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@gem_ctx_persistence@heartbeat-hostile.html
* igt@gem_exec_balancer@bonded-pair:
- shard-dg2: NOTRUN -> [SKIP][64] ([i915#4771])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_exec_balancer@bonded-pair.html
* igt@gem_exec_balancer@bonded-sync:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#4771])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_exec_balancer@bonded-sync.html
* igt@gem_exec_balancer@invalid-bonds:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#4036])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@gem_exec_balancer@invalid-bonds.html
* igt@gem_exec_capture@capture-invisible@lmem0:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#6334]) +1 other test skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@gem_exec_capture@capture-invisible@lmem0.html
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-tglu: NOTRUN -> [SKIP][68] ([i915#6334])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@gem_exec_capture@capture-invisible@smem0.html
* igt@gem_exec_fair@basic-none-vip:
- shard-dg2: NOTRUN -> [SKIP][69] ([i915#3539] / [i915#4852]) +1 other test skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@gem_exec_fair@basic-none-vip.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: NOTRUN -> [FAIL][70] ([i915#2842]) +3 other tests fail
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk4/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [PASS][71] -> [FAIL][72] ([i915#2842])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/igt@gem_exec_fair@basic-pace@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
- shard-tglu: [PASS][73] -> [FAIL][74] ([i915#2842])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-tglu-4/igt@gem_exec_fair@basic-pace@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fence@submit3:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#4812]) +1 other test skip
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@gem_exec_fence@submit3.html
* igt@gem_exec_flush@basic-uc-set-default:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#3539])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@gem_exec_flush@basic-uc-set-default.html
* igt@gem_exec_flush@basic-wb-rw-before-default:
- shard-dg1: NOTRUN -> [SKIP][77] ([i915#3539] / [i915#4852])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_exec_flush@basic-wb-rw-before-default.html
* igt@gem_exec_reloc@basic-cpu-gtt:
- shard-dg1: NOTRUN -> [SKIP][78] ([i915#3281]) +2 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_exec_reloc@basic-cpu-gtt.html
* igt@gem_exec_reloc@basic-cpu-gtt-noreloc:
- shard-dg2: NOTRUN -> [SKIP][79] ([i915#3281]) +13 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html
* igt@gem_exec_reloc@basic-cpu-noreloc:
- shard-rkl: NOTRUN -> [SKIP][80] ([i915#3281]) +3 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-noreloc.html
* igt@gem_exec_reloc@basic-cpu-wc:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#3281]) +1 other test skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_exec_reloc@basic-cpu-wc.html
* igt@gem_exec_schedule@preempt-queue:
- shard-dg1: NOTRUN -> [SKIP][82] ([i915#4812]) +1 other test skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_exec_schedule@preempt-queue.html
* igt@gem_exec_schedule@preempt-queue-contexts:
- shard-mtlp: NOTRUN -> [SKIP][83] ([i915#4537] / [i915#4812])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_exec_schedule@preempt-queue-contexts.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- shard-dg2: NOTRUN -> [ABORT][84] ([i915#7975] / [i915#8213])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][85] ([i915#7975] / [i915#8213])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_fence_thrash@bo-write-verify-y:
- shard-dg2: NOTRUN -> [SKIP][86] ([i915#4860]) +2 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@gem_fence_thrash@bo-write-verify-y.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-glk: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#4613]) +5 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk4/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#4613]) +1 other test skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-mtlp: NOTRUN -> [SKIP][89] ([i915#4613])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_lmem_swapping@parallel-random-verify-ccs.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: NOTRUN -> [TIMEOUT][90] ([i915#5493])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_lmem_swapping@verify:
- shard-tglu: NOTRUN -> [SKIP][91] ([i915#4613]) +1 other test skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@gem_lmem_swapping@verify.html
* igt@gem_mmap_gtt@isolation:
- shard-mtlp: NOTRUN -> [SKIP][92] ([i915#4077]) +1 other test skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_mmap_gtt@isolation.html
* igt@gem_mmap_wc@bad-size:
- shard-mtlp: NOTRUN -> [SKIP][93] ([i915#4083])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_mmap_wc@bad-size.html
* igt@gem_mmap_wc@invalid-flags:
- shard-dg1: NOTRUN -> [SKIP][94] ([i915#4083])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_mmap_wc@invalid-flags.html
* igt@gem_mmap_wc@write-wc-read-gtt:
- shard-dg2: NOTRUN -> [SKIP][95] ([i915#4083]) +6 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@gem_mmap_wc@write-wc-read-gtt.html
* igt@gem_partial_pwrite_pread@reads:
- shard-dg2: NOTRUN -> [SKIP][96] ([i915#3282]) +4 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_partial_pwrite_pread@reads.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-rkl: NOTRUN -> [SKIP][97] ([i915#3282]) +3 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_pxp@create-regular-context-1:
- shard-dg1: NOTRUN -> [SKIP][98] ([i915#4270])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_pxp@create-regular-context-1.html
* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-mtlp: NOTRUN -> [SKIP][99] ([i915#4270])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_pxp@protected-raw-src-copy-not-readible.html
* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#4270]) +5 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_pxp@regular-baseline-src-copy-readible.html
* igt@gem_pxp@verify-pxp-key-change-after-suspend-resume:
- shard-tglu: NOTRUN -> [SKIP][101] ([i915#4270])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@gem_pxp@verify-pxp-key-change-after-suspend-resume.html
- shard-rkl: NOTRUN -> [SKIP][102] ([i915#4270])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@gem_pxp@verify-pxp-key-change-after-suspend-resume.html
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][103] ([i915#5190]) +15 other tests skip
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled.html
* igt@gem_set_tiling_vs_blt@untiled-to-tiled:
- shard-dg2: NOTRUN -> [SKIP][104] ([i915#4079]) +2 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@gem_set_tiling_vs_blt@untiled-to-tiled.html
* igt@gem_tiled_partial_pwrite_pread@writes:
- shard-dg2: NOTRUN -> [SKIP][105] ([i915#4077]) +16 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_tiled_partial_pwrite_pread@writes.html
* igt@gem_tiled_pread_basic:
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#4079])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_tiled_pread_basic.html
* igt@gem_unfence_active_buffers:
- shard-dg1: NOTRUN -> [SKIP][107] ([i915#4879])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gem_unfence_active_buffers.html
* igt@gem_userptr_blits@access-control:
- shard-mtlp: NOTRUN -> [SKIP][108] ([i915#3297]) +1 other test skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gem_userptr_blits@access-control.html
* igt@gem_userptr_blits@coherency-sync:
- shard-rkl: NOTRUN -> [SKIP][109] ([fdo#110542])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-dg2: NOTRUN -> [SKIP][110] ([i915#3297]) +6 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@gem_userptr_blits@dmabuf-unsync.html
- shard-rkl: NOTRUN -> [SKIP][111] ([i915#3297]) +1 other test skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@invalid-mmap-offset-unsync:
- shard-tglu: NOTRUN -> [SKIP][112] ([i915#3297]) +1 other test skip
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@gem_userptr_blits@invalid-mmap-offset-unsync.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-dg2: NOTRUN -> [SKIP][113] ([i915#3297] / [i915#4880])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@gen7_exec_parse@bitmasks:
- shard-dg2: NOTRUN -> [SKIP][114] ([fdo#109289]) +5 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@gen7_exec_parse@bitmasks.html
* igt@gen7_exec_parse@load-register-reg:
- shard-tglu: NOTRUN -> [SKIP][115] ([fdo#109289])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@gen7_exec_parse@load-register-reg.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-dg1: NOTRUN -> [SKIP][116] ([i915#2527])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-rkl: NOTRUN -> [SKIP][117] ([i915#2527]) +1 other test skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html
- shard-tglu: NOTRUN -> [SKIP][118] ([i915#2527] / [i915#2856])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-oversize:
- shard-mtlp: NOTRUN -> [SKIP][119] ([i915#2856])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@gen9_exec_parse@bb-oversize.html
* igt@gen9_exec_parse@secure-batches:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#2856]) +2 other tests skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@gen9_exec_parse@secure-batches.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: NOTRUN -> [DMESG-WARN][121] ([i915#9559])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_module_load@resize-bar:
- shard-rkl: NOTRUN -> [SKIP][122] ([i915#6412])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@i915_module_load@resize-bar.html
- shard-tglu: NOTRUN -> [SKIP][123] ([i915#6412])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@i915_module_load@resize-bar.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-dg2: NOTRUN -> [SKIP][124] ([i915#6621])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@i915_pm_rps@min-max-config-loaded.html
* igt@i915_pm_rps@thresholds-park@gt0:
- shard-mtlp: NOTRUN -> [SKIP][125] ([i915#8925])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@i915_pm_rps@thresholds-park@gt0.html
* igt@i915_pm_rps@thresholds-park@gt1:
- shard-mtlp: NOTRUN -> [SKIP][126] ([i915#3555] / [i915#8925])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@i915_pm_rps@thresholds-park@gt1.html
* igt@i915_pm_rps@thresholds@gt0:
- shard-dg2: NOTRUN -> [SKIP][127] ([i915#8925])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@i915_pm_rps@thresholds@gt0.html
* igt@i915_power@sanity:
- shard-mtlp: [PASS][128] -> [SKIP][129] ([i915#7984])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-mtlp-5/igt@i915_power@sanity.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-8/igt@i915_power@sanity.html
* igt@i915_query@query-topology-unsupported:
- shard-dg2: NOTRUN -> [SKIP][130] ([fdo#109302])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@i915_query@query-topology-unsupported.html
* igt@i915_query@test-query-geometry-subslices:
- shard-rkl: NOTRUN -> [SKIP][131] ([i915#5723])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@i915_query@test-query-geometry-subslices.html
- shard-tglu: NOTRUN -> [SKIP][132] ([i915#5723])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@i915_query@test-query-geometry-subslices.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- shard-dg2: NOTRUN -> [SKIP][133] ([i915#4215] / [i915#5190])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-3-4-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][134] ([i915#8709]) +11 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-3-4-mc-ccs.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#9531])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
- shard-tglu: NOTRUN -> [SKIP][136] ([i915#9531])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][137] ([i915#1769] / [i915#3555])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-180:
- shard-rkl: NOTRUN -> [SKIP][138] ([i915#5286]) +1 other test skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_big_fb@4-tiled-16bpp-rotate-180.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-270:
- shard-tglu: NOTRUN -> [SKIP][139] ([fdo#111615] / [i915#5286])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_big_fb@4-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-dg1: NOTRUN -> [SKIP][140] ([i915#4538] / [i915#5286])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][141] ([fdo#111614] / [i915#3638]) +1 other test skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_big_fb@linear-64bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-tglu: NOTRUN -> [SKIP][142] ([fdo#111614])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-dg2: NOTRUN -> [SKIP][143] ([fdo#111614]) +2 other tests skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_big_fb@x-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][144] ([i915#3638])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-mtlp: NOTRUN -> [SKIP][145] ([fdo#111615]) +2 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglu: [PASS][146] -> [FAIL][147] ([i915#3743])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-tglu-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-dg1: NOTRUN -> [SKIP][148] ([i915#4538])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-dg2: NOTRUN -> [SKIP][149] ([i915#4538] / [i915#5190]) +4 other tests skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglu: NOTRUN -> [SKIP][150] ([fdo#111615]) +2 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_big_fb@yf-tiled-addfb.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-rkl: NOTRUN -> [SKIP][151] ([fdo#110723])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4-tiled-dg2-rc-ccs:
- shard-rkl: NOTRUN -> [SKIP][152] ([i915#5354] / [i915#6095]) +10 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_ccs@pipe-a-bad-pixel-format-4-tiled-dg2-rc-ccs.html
* igt@kms_ccs@pipe-a-crc-primary-basic-4-tiled-dg2-mc-ccs:
- shard-mtlp: NOTRUN -> [SKIP][153] ([i915#5354] / [i915#6095]) +10 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_ccs@pipe-a-crc-primary-basic-4-tiled-dg2-mc-ccs.html
* igt@kms_ccs@pipe-a-random-ccs-data-4-tiled-dg2-rc-ccs-cc:
- shard-dg1: NOTRUN -> [SKIP][154] ([i915#5354] / [i915#6095]) +14 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_ccs@pipe-a-random-ccs-data-4-tiled-dg2-rc-ccs-cc.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y-tiled-gen12-mc-ccs:
- shard-tglu: NOTRUN -> [SKIP][155] ([i915#5354] / [i915#6095]) +22 other tests skip
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_ccs@pipe-c-bad-rotation-90-y-tiled-gen12-mc-ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-4-tiled-mtl-mc-ccs:
- shard-glk: NOTRUN -> [SKIP][156] ([fdo#109271]) +266 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk4/igt@kms_ccs@pipe-c-crc-primary-rotation-180-4-tiled-mtl-mc-ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-4-tiled-mtl-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][157] ([i915#5354]) +94 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_ccs@pipe-d-missing-ccs-buffer-4-tiled-mtl-mc-ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y-tiled-ccs:
- shard-rkl: NOTRUN -> [SKIP][158] ([i915#5354]) +9 other tests skip
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_ccs@pipe-d-missing-ccs-buffer-y-tiled-ccs.html
* igt@kms_chamelium_color@ctm-0-50:
- shard-tglu: NOTRUN -> [SKIP][159] ([fdo#111827])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_chamelium_color@ctm-0-50.html
* igt@kms_chamelium_color@ctm-0-75:
- shard-dg1: NOTRUN -> [SKIP][160] ([fdo#111827])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_chamelium_color@ctm-0-75.html
* igt@kms_chamelium_color@ctm-blue-to-red:
- shard-dg2: NOTRUN -> [SKIP][161] ([fdo#111827]) +1 other test skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@kms_chamelium_color@ctm-blue-to-red.html
* igt@kms_chamelium_color@ctm-limited-range:
- shard-rkl: NOTRUN -> [SKIP][162] ([fdo#111827]) +1 other test skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_chamelium_color@ctm-limited-range.html
* igt@kms_chamelium_color@degamma:
- shard-mtlp: NOTRUN -> [SKIP][163] ([fdo#111827])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_chamelium_color@degamma.html
* igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k:
- shard-dg2: NOTRUN -> [SKIP][164] ([i915#7828]) +10 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k.html
* igt@kms_chamelium_frames@dp-crc-multiple:
- shard-mtlp: NOTRUN -> [SKIP][165] ([i915#7828])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_chamelium_frames@dp-crc-multiple.html
* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- shard-dg1: NOTRUN -> [SKIP][166] ([i915#7828]) +1 other test skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_chamelium_hpd@dp-hpd-after-suspend.html
* igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode:
- shard-rkl: NOTRUN -> [SKIP][167] ([i915#7828]) +1 other test skip
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode.html
* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-tglu: NOTRUN -> [SKIP][168] ([i915#7828]) +1 other test skip
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_chamelium_hpd@vga-hpd-fast.html
* igt@kms_content_protection@atomic:
- shard-dg2: NOTRUN -> [SKIP][169] ([i915#7118])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-dg2: NOTRUN -> [SKIP][170] ([i915#3299])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-mtlp: NOTRUN -> [SKIP][171] ([i915#3299])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@lic:
- shard-rkl: NOTRUN -> [SKIP][172] ([i915#7118]) +1 other test skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_content_protection@lic.html
- shard-tglu: NOTRUN -> [SKIP][173] ([i915#6944] / [i915#7116] / [i915#7118])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_content_protection@lic.html
* igt@kms_content_protection@srm@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][174] ([i915#7173])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_content_protection@srm@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-dg2: NOTRUN -> [SKIP][175] ([i915#3359]) +2 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_cursor_crc@cursor-offscreen-512x512.html
* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-mtlp: NOTRUN -> [SKIP][176] ([i915#3555] / [i915#8814])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_cursor_crc@cursor-onscreen-32x10.html
* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-rkl: NOTRUN -> [SKIP][177] ([fdo#109279] / [i915#3359])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_cursor_crc@cursor-onscreen-512x170.html
- shard-tglu: NOTRUN -> [SKIP][178] ([fdo#109279] / [i915#3359])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_cursor_crc@cursor-onscreen-512x170.html
* igt@kms_cursor_crc@cursor-random-64x21:
- shard-mtlp: NOTRUN -> [SKIP][179] ([i915#8814])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_cursor_crc@cursor-random-64x21.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-rkl: NOTRUN -> [SKIP][180] ([i915#3359]) +1 other test skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-4:
- shard-dg1: [PASS][181] -> [FAIL][182] ([fdo#103375]) +2 other tests fail
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg1-17/igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-4.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-14/igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-4.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][183] -> [FAIL][184] ([i915#72])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursora-vs-flipb-legacy:
- shard-snb: [PASS][185] -> [SKIP][186] ([fdo#109271]) +4 other tests skip
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-snb7/igt@kms_cursor_legacy@cursora-vs-flipb-legacy.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb4/igt@kms_cursor_legacy@cursora-vs-flipb-legacy.html
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-dg2: NOTRUN -> [SKIP][187] ([fdo#109274] / [i915#5354]) +6 other tests skip
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
- shard-rkl: NOTRUN -> [SKIP][188] ([fdo#111825]) +1 other test skip
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-mtlp: NOTRUN -> [SKIP][189] ([i915#9809])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-dg1: NOTRUN -> [SKIP][190] ([fdo#111825]) +8 other tests skip
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-tglu: NOTRUN -> [SKIP][191] ([fdo#109274]) +2 other tests skip
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-dg2: NOTRUN -> [SKIP][192] ([i915#4103] / [i915#4213])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@single-move@all-pipes:
- shard-mtlp: [PASS][193] -> [DMESG-WARN][194] ([i915#2017])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-mtlp-6/igt@kms_cursor_legacy@single-move@all-pipes.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-4/igt@kms_cursor_legacy@single-move@all-pipes.html
* igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][195] ([i915#9723])
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-7/igt@kms_dirtyfb@fbc-dirtyfb-ioctl@a-hdmi-a-1.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-dg2: NOTRUN -> [SKIP][196] ([i915#9833])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_dirtyfb@psr-dirtyfb-ioctl.html
* igt@kms_dsc@dsc-basic:
- shard-dg2: NOTRUN -> [SKIP][197] ([i915#3555] / [i915#3840])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_dsc@dsc-basic.html
- shard-rkl: NOTRUN -> [SKIP][198] ([i915#3555] / [i915#3840])
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_dsc@dsc-basic.html
* igt@kms_dsc@dsc-fractional-bpp:
- shard-dg2: NOTRUN -> [SKIP][199] ([i915#3840] / [i915#9688])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_dsc@dsc-fractional-bpp.html
* igt@kms_dsc@dsc-with-output-formats:
- shard-dg1: NOTRUN -> [SKIP][200] ([i915#3555] / [i915#3840])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_dsc@dsc-with-output-formats.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-dg2: NOTRUN -> [SKIP][201] ([fdo#109274] / [fdo#111767])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
- shard-tglu: NOTRUN -> [SKIP][202] ([fdo#109274] / [fdo#111767] / [i915#3637]) +1 other test skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-rkl: NOTRUN -> [SKIP][203] ([fdo#111767] / [fdo#111825])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html
* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-tglu: NOTRUN -> [SKIP][204] ([fdo#109274] / [i915#3637])
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-dg2: NOTRUN -> [SKIP][205] ([fdo#109274]) +8 other tests skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@flip-vs-fences:
- shard-dg2: NOTRUN -> [SKIP][206] ([i915#8381]) +1 other test skip
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_flip@flip-vs-fences.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][207] ([i915#2672])
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][208] ([i915#8810])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][209] ([i915#2587] / [i915#2672]) +1 other test skip
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][210] ([i915#2672]) +5 other tests skip
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-valid-mode.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-dg1: NOTRUN -> [SKIP][211] ([fdo#109285])
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [FAIL][212] ([i915#6880])
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][213] ([i915#8708]) +1 other test skip
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-render:
- shard-mtlp: NOTRUN -> [SKIP][214] ([i915#1825]) +8 other tests skip
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][215] ([i915#3458]) +16 other tests skip
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][216] ([i915#3458]) +4 other tests skip
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-tglu: NOTRUN -> [SKIP][217] ([fdo#109280]) +12 other tests skip
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][218] ([i915#8708]) +27 other tests skip
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-dg2: NOTRUN -> [SKIP][219] ([i915#9766])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_frontbuffer_tracking@pipe-fbc-rte.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-rkl: NOTRUN -> [SKIP][220] ([i915#3023]) +5 other tests skip
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][221] ([i915#8708]) +5 other tests skip
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][222] ([fdo#111825] / [i915#1825]) +10 other tests skip
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt:
- shard-tglu: NOTRUN -> [SKIP][223] ([fdo#110189]) +8 other tests skip
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt.html
* igt@kms_getfb@getfb-reject-ccs:
- shard-dg2: NOTRUN -> [SKIP][224] ([i915#6118])
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_getfb@getfb-reject-ccs.html
* igt@kms_hdr@invalid-metadata-sizes:
- shard-dg1: NOTRUN -> [SKIP][225] ([i915#3555] / [i915#8228])
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_hdr@invalid-metadata-sizes.html
* igt@kms_hdr@static-toggle:
- shard-mtlp: NOTRUN -> [SKIP][226] ([i915#3555] / [i915#8228])
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_hdr@static-toggle.html
* igt@kms_hdr@static-toggle-suspend:
- shard-dg2: NOTRUN -> [SKIP][227] ([i915#3555] / [i915#8228]) +2 other tests skip
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_panel_fitting@atomic-fastset:
- shard-dg2: NOTRUN -> [SKIP][228] ([i915#6301])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_panel_fitting@atomic-fastset.html
* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-mtlp: NOTRUN -> [SKIP][229] ([fdo#109289]) +1 other test skip
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c.html
* igt@kms_plane@pixel-format-source-clamping@pipe-a:
- shard-glk: [PASS][230] -> [DMESG-FAIL][231] ([i915#118])
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-glk7/igt@kms_plane@pixel-format-source-clamping@pipe-a.html
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk8/igt@kms_plane@pixel-format-source-clamping@pipe-a.html
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [FAIL][232] ([i915#4573]) +1 other test fail
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk3/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1.html
* igt@kms_plane_multiple@tiling-yf:
- shard-dg1: NOTRUN -> [SKIP][233] ([i915#3555]) +2 other tests skip
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_plane_multiple@tiling-yf.html
* igt@kms_plane_scaling@intel-max-src-size:
- shard-dg2: NOTRUN -> [SKIP][234] ([i915#6953] / [i915#9423])
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-2/igt@kms_plane_scaling@intel-max-src-size.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][235] ([i915#8292])
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-14/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][236] ([i915#9423]) +3 other tests skip
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-d-dp-4.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][237] ([i915#9423]) +5 other tests skip
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-3/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][238] ([i915#9423]) +11 other tests skip
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-4.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][239] ([i915#5176] / [i915#9423]) +1 other test skip
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][240] ([i915#5235]) +3 other tests skip
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-4.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][241] ([i915#5235]) +1 other test skip
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-3/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][242] ([i915#5235] / [i915#9423]) +11 other tests skip
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][243] ([i915#5235]) +3 other tests skip
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][244] ([i915#5235]) +2 other tests skip
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75@pipe-a-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][245] ([i915#3555] / [i915#5235])
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75@pipe-d-edp-1.html
* igt@kms_pm_backlight@fade:
- shard-tglu: NOTRUN -> [SKIP][246] ([i915#9812])
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_pm_backlight@fade.html
* igt@kms_pm_backlight@fade-with-dpms:
- shard-dg1: NOTRUN -> [SKIP][247] ([i915#5354])
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_pm_backlight@fade-with-dpms.html
* igt@kms_pm_dc@dc5-dpms-negative:
- shard-mtlp: NOTRUN -> [SKIP][248] ([i915#9293])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_pm_dc@dc5-dpms-negative.html
* igt@kms_pm_dc@dc6-dpms:
- shard-dg2: NOTRUN -> [SKIP][249] ([i915#5978])
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_pm_dc@dc6-dpms.html
* igt@kms_pm_dc@dc6-psr:
- shard-dg2: NOTRUN -> [SKIP][250] ([i915#9685])
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_pm_dc@dc6-psr.html
* igt@kms_pm_rpm@fences:
- shard-dg1: NOTRUN -> [SKIP][251] ([i915#4077]) +2 other tests skip
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_pm_rpm@fences.html
* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-dg2: NOTRUN -> [SKIP][252] ([i915#9519])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_pm_rpm@modeset-lpsp-stress.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-rkl: [PASS][253] -> [SKIP][254] ([i915#9519])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_pm_rpm@modeset-pc8-residency-stress:
- shard-rkl: NOTRUN -> [SKIP][255] ([fdo#109293] / [fdo#109506])
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_pm_rpm@modeset-pc8-residency-stress.html
- shard-tglu: NOTRUN -> [SKIP][256] ([fdo#109293] / [fdo#109506])
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_pm_rpm@modeset-pc8-residency-stress.html
* igt@kms_prime@basic-crc-vgem:
- shard-dg2: NOTRUN -> [SKIP][257] ([i915#6524] / [i915#6805])
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_prime@basic-crc-vgem.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-tglu: NOTRUN -> [SKIP][258] ([i915#9683])
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-3/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
- shard-rkl: NOTRUN -> [SKIP][259] ([i915#9683])
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-tglu: NOTRUN -> [SKIP][260] ([fdo#111068] / [i915#9683])
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-dg2: NOTRUN -> [SKIP][261] ([i915#9683]) +3 other tests skip
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_rotation_crc@bad-pixel-format:
- shard-rkl: [PASS][262] -> [INCOMPLETE][263] ([i915#9569])
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/igt@kms_rotation_crc@bad-pixel-format.html
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/igt@kms_rotation_crc@bad-pixel-format.html
* igt@kms_scaling_modes@scaling-mode-center:
- shard-tglu: NOTRUN -> [SKIP][264] ([i915#3555]) +1 other test skip
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_scaling_modes@scaling-mode-center.html
* igt@kms_setmode@basic-clone-single-crtc:
- shard-dg2: NOTRUN -> [SKIP][265] ([i915#3555]) +3 other tests skip
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@kms_setmode@basic@pipe-a-vga-1-pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][266] ([i915#5465]) +3 other tests fail
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb7/igt@kms_setmode@basic@pipe-a-vga-1-pipe-b-hdmi-a-1.html
* igt@kms_sysfs_edid_timing:
- shard-dg2: NOTRUN -> [FAIL][267] ([IGT#2])
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_sysfs_edid_timing.html
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglu: NOTRUN -> [SKIP][268] ([i915#8623])
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
- shard-dg2: NOTRUN -> [SKIP][269] ([i915#8623])
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-snb: [PASS][270] -> [FAIL][271] ([i915#9196]) +1 other test fail
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-snb6/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb5/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-1:
- shard-tglu: [PASS][272] -> [FAIL][273] ([i915#9196])
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-1.html
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][274] ([i915#9196])
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-4.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [FAIL][275] ([i915#9196])
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-3.html
* igt@kms_vrr@flip-dpms:
- shard-rkl: NOTRUN -> [SKIP][276] ([i915#3555])
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_vrr@flip-dpms.html
* igt@kms_writeback@writeback-check-output:
- shard-dg2: NOTRUN -> [SKIP][277] ([i915#2437])
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-glk: NOTRUN -> [SKIP][278] ([fdo#109271] / [i915#2437])
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-glk9/igt@kms_writeback@writeback-fb-id-xrgb2101010.html
* igt@perf_pmu@busy-double-start@bcs0:
- shard-mtlp: [PASS][279] -> [FAIL][280] ([i915#4349])
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-mtlp-2/igt@perf_pmu@busy-double-start@bcs0.html
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-8/igt@perf_pmu@busy-double-start@bcs0.html
* igt@perf_pmu@busy-double-start@vecs1:
- shard-dg2: [PASS][281] -> [FAIL][282] ([i915#4349]) +3 other tests fail
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg2-6/igt@perf_pmu@busy-double-start@vecs1.html
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@perf_pmu@busy-double-start@vecs1.html
* igt@perf_pmu@cpu-hotplug:
- shard-dg2: NOTRUN -> [SKIP][283] ([i915#8850])
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@perf_pmu@cpu-hotplug.html
* igt@prime_vgem@basic-fence-flip:
- shard-dg2: NOTRUN -> [SKIP][284] ([i915#3708])
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-11/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-gtt:
- shard-dg1: NOTRUN -> [SKIP][285] ([i915#3708] / [i915#4077])
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@fence-read-hang:
- shard-dg1: NOTRUN -> [SKIP][286] ([i915#3708])
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@prime_vgem@fence-read-hang.html
* igt@runner@aborted:
- shard-snb: NOTRUN -> ([FAIL][287], [FAIL][288]) ([i915#7812])
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb6/igt@runner@aborted.html
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb4/igt@runner@aborted.html
* igt@sriov_basic@enable-vfs-autoprobe-off:
- shard-dg2: NOTRUN -> [SKIP][289] ([i915#9917]) +1 other test skip
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@sriov_basic@enable-vfs-autoprobe-off.html
- shard-tglu: NOTRUN -> [SKIP][290] ([i915#9917])
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@sriov_basic@enable-vfs-autoprobe-off.html
* igt@sriov_basic@enable-vfs-autoprobe-on:
- shard-dg1: NOTRUN -> [SKIP][291] ([i915#9917])
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@sriov_basic@enable-vfs-autoprobe-on.html
* igt@syncobj_timeline@invalid-wait-zero-handles:
- shard-dg2: NOTRUN -> [FAIL][292] ([i915#9781])
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@syncobj_timeline@invalid-wait-zero-handles.html
- shard-tglu: NOTRUN -> [FAIL][293] ([i915#9781])
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@syncobj_timeline@invalid-wait-zero-handles.html
* igt@v3d/v3d_create_bo@create-bo-invalid-flags:
- shard-dg1: NOTRUN -> [SKIP][294] ([i915#2575]) +2 other tests skip
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@v3d/v3d_create_bo@create-bo-invalid-flags.html
* igt@v3d/v3d_get_bo_offset@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][295] ([i915#2575]) +11 other tests skip
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-6/igt@v3d/v3d_get_bo_offset@get-bad-handle.html
* igt@v3d/v3d_submit_cl@single-in-sync:
- shard-mtlp: NOTRUN -> [SKIP][296] ([i915#2575]) +2 other tests skip
[296]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@v3d/v3d_submit_cl@single-in-sync.html
* igt@v3d/v3d_submit_cl@valid-submission:
- shard-tglu: NOTRUN -> [SKIP][297] ([fdo#109315] / [i915#2575]) +4 other tests skip
[297]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@v3d/v3d_submit_cl@valid-submission.html
* igt@v3d/v3d_submit_csd@bad-multisync-pad:
- shard-rkl: NOTRUN -> [SKIP][298] ([fdo#109315]) +3 other tests skip
[298]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-1/igt@v3d/v3d_submit_csd@bad-multisync-pad.html
* igt@vc4/vc4_dmabuf_poll@poll-write-waits-until-write-done:
- shard-tglu: NOTRUN -> [SKIP][299] ([i915#2575]) +3 other tests skip
[299]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@vc4/vc4_dmabuf_poll@poll-write-waits-until-write-done.html
* igt@vc4/vc4_perfmon@create-two-perfmon:
- shard-dg1: NOTRUN -> [SKIP][300] ([i915#7711]) +1 other test skip
[300]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-17/igt@vc4/vc4_perfmon@create-two-perfmon.html
* igt@vc4/vc4_purgeable_bo@mark-unpurgeable-check-retained:
- shard-mtlp: NOTRUN -> [SKIP][301] ([i915#7711])
[301]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@vc4/vc4_purgeable_bo@mark-unpurgeable-check-retained.html
* igt@vc4/vc4_tiling@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][302] ([i915#7711]) +8 other tests skip
[302]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@vc4/vc4_tiling@get-bad-handle.html
* igt@vc4/vc4_tiling@set-get:
- shard-rkl: NOTRUN -> [SKIP][303] ([i915#7711]) +1 other test skip
[303]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@vc4/vc4_tiling@set-get.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][304] ([i915#6268]) -> [PASS][305]
[304]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
[305]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-6/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-rkl: [FAIL][306] ([i915#2842]) -> [PASS][307] +1 other test pass
[306]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-4/igt@gem_exec_fair@basic-pace@vecs0.html
[307]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_suspend@basic-s0@smem:
- shard-dg2: [INCOMPLETE][308] -> [PASS][309]
[308]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg2-10/igt@gem_exec_suspend@basic-s0@smem.html
[309]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-5/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [INCOMPLETE][310] ([i915#9200]) -> [PASS][311]
[310]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-tglu-5/igt@i915_module_load@reload-with-fault-injection.html
[311]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-5/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0:
- shard-dg1: [FAIL][312] ([i915#3591]) -> [PASS][313]
[312]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0.html
[313]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [FAIL][314] ([i915#5138]) -> [PASS][315]
[314]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
[315]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-dg1: [DMESG-WARN][316] ([i915#4423]) -> [PASS][317]
[316]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg1-12/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[317]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-13/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-snb: [SKIP][318] ([fdo#109271]) -> [PASS][319] +7 other tests pass
[318]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-snb4/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html
[319]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb7/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-snb: [SKIP][320] ([fdo#109271] / [fdo#111767]) -> [PASS][321]
[320]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-snb1/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
[321]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb7/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
* igt@kms_flip@flip-vs-suspend@b-vga1:
- shard-snb: [DMESG-WARN][322] ([i915#10007]) -> [PASS][323]
[322]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-snb4/igt@kms_flip@flip-vs-suspend@b-vga1.html
[323]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb1/igt@kms_flip@flip-vs-suspend@b-vga1.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-dg2: [FAIL][324] ([i915#6880]) -> [PASS][325]
[324]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[325]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_plane@pixel-format@pipe-a:
- shard-mtlp: [ABORT][326] -> [PASS][327]
[326]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-mtlp-2/igt@kms_plane@pixel-format@pipe-a.html
[327]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_plane@pixel-format@pipe-a.html
* igt@kms_pm_rpm@dpms-mode-unset-lpsp:
- shard-rkl: [SKIP][328] ([i915#9519]) -> [PASS][329]
[328]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-1/igt@kms_pm_rpm@dpms-mode-unset-lpsp.html
[329]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/igt@kms_pm_rpm@dpms-mode-unset-lpsp.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-180:
- shard-rkl: [INCOMPLETE][330] ([i915#8875] / [i915#9569]) -> [PASS][331]
[330]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/igt@kms_rotation_crc@primary-y-tiled-reflect-x-180.html
[331]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-5/igt@kms_rotation_crc@primary-y-tiled-reflect-x-180.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-tglu: [FAIL][332] ([i915#9196]) -> [PASS][333] +1 other test pass
[332]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
[333]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][334] ([i915#7484]) -> [PASS][335]
[334]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html
[335]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-2/igt@perf@non-zero-reason@0-rcs0.html
#### Warnings ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg1: [INCOMPLETE][336] ([i915#9820] / [i915#9849]) -> [INCOMPLETE][337] ([i915#9849])
[336]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg1-14/igt@i915_module_load@reload-with-fault-injection.html
[337]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg1-15/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_async_flips@crc@pipe-d-edp-1:
- shard-mtlp: [DMESG-FAIL][338] ([i915#8561]) -> [FAIL][339] ([i915#8247]) +1 other test fail
[338]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-mtlp-1/igt@kms_async_flips@crc@pipe-d-edp-1.html
[339]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-mtlp-3/igt@kms_async_flips@crc@pipe-d-edp-1.html
* igt@kms_content_protection@uevent:
- shard-snb: [SKIP][340] ([fdo#109271]) -> [INCOMPLETE][341] ([i915#8816])
[340]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-snb1/igt@kms_content_protection@uevent.html
[341]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-snb7/igt@kms_content_protection@uevent.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][342] ([i915#3955]) -> [SKIP][343] ([fdo#110189] / [i915#3955])
[342]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
[343]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-rkl-2/igt@kms_fbcon_fbt@psr.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [CRASH][344] ([i915#9351]) -> [INCOMPLETE][345] ([i915#5493])
[344]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14078/shard-dg2-3/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[345]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/shard-dg2-2/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#10007]: https://gitlab.freedesktop.org/drm/intel/issues/10007
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5978]: https://gitlab.freedesktop.org/drm/intel/issues/5978
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6118]: https://gitlab.freedesktop.org/drm/intel/issues/6118
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
[i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
[i915#8816]: https://gitlab.freedesktop.org/drm/intel/issues/8816
[i915#8850]: https://gitlab.freedesktop.org/drm/intel/issues/8850
[i915#8875]: https://gitlab.freedesktop.org/drm/intel/issues/8875
[i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925
[i915#9196]: https://gitlab.freedesktop.org/drm/intel/issues/9196
[i915#9200]: https://gitlab.freedesktop.org/drm/intel/issues/9200
[i915#9293]: https://gitlab.freedesktop.org/drm/intel/issues/9293
[i915#9323]: https://gitlab.freedesktop.org/drm/intel/issues/9323
[i915#9351]: https://gitlab.freedesktop.org/drm/intel/issues/9351
[i915#9423]: https://gitlab.freedesktop.org/drm/intel/issues/9423
[i915#9519]: https://gitlab.freedesktop.org/drm/intel/issues/9519
[i915#9531]: https://gitlab.freedesktop.org/drm/intel/issues/9531
[i915#9559]: https://gitlab.freedesktop.org/drm/intel/issues/9559
[i915#9569]: https://gitlab.freedesktop.org/drm/intel/issues/9569
[i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/intel/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/intel/issues/9685
[i915#9688]: https://gitlab.freedesktop.org/drm/intel/issues/9688
[i915#9723]: https://gitlab.freedesktop.org/drm/intel/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/intel/issues/9766
[i915#9781]: https://gitlab.freedesktop.org/drm/intel/issues/9781
[i915#9809]: https://gitlab.freedesktop.org/drm/intel/issues/9809
[i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812
[i915#9820]: https://gitlab.freedesktop.org/drm/intel/issues/9820
[i915#9833]: https://gitlab.freedesktop.org/drm/intel/issues/9833
[i915#9849]: https://gitlab.freedesktop.org/drm/intel/issues/9849
[i915#9917]: https://gitlab.freedesktop.org/drm/intel/issues/9917
Build changes
-------------
* Linux: CI_DRM_14078 -> Patchwork_128207v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_14078: 1baf990bc673f31d9eba7dfcb597ac0cb7420b14 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7655: ddf7cf40a00caa7d02f3729e1e50f78f102463d9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_128207v1: 1baf990bc673f31d9eba7dfcb597ac0cb7420b14 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128207v1/index.html
[-- Attachment #2: Type: text/html, Size: 106439 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] drm/ttm: replace busy placement with flags v4
2024-01-04 15:05 ` [PATCH 2/4] drm/ttm: replace busy placement with flags v4 Christian König
@ 2024-01-04 20:02 ` Zack Rusin
2024-01-05 12:27 ` Christian König
0 siblings, 1 reply; 11+ messages in thread
From: Zack Rusin @ 2024-01-04 20:02 UTC (permalink / raw)
To: Christian König
Cc: thomas.hellstrom, kherbst, nouveau, intel-gfx, dri-devel, zackr
On Thu, Jan 4, 2024 at 10:05 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> From: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
>
> Instead of a list of separate busy placement add flags which indicate
> that a placement should only be used when there is room or if we need to
> evict.
>
> v2: add missing TTM_PL_FLAG_IDLE for i915
> v3: fix auto build test ERROR on drm-tip/drm-tip
> v4: fix some typos pointed out by checkpatch
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 +--
> drivers/gpu/drm/drm_gem_vram_helper.c | 2 -
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 37 ++++----
> drivers/gpu/drm/loongson/lsdc_ttm.c | 2 -
> drivers/gpu/drm/nouveau/nouveau_bo.c | 59 +++++--------
> drivers/gpu/drm/nouveau/nouveau_bo.h | 1 -
> drivers/gpu/drm/qxl/qxl_object.c | 2 -
> drivers/gpu/drm/qxl/qxl_ttm.c | 2 -
> drivers/gpu/drm/radeon/radeon_object.c | 2 -
> drivers/gpu/drm/radeon/radeon_ttm.c | 8 +-
> drivers/gpu/drm/radeon/radeon_uvd.c | 1 -
> drivers/gpu/drm/ttm/ttm_bo.c | 21 +++--
> drivers/gpu/drm/ttm/ttm_resource.c | 73 ++++------------
> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 -
> drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 99 +++++++++++++++++-----
> include/drm/ttm/ttm_placement.h | 10 ++-
> include/drm/ttm/ttm_resource.h | 8 +-
> 18 files changed, 159 insertions(+), 187 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index cef920a93924..aa0dd6dad068 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -220,9 +220,6 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
>
> placement->num_placement = c;
> placement->placement = places;
> -
> - placement->num_busy_placement = c;
> - placement->busy_placement = places;
> }
>
> /**
> @@ -1406,8 +1403,7 @@ vm_fault_t amdgpu_bo_fault_reserve_notify(struct ttm_buffer_object *bo)
> AMDGPU_GEM_DOMAIN_GTT);
>
> /* Avoid costly evictions; only set GTT as a busy placement */
> - abo->placement.num_busy_placement = 1;
> - abo->placement.busy_placement = &abo->placements[1];
> + abo->placements[0].flags |= TTM_PL_FLAG_IDLE;
>
> r = ttm_bo_validate(bo, &abo->placement, &ctx);
> if (unlikely(r == -EBUSY || r == -ERESTARTSYS))
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 05991c5c8ddb..9a6a00b1af40 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -102,23 +102,19 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
> /* Don't handle scatter gather BOs */
> if (bo->type == ttm_bo_type_sg) {
> placement->num_placement = 0;
> - placement->num_busy_placement = 0;
> return;
> }
>
> /* Object isn't an AMDGPU object so ignore */
> if (!amdgpu_bo_is_amdgpu_bo(bo)) {
> placement->placement = &placements;
> - placement->busy_placement = &placements;
> placement->num_placement = 1;
> - placement->num_busy_placement = 1;
> return;
> }
>
> abo = ttm_to_amdgpu_bo(bo);
> if (abo->flags & AMDGPU_GEM_CREATE_DISCARDABLE) {
> placement->num_placement = 0;
> - placement->num_busy_placement = 0;
> return;
> }
>
> @@ -128,13 +124,13 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
> case AMDGPU_PL_OA:
> case AMDGPU_PL_DOORBELL:
> placement->num_placement = 0;
> - placement->num_busy_placement = 0;
> return;
>
> case TTM_PL_VRAM:
> if (!adev->mman.buffer_funcs_enabled) {
> /* Move to system memory */
> amdgpu_bo_placement_from_domain(abo, AMDGPU_GEM_DOMAIN_CPU);
> +
> } else if (!amdgpu_gmc_vram_full_visible(&adev->gmc) &&
> !(abo->flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) &&
> amdgpu_bo_in_cpu_visible_vram(abo)) {
> @@ -149,8 +145,7 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
> AMDGPU_GEM_DOMAIN_CPU);
> abo->placements[0].fpfn = adev->gmc.visible_vram_size >> PAGE_SHIFT;
> abo->placements[0].lpfn = 0;
> - abo->placement.busy_placement = &abo->placements[1];
> - abo->placement.num_busy_placement = 1;
> + abo->placements[0].flags |= TTM_PL_FLAG_IDLE;
> } else {
> /* Move to GTT memory */
> amdgpu_bo_placement_from_domain(abo, AMDGPU_GEM_DOMAIN_GTT |
> @@ -967,8 +962,6 @@ int amdgpu_ttm_alloc_gart(struct ttm_buffer_object *bo)
> /* allocate GART space */
> placement.num_placement = 1;
> placement.placement = &placements;
> - placement.num_busy_placement = 1;
> - placement.busy_placement = &placements;
> placements.fpfn = 0;
> placements.lpfn = adev->gmc.gart_size >> PAGE_SHIFT;
> placements.mem_type = TTM_PL_TT;
> diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
> index b67eafa55715..75f2eaf0d5b6 100644
> --- a/drivers/gpu/drm/drm_gem_vram_helper.c
> +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
> @@ -147,7 +147,6 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
> invariant_flags = TTM_PL_FLAG_TOPDOWN;
>
> gbo->placement.placement = gbo->placements;
> - gbo->placement.busy_placement = gbo->placements;
>
> if (pl_flag & DRM_GEM_VRAM_PL_FLAG_VRAM) {
> gbo->placements[c].mem_type = TTM_PL_VRAM;
> @@ -160,7 +159,6 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
> }
>
> gbo->placement.num_placement = c;
> - gbo->placement.num_busy_placement = c;
>
> for (i = 0; i < c; ++i) {
> gbo->placements[i].fpfn = 0;
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 9227f8146a58..48fc9779fd50 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -65,8 +65,6 @@ static const struct ttm_place sys_placement_flags = {
> static struct ttm_placement i915_sys_placement = {
> .num_placement = 1,
> .placement = &sys_placement_flags,
> - .num_busy_placement = 1,
> - .busy_placement = &sys_placement_flags,
> };
>
> /**
> @@ -157,32 +155,28 @@ i915_ttm_place_from_region(const struct intel_memory_region *mr,
>
> static void
> i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
> - struct ttm_place *requested,
> - struct ttm_place *busy,
> + struct ttm_place *places,
> struct ttm_placement *placement)
> {
> unsigned int num_allowed = obj->mm.n_placements;
> unsigned int flags = obj->flags;
> unsigned int i;
>
> - placement->num_placement = 1;
> + places[0].flags |= TTM_PL_FLAG_IDLE;
> i915_ttm_place_from_region(num_allowed ? obj->mm.placements[0] :
> - obj->mm.region, requested, obj->bo_offset,
> + obj->mm.region, &places[0], obj->bo_offset,
> obj->base.size, flags);
>
> /* Cache this on object? */
> - placement->num_busy_placement = num_allowed;
> - for (i = 0; i < placement->num_busy_placement; ++i)
> - i915_ttm_place_from_region(obj->mm.placements[i], busy + i,
> - obj->bo_offset, obj->base.size, flags);
> -
> - if (num_allowed == 0) {
> - *busy = *requested;
> - placement->num_busy_placement = 1;
> + for (i = 0; i < num_allowed; ++i) {
> + i915_ttm_place_from_region(obj->mm.placements[i],
> + &places[i + 1], obj->bo_offset,
> + obj->base.size, flags);
> + places[i + 1].flags |= TTM_PL_FLAG_BUSY;
> }
>
> - placement->placement = requested;
> - placement->busy_placement = busy;
> + placement->num_placement = num_allowed + 1;
> + placement->placement = places;
> }
>
> static int i915_ttm_tt_shmem_populate(struct ttm_device *bdev,
> @@ -789,7 +783,8 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
> int ret;
>
> /* First try only the requested placement. No eviction. */
> - real_num_busy = fetch_and_zero(&placement->num_busy_placement);
> + real_num_busy = placement->num_placement;
> + placement->num_placement = 1;
> ret = ttm_bo_validate(bo, placement, &ctx);
> if (ret) {
> ret = i915_ttm_err_to_gem(ret);
> @@ -805,7 +800,7 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
> * If the initial attempt fails, allow all accepted placements,
> * evicting if necessary.
> */
> - placement->num_busy_placement = real_num_busy;
> + placement->num_placement = real_num_busy;
> ret = ttm_bo_validate(bo, placement, &ctx);
> if (ret)
> return i915_ttm_err_to_gem(ret);
> @@ -839,7 +834,7 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
>
> static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
> {
> - struct ttm_place requested, busy[I915_TTM_MAX_PLACEMENTS];
> + struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1];
> struct ttm_placement placement;
>
> /* restricted by sg_alloc_table */
> @@ -849,7 +844,7 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
> GEM_BUG_ON(obj->mm.n_placements > I915_TTM_MAX_PLACEMENTS);
>
> /* Move to the requested placement. */
> - i915_ttm_placement_from_obj(obj, &requested, busy, &placement);
> + i915_ttm_placement_from_obj(obj, places, &placement);
>
> return __i915_ttm_get_pages(obj, &placement);
> }
> @@ -879,9 +874,7 @@ static int __i915_ttm_migrate(struct drm_i915_gem_object *obj,
> i915_ttm_place_from_region(mr, &requested, obj->bo_offset,
> obj->base.size, flags);
> placement.num_placement = 1;
> - placement.num_busy_placement = 1;
> placement.placement = &requested;
> - placement.busy_placement = &requested;
>
> ret = __i915_ttm_get_pages(obj, &placement);
> if (ret)
> diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c
> index bf79dc55afa4..465f622ac05d 100644
> --- a/drivers/gpu/drm/loongson/lsdc_ttm.c
> +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c
> @@ -54,7 +54,6 @@ static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
> pflags |= TTM_PL_FLAG_TOPDOWN;
>
> lbo->placement.placement = lbo->placements;
> - lbo->placement.busy_placement = lbo->placements;
>
> if (domain & LSDC_GEM_DOMAIN_VRAM) {
> lbo->placements[c].mem_type = TTM_PL_VRAM;
> @@ -77,7 +76,6 @@ static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
> }
>
> lbo->placement.num_placement = c;
> - lbo->placement.num_busy_placement = c;
>
> for (i = 0; i < c; ++i) {
> lbo->placements[i].fpfn = 0;
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index b7dda486a7ea..575875b6e47e 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -403,27 +403,6 @@ nouveau_bo_new(struct nouveau_cli *cli, u64 size, int align,
> return 0;
> }
>
> -static void
> -set_placement_list(struct ttm_place *pl, unsigned *n, uint32_t domain)
> -{
> - *n = 0;
> -
> - if (domain & NOUVEAU_GEM_DOMAIN_VRAM) {
> - pl[*n].mem_type = TTM_PL_VRAM;
> - pl[*n].flags = 0;
> - (*n)++;
> - }
> - if (domain & NOUVEAU_GEM_DOMAIN_GART) {
> - pl[*n].mem_type = TTM_PL_TT;
> - pl[*n].flags = 0;
> - (*n)++;
> - }
> - if (domain & NOUVEAU_GEM_DOMAIN_CPU) {
> - pl[*n].mem_type = TTM_PL_SYSTEM;
> - pl[(*n)++].flags = 0;
> - }
> -}
> -
> static void
> set_placement_range(struct nouveau_bo *nvbo, uint32_t domain)
> {
> @@ -451,10 +430,6 @@ set_placement_range(struct nouveau_bo *nvbo, uint32_t domain)
> nvbo->placements[i].fpfn = fpfn;
> nvbo->placements[i].lpfn = lpfn;
> }
> - for (i = 0; i < nvbo->placement.num_busy_placement; ++i) {
> - nvbo->busy_placements[i].fpfn = fpfn;
> - nvbo->busy_placements[i].lpfn = lpfn;
> - }
> }
> }
>
> @@ -462,15 +437,32 @@ void
> nouveau_bo_placement_set(struct nouveau_bo *nvbo, uint32_t domain,
> uint32_t busy)
> {
> - struct ttm_placement *pl = &nvbo->placement;
> + unsigned int *n = &nvbo->placement.num_placement;
> + struct ttm_place *pl = nvbo->placements;
>
> - pl->placement = nvbo->placements;
> - set_placement_list(nvbo->placements, &pl->num_placement, domain);
> + domain |= busy;
>
> - pl->busy_placement = nvbo->busy_placements;
> - set_placement_list(nvbo->busy_placements, &pl->num_busy_placement,
> - domain | busy);
> + *n = 0;
> + if (domain & NOUVEAU_GEM_DOMAIN_VRAM) {
> + pl[*n].mem_type = TTM_PL_VRAM;
> + pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_VRAM ?
> + TTM_PL_FLAG_BUSY : 0;
> + (*n)++;
> + }
> + if (domain & NOUVEAU_GEM_DOMAIN_GART) {
> + pl[*n].mem_type = TTM_PL_TT;
> + pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_GART ?
> + TTM_PL_FLAG_BUSY : 0;
> + (*n)++;
> + }
> + if (domain & NOUVEAU_GEM_DOMAIN_CPU) {
> + pl[*n].mem_type = TTM_PL_SYSTEM;
> + pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_CPU ?
> + TTM_PL_FLAG_BUSY : 0;
> + (*n)++;
> + }
>
> + nvbo->placement.placement = nvbo->placements;
> set_placement_range(nvbo, domain);
> }
>
> @@ -1313,11 +1305,6 @@ vm_fault_t nouveau_ttm_fault_reserve_notify(struct ttm_buffer_object *bo)
> nvbo->placements[i].lpfn = mappable;
> }
>
> - for (i = 0; i < nvbo->placement.num_busy_placement; ++i) {
> - nvbo->busy_placements[i].fpfn = 0;
> - nvbo->busy_placements[i].lpfn = mappable;
> - }
> -
> nouveau_bo_placement_set(nvbo, NOUVEAU_GEM_DOMAIN_VRAM, 0);
> }
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.h b/drivers/gpu/drm/nouveau/nouveau_bo.h
> index 70c551921a9e..e9dfab6a8156 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.h
> @@ -15,7 +15,6 @@ struct nouveau_bo {
> struct ttm_placement placement;
> u32 valid_domains;
> struct ttm_place placements[3];
> - struct ttm_place busy_placements[3];
> bool force_coherent;
> struct ttm_bo_kmap_obj kmap;
> struct list_head head;
> diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
> index 06a58dad5f5c..1e46b0a6e478 100644
> --- a/drivers/gpu/drm/qxl/qxl_object.c
> +++ b/drivers/gpu/drm/qxl/qxl_object.c
> @@ -66,7 +66,6 @@ void qxl_ttm_placement_from_domain(struct qxl_bo *qbo, u32 domain)
> pflag |= TTM_PL_FLAG_TOPDOWN;
>
> qbo->placement.placement = qbo->placements;
> - qbo->placement.busy_placement = qbo->placements;
> if (domain == QXL_GEM_DOMAIN_VRAM) {
> qbo->placements[c].mem_type = TTM_PL_VRAM;
> qbo->placements[c++].flags = pflag;
> @@ -86,7 +85,6 @@ void qxl_ttm_placement_from_domain(struct qxl_bo *qbo, u32 domain)
> qbo->placements[c++].flags = 0;
> }
> qbo->placement.num_placement = c;
> - qbo->placement.num_busy_placement = c;
> for (i = 0; i < c; ++i) {
> qbo->placements[i].fpfn = 0;
> qbo->placements[i].lpfn = 0;
> diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
> index 1a82629bce3f..765a144cea14 100644
> --- a/drivers/gpu/drm/qxl/qxl_ttm.c
> +++ b/drivers/gpu/drm/qxl/qxl_ttm.c
> @@ -60,9 +60,7 @@ static void qxl_evict_flags(struct ttm_buffer_object *bo,
>
> if (!qxl_ttm_bo_is_qxl_bo(bo)) {
> placement->placement = &placements;
> - placement->busy_placement = &placements;
> placement->num_placement = 1;
> - placement->num_busy_placement = 1;
> return;
> }
> qbo = to_qxl_bo(bo);
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 10c0fbd9d2b4..a955f8a2f7fe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -78,7 +78,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> u32 c = 0, i;
>
> rbo->placement.placement = rbo->placements;
> - rbo->placement.busy_placement = rbo->placements;
> if (domain & RADEON_GEM_DOMAIN_VRAM) {
> /* Try placing BOs which don't need CPU access outside of the
> * CPU accessible part of VRAM
> @@ -114,7 +113,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
>
> rbo->placement.num_placement = c;
> - rbo->placement.num_busy_placement = c;
>
> for (i = 0; i < c; ++i) {
> if ((rbo->flags & RADEON_GEM_CPU_ACCESS) &&
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index de4e6d78f1e1..d641f3040117 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -92,9 +92,7 @@ static void radeon_evict_flags(struct ttm_buffer_object *bo,
>
> if (!radeon_ttm_bo_is_radeon_bo(bo)) {
> placement->placement = &placements;
> - placement->busy_placement = &placements;
> placement->num_placement = 1;
> - placement->num_busy_placement = 1;
> return;
> }
> rbo = container_of(bo, struct radeon_bo, tbo);
> @@ -114,15 +112,11 @@ static void radeon_evict_flags(struct ttm_buffer_object *bo,
> */
> radeon_ttm_placement_from_domain(rbo, RADEON_GEM_DOMAIN_VRAM |
> RADEON_GEM_DOMAIN_GTT);
> - rbo->placement.num_busy_placement = 0;
> for (i = 0; i < rbo->placement.num_placement; i++) {
> if (rbo->placements[i].mem_type == TTM_PL_VRAM) {
> if (rbo->placements[i].fpfn < fpfn)
> rbo->placements[i].fpfn = fpfn;
> - } else {
> - rbo->placement.busy_placement =
> - &rbo->placements[i];
> - rbo->placement.num_busy_placement = 1;
> + rbo->placements[0].flags |= TTM_PL_FLAG_IDLE;
> }
> }
> } else
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index a2cda184b2b2..058a1c8451b2 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -324,7 +324,6 @@ void radeon_uvd_force_into_uvd_segment(struct radeon_bo *rbo,
> rbo->placements[1].fpfn += (256 * 1024 * 1024) >> PAGE_SHIFT;
> rbo->placements[1].lpfn += (256 * 1024 * 1024) >> PAGE_SHIFT;
> rbo->placement.num_placement++;
> - rbo->placement.num_busy_placement++;
> }
>
> void radeon_uvd_free_handles(struct radeon_device *rdev, struct drm_file *filp)
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 8c1eaa74fa21..aa12bd5cfd17 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -410,8 +410,8 @@ static int ttm_bo_bounce_temp_buffer(struct ttm_buffer_object *bo,
> struct ttm_resource *hop_mem;
> int ret;
>
> - hop_placement.num_placement = hop_placement.num_busy_placement = 1;
> - hop_placement.placement = hop_placement.busy_placement = hop;
> + hop_placement.num_placement = 1;
> + hop_placement.placement = hop;
>
> /* find space in the bounce domain */
> ret = ttm_bo_mem_space(bo, &hop_placement, &hop_mem, ctx);
> @@ -440,10 +440,9 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
> dma_resv_assert_held(bo->base.resv);
>
> placement.num_placement = 0;
> - placement.num_busy_placement = 0;
> bdev->funcs->evict_flags(bo, &placement);
>
> - if (!placement.num_placement && !placement.num_busy_placement) {
> + if (!placement.num_placement) {
> ret = ttm_bo_wait_ctx(bo, ctx);
> if (ret)
> return ret;
> @@ -791,6 +790,9 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
> const struct ttm_place *place = &placement->placement[i];
> struct ttm_resource_manager *man;
>
> + if (place->flags & TTM_PL_FLAG_BUSY)
> + continue;
> +
> man = ttm_manager_type(bdev, place->mem_type);
> if (!man || !ttm_resource_manager_used(man))
> continue;
> @@ -813,10 +815,13 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
> return 0;
> }
>
> - for (i = 0; i < placement->num_busy_placement; ++i) {
> - const struct ttm_place *place = &placement->busy_placement[i];
> + for (i = 0; i < placement->num_placement; ++i) {
> + const struct ttm_place *place = &placement->placement[i];
> struct ttm_resource_manager *man;
>
> + if (place->flags & TTM_PL_FLAG_IDLE)
> + continue;
> +
> man = ttm_manager_type(bdev, place->mem_type);
> if (!man || !ttm_resource_manager_used(man))
> continue;
> @@ -904,11 +909,11 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
> /*
> * Remove the backing store if no placement is given.
> */
> - if (!placement->num_placement && !placement->num_busy_placement)
> + if (!placement->num_placement)
> return ttm_bo_pipeline_gutting(bo);
>
> /* Check whether we need to move buffer. */
> - if (bo->resource && ttm_resource_compat(bo->resource, placement))
> + if (bo->resource && ttm_resource_compatible(bo->resource, placement))
> return 0;
>
> /* Moving of pinned BOs is forbidden */
> diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
> index 02b96d23fdb9..fb14f7716cf8 100644
> --- a/drivers/gpu/drm/ttm/ttm_resource.c
> +++ b/drivers/gpu/drm/ttm/ttm_resource.c
> @@ -291,37 +291,15 @@ bool ttm_resource_intersects(struct ttm_device *bdev,
> }
>
> /**
> - * ttm_resource_compatible - test for compatibility
> + * ttm_resource_compatible - check if resource is compatible with placement
> *
> - * @bdev: TTM device structure
> - * @res: The resource to test
> - * @place: The placement to test
> - * @size: How many bytes the new allocation needs.
> - *
> - * Test if @res compatible with @place and @size.
> + * @res: the resource to check
> + * @placement: the placement to check against
> *
> - * Returns true if the res placement compatible with @place and @size.
> + * Returns true if the placement is compatible.
> */
> -bool ttm_resource_compatible(struct ttm_device *bdev,
> - struct ttm_resource *res,
> - const struct ttm_place *place,
> - size_t size)
> -{
> - struct ttm_resource_manager *man;
> -
> - if (!res || !place)
> - return false;
> -
> - man = ttm_manager_type(bdev, res->mem_type);
> - if (!man->func->compatible)
> - return true;
> -
> - return man->func->compatible(man, res, place, size);
> -}
> -
> -static bool ttm_resource_places_compat(struct ttm_resource *res,
> - const struct ttm_place *places,
> - unsigned num_placement)
> +bool ttm_resource_compatible(struct ttm_resource *res,
> + struct ttm_placement *placement)
> {
> struct ttm_buffer_object *bo = res->bo;
> struct ttm_device *bdev = bo->bdev;
> @@ -330,44 +308,25 @@ static bool ttm_resource_places_compat(struct ttm_resource *res,
> if (res->placement & TTM_PL_FLAG_TEMPORARY)
> return false;
>
> - for (i = 0; i < num_placement; i++) {
> - const struct ttm_place *heap = &places[i];
> + for (i = 0; i < placement->num_placement; i++) {
> + const struct ttm_place *place = &placement->placement[i];
> + struct ttm_resource_manager *man;
>
> - if (!ttm_resource_compatible(bdev, res, heap, bo->base.size))
> + if (res->mem_type != place->mem_type)
> + continue;
> +
> + man = ttm_manager_type(bdev, res->mem_type);
> + if (man->func->compatible &&
> + !man->func->compatible(man, res, place, bo->base.size))
> continue;
>
> - if ((res->mem_type == heap->mem_type) &&
> - (!(heap->flags & TTM_PL_FLAG_CONTIGUOUS) ||
> + if ((!(place->flags & TTM_PL_FLAG_CONTIGUOUS) ||
> (res->placement & TTM_PL_FLAG_CONTIGUOUS)))
> return true;
> }
> return false;
> }
>
> -/**
> - * ttm_resource_compat - check if resource is compatible with placement
> - *
> - * @res: the resource to check
> - * @placement: the placement to check against
> - *
> - * Returns true if the placement is compatible.
> - */
> -bool ttm_resource_compat(struct ttm_resource *res,
> - struct ttm_placement *placement)
> -{
> - if (ttm_resource_places_compat(res, placement->placement,
> - placement->num_placement))
> - return true;
> -
> - if ((placement->busy_placement != placement->placement ||
> - placement->num_busy_placement > placement->num_placement) &&
> - ttm_resource_places_compat(res, placement->busy_placement,
> - placement->num_busy_placement))
> - return true;
> -
> - return false;
> -}
> -
> void ttm_resource_set_bo(struct ttm_resource *res,
> struct ttm_buffer_object *bo)
> {
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> index 2bfac3aad7b7..7d7b33fcb5cf 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> @@ -821,8 +821,6 @@ void vmw_bo_placement_set(struct vmw_bo *bo, u32 domain, u32 busy_domain)
> __func__, bo->tbo.resource->mem_type, domain);
> }
>
> - pl->busy_placement = bo->busy_places;
> - pl->num_busy_placement = set_placement_list(bo->busy_places, busy_domain);
> }
>
The busy_domain argument is unused now. There's no point in keeping it.
> void vmw_bo_placement_set_default_accelerated(struct vmw_bo *bo)
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> index af8562c95cc3..e243c9266453 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> @@ -36,6 +36,49 @@ static const struct ttm_place vram_placement_flags = {
> .flags = 0
> };
>
> +struct ttm_placement vmw_vram_placement = {
> + .num_placement = 1,
> + .placement = &vram_placement_flags,
> +};
> +
> +static const struct ttm_place vram_gmr_placement_flags[] = {
> + {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = TTM_PL_VRAM,
> + .flags = TTM_PL_FLAG_IDLE
> + }, {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = VMW_PL_GMR,
> + .flags = 0
> + }
> +};
> +
> +struct ttm_placement vmw_vram_gmr_placement = {
> + .num_placement = 2,
> + .placement = vram_gmr_placement_flags,
> +};
> +
> +static const struct ttm_place vram_sys_placement_flags[] = {
> + {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = TTM_PL_VRAM,
> + .flags = TTM_PL_FLAG_IDLE
> + }, {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = TTM_PL_SYSTEM,
> + .flags = TTM_PL_FLAG_BUSY
> + }
> +};
> +
> +struct ttm_placement vmw_vram_sys_placement = {
> + .num_placement = 2,
> + .placement = vram_sys_placement_flags,
> +};
> +
> static const struct ttm_place sys_placement_flags = {
> .fpfn = 0,
> .lpfn = 0,
> @@ -43,46 +86,64 @@ static const struct ttm_place sys_placement_flags = {
> .flags = 0
> };
>
> -static const struct ttm_place gmr_placement_flags = {
> +struct ttm_placement vmw_sys_placement = {
> + .num_placement = 1,
> + .placement = &sys_placement_flags,
> +};
> +
> +static const struct ttm_place vmw_sys_placement_flags = {
> .fpfn = 0,
> .lpfn = 0,
> - .mem_type = VMW_PL_GMR,
> + .mem_type = VMW_PL_SYSTEM,
> .flags = 0
> };
>
> -struct ttm_placement vmw_vram_placement = {
> +struct ttm_placement vmw_pt_sys_placement = {
> .num_placement = 1,
> - .placement = &vram_placement_flags,
> - .num_busy_placement = 1,
> - .busy_placement = &vram_placement_flags
> + .placement = &vmw_sys_placement_flags,
> };
>
> -static const struct ttm_place vram_gmr_placement_flags[] = {
> +static const struct ttm_place gmr_vram_placement_flags[] = {
> {
> .fpfn = 0,
> .lpfn = 0,
> - .mem_type = TTM_PL_VRAM,
> + .mem_type = VMW_PL_GMR,
> .flags = 0
> }, {
> .fpfn = 0,
> .lpfn = 0,
> - .mem_type = VMW_PL_GMR,
> - .flags = 0
> + .mem_type = TTM_PL_VRAM,
> + .flags = TTM_PL_FLAG_BUSY
> }
> };
>
> -struct ttm_placement vmw_vram_gmr_placement = {
> +struct ttm_placement vmw_srf_placement = {
> .num_placement = 2,
> - .placement = vram_gmr_placement_flags,
> - .num_busy_placement = 1,
> - .busy_placement = &gmr_placement_flags
> + .placement = gmr_vram_placement_flags
> };
>
> -struct ttm_placement vmw_sys_placement = {
> - .num_placement = 1,
> - .placement = &sys_placement_flags,
> - .num_busy_placement = 1,
> - .busy_placement = &sys_placement_flags
> +static const struct ttm_place nonfixed_placement_flags[] = {
> + {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = TTM_PL_SYSTEM,
> + .flags = 0
> + }, {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = VMW_PL_GMR,
> + .flags = TTM_PL_FLAG_IDLE
> + }, {
> + .fpfn = 0,
> + .lpfn = 0,
> + .mem_type = VMW_PL_MOB,
> + .flags = TTM_PL_FLAG_IDLE
> + }
> +};
> +
> +struct ttm_placement vmw_nonfixed_placement = {
> + .num_placement = 3,
> + .placement = nonfixed_placement_flags,
> };
That looks incorrect. vmwgfx doesn't have or use most of those, e.g.
vmw_nonfixed_placement or vmw_pt_sys_placement . They were removed
about a year ago, which is, I guess, when this series started and the
change was never updated.
z
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] drm/ttm: replace busy placement with flags v4
2024-01-04 20:02 ` Zack Rusin
@ 2024-01-05 12:27 ` Christian König
0 siblings, 0 replies; 11+ messages in thread
From: Christian König @ 2024-01-05 12:27 UTC (permalink / raw)
To: Zack Rusin
Cc: thomas.hellstrom, kherbst, nouveau, intel-gfx, dri-devel, zackr
Am 04.01.24 um 21:02 schrieb Zack Rusin:
> On Thu, Jan 4, 2024 at 10:05 AM Christian König
> <ckoenig.leichtzumerken@gmail.com> wrote:
>> From: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
>>
>> Instead of a list of separate busy placement add flags which indicate
>> that a placement should only be used when there is room or if we need to
>> evict.
>>
>> v2: add missing TTM_PL_FLAG_IDLE for i915
>> v3: fix auto build test ERROR on drm-tip/drm-tip
>> v4: fix some typos pointed out by checkpatch
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Signed-off-by: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +-
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 +--
>> drivers/gpu/drm/drm_gem_vram_helper.c | 2 -
>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 37 ++++----
>> drivers/gpu/drm/loongson/lsdc_ttm.c | 2 -
>> drivers/gpu/drm/nouveau/nouveau_bo.c | 59 +++++--------
>> drivers/gpu/drm/nouveau/nouveau_bo.h | 1 -
>> drivers/gpu/drm/qxl/qxl_object.c | 2 -
>> drivers/gpu/drm/qxl/qxl_ttm.c | 2 -
>> drivers/gpu/drm/radeon/radeon_object.c | 2 -
>> drivers/gpu/drm/radeon/radeon_ttm.c | 8 +-
>> drivers/gpu/drm/radeon/radeon_uvd.c | 1 -
>> drivers/gpu/drm/ttm/ttm_bo.c | 21 +++--
>> drivers/gpu/drm/ttm/ttm_resource.c | 73 ++++------------
>> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 -
>> drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 99 +++++++++++++++++-----
>> include/drm/ttm/ttm_placement.h | 10 ++-
>> include/drm/ttm/ttm_resource.h | 8 +-
>> 18 files changed, 159 insertions(+), 187 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index cef920a93924..aa0dd6dad068 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -220,9 +220,6 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
>>
>> placement->num_placement = c;
>> placement->placement = places;
>> -
>> - placement->num_busy_placement = c;
>> - placement->busy_placement = places;
>> }
>>
>> /**
>> @@ -1406,8 +1403,7 @@ vm_fault_t amdgpu_bo_fault_reserve_notify(struct ttm_buffer_object *bo)
>> AMDGPU_GEM_DOMAIN_GTT);
>>
>> /* Avoid costly evictions; only set GTT as a busy placement */
>> - abo->placement.num_busy_placement = 1;
>> - abo->placement.busy_placement = &abo->placements[1];
>> + abo->placements[0].flags |= TTM_PL_FLAG_IDLE;
>>
>> r = ttm_bo_validate(bo, &abo->placement, &ctx);
>> if (unlikely(r == -EBUSY || r == -ERESTARTSYS))
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> index 05991c5c8ddb..9a6a00b1af40 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> @@ -102,23 +102,19 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
>> /* Don't handle scatter gather BOs */
>> if (bo->type == ttm_bo_type_sg) {
>> placement->num_placement = 0;
>> - placement->num_busy_placement = 0;
>> return;
>> }
>>
>> /* Object isn't an AMDGPU object so ignore */
>> if (!amdgpu_bo_is_amdgpu_bo(bo)) {
>> placement->placement = &placements;
>> - placement->busy_placement = &placements;
>> placement->num_placement = 1;
>> - placement->num_busy_placement = 1;
>> return;
>> }
>>
>> abo = ttm_to_amdgpu_bo(bo);
>> if (abo->flags & AMDGPU_GEM_CREATE_DISCARDABLE) {
>> placement->num_placement = 0;
>> - placement->num_busy_placement = 0;
>> return;
>> }
>>
>> @@ -128,13 +124,13 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
>> case AMDGPU_PL_OA:
>> case AMDGPU_PL_DOORBELL:
>> placement->num_placement = 0;
>> - placement->num_busy_placement = 0;
>> return;
>>
>> case TTM_PL_VRAM:
>> if (!adev->mman.buffer_funcs_enabled) {
>> /* Move to system memory */
>> amdgpu_bo_placement_from_domain(abo, AMDGPU_GEM_DOMAIN_CPU);
>> +
>> } else if (!amdgpu_gmc_vram_full_visible(&adev->gmc) &&
>> !(abo->flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) &&
>> amdgpu_bo_in_cpu_visible_vram(abo)) {
>> @@ -149,8 +145,7 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo,
>> AMDGPU_GEM_DOMAIN_CPU);
>> abo->placements[0].fpfn = adev->gmc.visible_vram_size >> PAGE_SHIFT;
>> abo->placements[0].lpfn = 0;
>> - abo->placement.busy_placement = &abo->placements[1];
>> - abo->placement.num_busy_placement = 1;
>> + abo->placements[0].flags |= TTM_PL_FLAG_IDLE;
>> } else {
>> /* Move to GTT memory */
>> amdgpu_bo_placement_from_domain(abo, AMDGPU_GEM_DOMAIN_GTT |
>> @@ -967,8 +962,6 @@ int amdgpu_ttm_alloc_gart(struct ttm_buffer_object *bo)
>> /* allocate GART space */
>> placement.num_placement = 1;
>> placement.placement = &placements;
>> - placement.num_busy_placement = 1;
>> - placement.busy_placement = &placements;
>> placements.fpfn = 0;
>> placements.lpfn = adev->gmc.gart_size >> PAGE_SHIFT;
>> placements.mem_type = TTM_PL_TT;
>> diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
>> index b67eafa55715..75f2eaf0d5b6 100644
>> --- a/drivers/gpu/drm/drm_gem_vram_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
>> @@ -147,7 +147,6 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
>> invariant_flags = TTM_PL_FLAG_TOPDOWN;
>>
>> gbo->placement.placement = gbo->placements;
>> - gbo->placement.busy_placement = gbo->placements;
>>
>> if (pl_flag & DRM_GEM_VRAM_PL_FLAG_VRAM) {
>> gbo->placements[c].mem_type = TTM_PL_VRAM;
>> @@ -160,7 +159,6 @@ static void drm_gem_vram_placement(struct drm_gem_vram_object *gbo,
>> }
>>
>> gbo->placement.num_placement = c;
>> - gbo->placement.num_busy_placement = c;
>>
>> for (i = 0; i < c; ++i) {
>> gbo->placements[i].fpfn = 0;
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> index 9227f8146a58..48fc9779fd50 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> @@ -65,8 +65,6 @@ static const struct ttm_place sys_placement_flags = {
>> static struct ttm_placement i915_sys_placement = {
>> .num_placement = 1,
>> .placement = &sys_placement_flags,
>> - .num_busy_placement = 1,
>> - .busy_placement = &sys_placement_flags,
>> };
>>
>> /**
>> @@ -157,32 +155,28 @@ i915_ttm_place_from_region(const struct intel_memory_region *mr,
>>
>> static void
>> i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
>> - struct ttm_place *requested,
>> - struct ttm_place *busy,
>> + struct ttm_place *places,
>> struct ttm_placement *placement)
>> {
>> unsigned int num_allowed = obj->mm.n_placements;
>> unsigned int flags = obj->flags;
>> unsigned int i;
>>
>> - placement->num_placement = 1;
>> + places[0].flags |= TTM_PL_FLAG_IDLE;
>> i915_ttm_place_from_region(num_allowed ? obj->mm.placements[0] :
>> - obj->mm.region, requested, obj->bo_offset,
>> + obj->mm.region, &places[0], obj->bo_offset,
>> obj->base.size, flags);
>>
>> /* Cache this on object? */
>> - placement->num_busy_placement = num_allowed;
>> - for (i = 0; i < placement->num_busy_placement; ++i)
>> - i915_ttm_place_from_region(obj->mm.placements[i], busy + i,
>> - obj->bo_offset, obj->base.size, flags);
>> -
>> - if (num_allowed == 0) {
>> - *busy = *requested;
>> - placement->num_busy_placement = 1;
>> + for (i = 0; i < num_allowed; ++i) {
>> + i915_ttm_place_from_region(obj->mm.placements[i],
>> + &places[i + 1], obj->bo_offset,
>> + obj->base.size, flags);
>> + places[i + 1].flags |= TTM_PL_FLAG_BUSY;
>> }
>>
>> - placement->placement = requested;
>> - placement->busy_placement = busy;
>> + placement->num_placement = num_allowed + 1;
>> + placement->placement = places;
>> }
>>
>> static int i915_ttm_tt_shmem_populate(struct ttm_device *bdev,
>> @@ -789,7 +783,8 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
>> int ret;
>>
>> /* First try only the requested placement. No eviction. */
>> - real_num_busy = fetch_and_zero(&placement->num_busy_placement);
>> + real_num_busy = placement->num_placement;
>> + placement->num_placement = 1;
>> ret = ttm_bo_validate(bo, placement, &ctx);
>> if (ret) {
>> ret = i915_ttm_err_to_gem(ret);
>> @@ -805,7 +800,7 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
>> * If the initial attempt fails, allow all accepted placements,
>> * evicting if necessary.
>> */
>> - placement->num_busy_placement = real_num_busy;
>> + placement->num_placement = real_num_busy;
>> ret = ttm_bo_validate(bo, placement, &ctx);
>> if (ret)
>> return i915_ttm_err_to_gem(ret);
>> @@ -839,7 +834,7 @@ static int __i915_ttm_get_pages(struct drm_i915_gem_object *obj,
>>
>> static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
>> {
>> - struct ttm_place requested, busy[I915_TTM_MAX_PLACEMENTS];
>> + struct ttm_place places[I915_TTM_MAX_PLACEMENTS + 1];
>> struct ttm_placement placement;
>>
>> /* restricted by sg_alloc_table */
>> @@ -849,7 +844,7 @@ static int i915_ttm_get_pages(struct drm_i915_gem_object *obj)
>> GEM_BUG_ON(obj->mm.n_placements > I915_TTM_MAX_PLACEMENTS);
>>
>> /* Move to the requested placement. */
>> - i915_ttm_placement_from_obj(obj, &requested, busy, &placement);
>> + i915_ttm_placement_from_obj(obj, places, &placement);
>>
>> return __i915_ttm_get_pages(obj, &placement);
>> }
>> @@ -879,9 +874,7 @@ static int __i915_ttm_migrate(struct drm_i915_gem_object *obj,
>> i915_ttm_place_from_region(mr, &requested, obj->bo_offset,
>> obj->base.size, flags);
>> placement.num_placement = 1;
>> - placement.num_busy_placement = 1;
>> placement.placement = &requested;
>> - placement.busy_placement = &requested;
>>
>> ret = __i915_ttm_get_pages(obj, &placement);
>> if (ret)
>> diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c
>> index bf79dc55afa4..465f622ac05d 100644
>> --- a/drivers/gpu/drm/loongson/lsdc_ttm.c
>> +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c
>> @@ -54,7 +54,6 @@ static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
>> pflags |= TTM_PL_FLAG_TOPDOWN;
>>
>> lbo->placement.placement = lbo->placements;
>> - lbo->placement.busy_placement = lbo->placements;
>>
>> if (domain & LSDC_GEM_DOMAIN_VRAM) {
>> lbo->placements[c].mem_type = TTM_PL_VRAM;
>> @@ -77,7 +76,6 @@ static void lsdc_bo_set_placement(struct lsdc_bo *lbo, u32 domain)
>> }
>>
>> lbo->placement.num_placement = c;
>> - lbo->placement.num_busy_placement = c;
>>
>> for (i = 0; i < c; ++i) {
>> lbo->placements[i].fpfn = 0;
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
>> index b7dda486a7ea..575875b6e47e 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
>> @@ -403,27 +403,6 @@ nouveau_bo_new(struct nouveau_cli *cli, u64 size, int align,
>> return 0;
>> }
>>
>> -static void
>> -set_placement_list(struct ttm_place *pl, unsigned *n, uint32_t domain)
>> -{
>> - *n = 0;
>> -
>> - if (domain & NOUVEAU_GEM_DOMAIN_VRAM) {
>> - pl[*n].mem_type = TTM_PL_VRAM;
>> - pl[*n].flags = 0;
>> - (*n)++;
>> - }
>> - if (domain & NOUVEAU_GEM_DOMAIN_GART) {
>> - pl[*n].mem_type = TTM_PL_TT;
>> - pl[*n].flags = 0;
>> - (*n)++;
>> - }
>> - if (domain & NOUVEAU_GEM_DOMAIN_CPU) {
>> - pl[*n].mem_type = TTM_PL_SYSTEM;
>> - pl[(*n)++].flags = 0;
>> - }
>> -}
>> -
>> static void
>> set_placement_range(struct nouveau_bo *nvbo, uint32_t domain)
>> {
>> @@ -451,10 +430,6 @@ set_placement_range(struct nouveau_bo *nvbo, uint32_t domain)
>> nvbo->placements[i].fpfn = fpfn;
>> nvbo->placements[i].lpfn = lpfn;
>> }
>> - for (i = 0; i < nvbo->placement.num_busy_placement; ++i) {
>> - nvbo->busy_placements[i].fpfn = fpfn;
>> - nvbo->busy_placements[i].lpfn = lpfn;
>> - }
>> }
>> }
>>
>> @@ -462,15 +437,32 @@ void
>> nouveau_bo_placement_set(struct nouveau_bo *nvbo, uint32_t domain,
>> uint32_t busy)
>> {
>> - struct ttm_placement *pl = &nvbo->placement;
>> + unsigned int *n = &nvbo->placement.num_placement;
>> + struct ttm_place *pl = nvbo->placements;
>>
>> - pl->placement = nvbo->placements;
>> - set_placement_list(nvbo->placements, &pl->num_placement, domain);
>> + domain |= busy;
>>
>> - pl->busy_placement = nvbo->busy_placements;
>> - set_placement_list(nvbo->busy_placements, &pl->num_busy_placement,
>> - domain | busy);
>> + *n = 0;
>> + if (domain & NOUVEAU_GEM_DOMAIN_VRAM) {
>> + pl[*n].mem_type = TTM_PL_VRAM;
>> + pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_VRAM ?
>> + TTM_PL_FLAG_BUSY : 0;
>> + (*n)++;
>> + }
>> + if (domain & NOUVEAU_GEM_DOMAIN_GART) {
>> + pl[*n].mem_type = TTM_PL_TT;
>> + pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_GART ?
>> + TTM_PL_FLAG_BUSY : 0;
>> + (*n)++;
>> + }
>> + if (domain & NOUVEAU_GEM_DOMAIN_CPU) {
>> + pl[*n].mem_type = TTM_PL_SYSTEM;
>> + pl[*n].flags = busy & NOUVEAU_GEM_DOMAIN_CPU ?
>> + TTM_PL_FLAG_BUSY : 0;
>> + (*n)++;
>> + }
>>
>> + nvbo->placement.placement = nvbo->placements;
>> set_placement_range(nvbo, domain);
>> }
>>
>> @@ -1313,11 +1305,6 @@ vm_fault_t nouveau_ttm_fault_reserve_notify(struct ttm_buffer_object *bo)
>> nvbo->placements[i].lpfn = mappable;
>> }
>>
>> - for (i = 0; i < nvbo->placement.num_busy_placement; ++i) {
>> - nvbo->busy_placements[i].fpfn = 0;
>> - nvbo->busy_placements[i].lpfn = mappable;
>> - }
>> -
>> nouveau_bo_placement_set(nvbo, NOUVEAU_GEM_DOMAIN_VRAM, 0);
>> }
>>
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.h b/drivers/gpu/drm/nouveau/nouveau_bo.h
>> index 70c551921a9e..e9dfab6a8156 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_bo.h
>> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.h
>> @@ -15,7 +15,6 @@ struct nouveau_bo {
>> struct ttm_placement placement;
>> u32 valid_domains;
>> struct ttm_place placements[3];
>> - struct ttm_place busy_placements[3];
>> bool force_coherent;
>> struct ttm_bo_kmap_obj kmap;
>> struct list_head head;
>> diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
>> index 06a58dad5f5c..1e46b0a6e478 100644
>> --- a/drivers/gpu/drm/qxl/qxl_object.c
>> +++ b/drivers/gpu/drm/qxl/qxl_object.c
>> @@ -66,7 +66,6 @@ void qxl_ttm_placement_from_domain(struct qxl_bo *qbo, u32 domain)
>> pflag |= TTM_PL_FLAG_TOPDOWN;
>>
>> qbo->placement.placement = qbo->placements;
>> - qbo->placement.busy_placement = qbo->placements;
>> if (domain == QXL_GEM_DOMAIN_VRAM) {
>> qbo->placements[c].mem_type = TTM_PL_VRAM;
>> qbo->placements[c++].flags = pflag;
>> @@ -86,7 +85,6 @@ void qxl_ttm_placement_from_domain(struct qxl_bo *qbo, u32 domain)
>> qbo->placements[c++].flags = 0;
>> }
>> qbo->placement.num_placement = c;
>> - qbo->placement.num_busy_placement = c;
>> for (i = 0; i < c; ++i) {
>> qbo->placements[i].fpfn = 0;
>> qbo->placements[i].lpfn = 0;
>> diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
>> index 1a82629bce3f..765a144cea14 100644
>> --- a/drivers/gpu/drm/qxl/qxl_ttm.c
>> +++ b/drivers/gpu/drm/qxl/qxl_ttm.c
>> @@ -60,9 +60,7 @@ static void qxl_evict_flags(struct ttm_buffer_object *bo,
>>
>> if (!qxl_ttm_bo_is_qxl_bo(bo)) {
>> placement->placement = &placements;
>> - placement->busy_placement = &placements;
>> placement->num_placement = 1;
>> - placement->num_busy_placement = 1;
>> return;
>> }
>> qbo = to_qxl_bo(bo);
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
>> index 10c0fbd9d2b4..a955f8a2f7fe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -78,7 +78,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
>> u32 c = 0, i;
>>
>> rbo->placement.placement = rbo->placements;
>> - rbo->placement.busy_placement = rbo->placements;
>> if (domain & RADEON_GEM_DOMAIN_VRAM) {
>> /* Try placing BOs which don't need CPU access outside of the
>> * CPU accessible part of VRAM
>> @@ -114,7 +113,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
>> }
>>
>> rbo->placement.num_placement = c;
>> - rbo->placement.num_busy_placement = c;
>>
>> for (i = 0; i < c; ++i) {
>> if ((rbo->flags & RADEON_GEM_CPU_ACCESS) &&
>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>> index de4e6d78f1e1..d641f3040117 100644
>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>> @@ -92,9 +92,7 @@ static void radeon_evict_flags(struct ttm_buffer_object *bo,
>>
>> if (!radeon_ttm_bo_is_radeon_bo(bo)) {
>> placement->placement = &placements;
>> - placement->busy_placement = &placements;
>> placement->num_placement = 1;
>> - placement->num_busy_placement = 1;
>> return;
>> }
>> rbo = container_of(bo, struct radeon_bo, tbo);
>> @@ -114,15 +112,11 @@ static void radeon_evict_flags(struct ttm_buffer_object *bo,
>> */
>> radeon_ttm_placement_from_domain(rbo, RADEON_GEM_DOMAIN_VRAM |
>> RADEON_GEM_DOMAIN_GTT);
>> - rbo->placement.num_busy_placement = 0;
>> for (i = 0; i < rbo->placement.num_placement; i++) {
>> if (rbo->placements[i].mem_type == TTM_PL_VRAM) {
>> if (rbo->placements[i].fpfn < fpfn)
>> rbo->placements[i].fpfn = fpfn;
>> - } else {
>> - rbo->placement.busy_placement =
>> - &rbo->placements[i];
>> - rbo->placement.num_busy_placement = 1;
>> + rbo->placements[0].flags |= TTM_PL_FLAG_IDLE;
>> }
>> }
>> } else
>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
>> index a2cda184b2b2..058a1c8451b2 100644
>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
>> @@ -324,7 +324,6 @@ void radeon_uvd_force_into_uvd_segment(struct radeon_bo *rbo,
>> rbo->placements[1].fpfn += (256 * 1024 * 1024) >> PAGE_SHIFT;
>> rbo->placements[1].lpfn += (256 * 1024 * 1024) >> PAGE_SHIFT;
>> rbo->placement.num_placement++;
>> - rbo->placement.num_busy_placement++;
>> }
>>
>> void radeon_uvd_free_handles(struct radeon_device *rdev, struct drm_file *filp)
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
>> index 8c1eaa74fa21..aa12bd5cfd17 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -410,8 +410,8 @@ static int ttm_bo_bounce_temp_buffer(struct ttm_buffer_object *bo,
>> struct ttm_resource *hop_mem;
>> int ret;
>>
>> - hop_placement.num_placement = hop_placement.num_busy_placement = 1;
>> - hop_placement.placement = hop_placement.busy_placement = hop;
>> + hop_placement.num_placement = 1;
>> + hop_placement.placement = hop;
>>
>> /* find space in the bounce domain */
>> ret = ttm_bo_mem_space(bo, &hop_placement, &hop_mem, ctx);
>> @@ -440,10 +440,9 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
>> dma_resv_assert_held(bo->base.resv);
>>
>> placement.num_placement = 0;
>> - placement.num_busy_placement = 0;
>> bdev->funcs->evict_flags(bo, &placement);
>>
>> - if (!placement.num_placement && !placement.num_busy_placement) {
>> + if (!placement.num_placement) {
>> ret = ttm_bo_wait_ctx(bo, ctx);
>> if (ret)
>> return ret;
>> @@ -791,6 +790,9 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
>> const struct ttm_place *place = &placement->placement[i];
>> struct ttm_resource_manager *man;
>>
>> + if (place->flags & TTM_PL_FLAG_BUSY)
>> + continue;
>> +
>> man = ttm_manager_type(bdev, place->mem_type);
>> if (!man || !ttm_resource_manager_used(man))
>> continue;
>> @@ -813,10 +815,13 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo,
>> return 0;
>> }
>>
>> - for (i = 0; i < placement->num_busy_placement; ++i) {
>> - const struct ttm_place *place = &placement->busy_placement[i];
>> + for (i = 0; i < placement->num_placement; ++i) {
>> + const struct ttm_place *place = &placement->placement[i];
>> struct ttm_resource_manager *man;
>>
>> + if (place->flags & TTM_PL_FLAG_IDLE)
>> + continue;
>> +
>> man = ttm_manager_type(bdev, place->mem_type);
>> if (!man || !ttm_resource_manager_used(man))
>> continue;
>> @@ -904,11 +909,11 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
>> /*
>> * Remove the backing store if no placement is given.
>> */
>> - if (!placement->num_placement && !placement->num_busy_placement)
>> + if (!placement->num_placement)
>> return ttm_bo_pipeline_gutting(bo);
>>
>> /* Check whether we need to move buffer. */
>> - if (bo->resource && ttm_resource_compat(bo->resource, placement))
>> + if (bo->resource && ttm_resource_compatible(bo->resource, placement))
>> return 0;
>>
>> /* Moving of pinned BOs is forbidden */
>> diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
>> index 02b96d23fdb9..fb14f7716cf8 100644
>> --- a/drivers/gpu/drm/ttm/ttm_resource.c
>> +++ b/drivers/gpu/drm/ttm/ttm_resource.c
>> @@ -291,37 +291,15 @@ bool ttm_resource_intersects(struct ttm_device *bdev,
>> }
>>
>> /**
>> - * ttm_resource_compatible - test for compatibility
>> + * ttm_resource_compatible - check if resource is compatible with placement
>> *
>> - * @bdev: TTM device structure
>> - * @res: The resource to test
>> - * @place: The placement to test
>> - * @size: How many bytes the new allocation needs.
>> - *
>> - * Test if @res compatible with @place and @size.
>> + * @res: the resource to check
>> + * @placement: the placement to check against
>> *
>> - * Returns true if the res placement compatible with @place and @size.
>> + * Returns true if the placement is compatible.
>> */
>> -bool ttm_resource_compatible(struct ttm_device *bdev,
>> - struct ttm_resource *res,
>> - const struct ttm_place *place,
>> - size_t size)
>> -{
>> - struct ttm_resource_manager *man;
>> -
>> - if (!res || !place)
>> - return false;
>> -
>> - man = ttm_manager_type(bdev, res->mem_type);
>> - if (!man->func->compatible)
>> - return true;
>> -
>> - return man->func->compatible(man, res, place, size);
>> -}
>> -
>> -static bool ttm_resource_places_compat(struct ttm_resource *res,
>> - const struct ttm_place *places,
>> - unsigned num_placement)
>> +bool ttm_resource_compatible(struct ttm_resource *res,
>> + struct ttm_placement *placement)
>> {
>> struct ttm_buffer_object *bo = res->bo;
>> struct ttm_device *bdev = bo->bdev;
>> @@ -330,44 +308,25 @@ static bool ttm_resource_places_compat(struct ttm_resource *res,
>> if (res->placement & TTM_PL_FLAG_TEMPORARY)
>> return false;
>>
>> - for (i = 0; i < num_placement; i++) {
>> - const struct ttm_place *heap = &places[i];
>> + for (i = 0; i < placement->num_placement; i++) {
>> + const struct ttm_place *place = &placement->placement[i];
>> + struct ttm_resource_manager *man;
>>
>> - if (!ttm_resource_compatible(bdev, res, heap, bo->base.size))
>> + if (res->mem_type != place->mem_type)
>> + continue;
>> +
>> + man = ttm_manager_type(bdev, res->mem_type);
>> + if (man->func->compatible &&
>> + !man->func->compatible(man, res, place, bo->base.size))
>> continue;
>>
>> - if ((res->mem_type == heap->mem_type) &&
>> - (!(heap->flags & TTM_PL_FLAG_CONTIGUOUS) ||
>> + if ((!(place->flags & TTM_PL_FLAG_CONTIGUOUS) ||
>> (res->placement & TTM_PL_FLAG_CONTIGUOUS)))
>> return true;
>> }
>> return false;
>> }
>>
>> -/**
>> - * ttm_resource_compat - check if resource is compatible with placement
>> - *
>> - * @res: the resource to check
>> - * @placement: the placement to check against
>> - *
>> - * Returns true if the placement is compatible.
>> - */
>> -bool ttm_resource_compat(struct ttm_resource *res,
>> - struct ttm_placement *placement)
>> -{
>> - if (ttm_resource_places_compat(res, placement->placement,
>> - placement->num_placement))
>> - return true;
>> -
>> - if ((placement->busy_placement != placement->placement ||
>> - placement->num_busy_placement > placement->num_placement) &&
>> - ttm_resource_places_compat(res, placement->busy_placement,
>> - placement->num_busy_placement))
>> - return true;
>> -
>> - return false;
>> -}
>> -
>> void ttm_resource_set_bo(struct ttm_resource *res,
>> struct ttm_buffer_object *bo)
>> {
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> index 2bfac3aad7b7..7d7b33fcb5cf 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> @@ -821,8 +821,6 @@ void vmw_bo_placement_set(struct vmw_bo *bo, u32 domain, u32 busy_domain)
>> __func__, bo->tbo.resource->mem_type, domain);
>> }
>>
>> - pl->busy_placement = bo->busy_places;
>> - pl->num_busy_placement = set_placement_list(bo->busy_places, busy_domain);
>> }
>>
> The busy_domain argument is unused now. There's no point in keeping it.
>
>> void vmw_bo_placement_set_default_accelerated(struct vmw_bo *bo)
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
>> index af8562c95cc3..e243c9266453 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
>> @@ -36,6 +36,49 @@ static const struct ttm_place vram_placement_flags = {
>> .flags = 0
>> };
>>
>> +struct ttm_placement vmw_vram_placement = {
>> + .num_placement = 1,
>> + .placement = &vram_placement_flags,
>> +};
>> +
>> +static const struct ttm_place vram_gmr_placement_flags[] = {
>> + {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = TTM_PL_VRAM,
>> + .flags = TTM_PL_FLAG_IDLE
>> + }, {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = VMW_PL_GMR,
>> + .flags = 0
>> + }
>> +};
>> +
>> +struct ttm_placement vmw_vram_gmr_placement = {
>> + .num_placement = 2,
>> + .placement = vram_gmr_placement_flags,
>> +};
>> +
>> +static const struct ttm_place vram_sys_placement_flags[] = {
>> + {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = TTM_PL_VRAM,
>> + .flags = TTM_PL_FLAG_IDLE
>> + }, {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = TTM_PL_SYSTEM,
>> + .flags = TTM_PL_FLAG_BUSY
>> + }
>> +};
>> +
>> +struct ttm_placement vmw_vram_sys_placement = {
>> + .num_placement = 2,
>> + .placement = vram_sys_placement_flags,
>> +};
>> +
>> static const struct ttm_place sys_placement_flags = {
>> .fpfn = 0,
>> .lpfn = 0,
>> @@ -43,46 +86,64 @@ static const struct ttm_place sys_placement_flags = {
>> .flags = 0
>> };
>>
>> -static const struct ttm_place gmr_placement_flags = {
>> +struct ttm_placement vmw_sys_placement = {
>> + .num_placement = 1,
>> + .placement = &sys_placement_flags,
>> +};
>> +
>> +static const struct ttm_place vmw_sys_placement_flags = {
>> .fpfn = 0,
>> .lpfn = 0,
>> - .mem_type = VMW_PL_GMR,
>> + .mem_type = VMW_PL_SYSTEM,
>> .flags = 0
>> };
>>
>> -struct ttm_placement vmw_vram_placement = {
>> +struct ttm_placement vmw_pt_sys_placement = {
>> .num_placement = 1,
>> - .placement = &vram_placement_flags,
>> - .num_busy_placement = 1,
>> - .busy_placement = &vram_placement_flags
>> + .placement = &vmw_sys_placement_flags,
>> };
>>
>> -static const struct ttm_place vram_gmr_placement_flags[] = {
>> +static const struct ttm_place gmr_vram_placement_flags[] = {
>> {
>> .fpfn = 0,
>> .lpfn = 0,
>> - .mem_type = TTM_PL_VRAM,
>> + .mem_type = VMW_PL_GMR,
>> .flags = 0
>> }, {
>> .fpfn = 0,
>> .lpfn = 0,
>> - .mem_type = VMW_PL_GMR,
>> - .flags = 0
>> + .mem_type = TTM_PL_VRAM,
>> + .flags = TTM_PL_FLAG_BUSY
>> }
>> };
>>
>> -struct ttm_placement vmw_vram_gmr_placement = {
>> +struct ttm_placement vmw_srf_placement = {
>> .num_placement = 2,
>> - .placement = vram_gmr_placement_flags,
>> - .num_busy_placement = 1,
>> - .busy_placement = &gmr_placement_flags
>> + .placement = gmr_vram_placement_flags
>> };
>>
>> -struct ttm_placement vmw_sys_placement = {
>> - .num_placement = 1,
>> - .placement = &sys_placement_flags,
>> - .num_busy_placement = 1,
>> - .busy_placement = &sys_placement_flags
>> +static const struct ttm_place nonfixed_placement_flags[] = {
>> + {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = TTM_PL_SYSTEM,
>> + .flags = 0
>> + }, {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = VMW_PL_GMR,
>> + .flags = TTM_PL_FLAG_IDLE
>> + }, {
>> + .fpfn = 0,
>> + .lpfn = 0,
>> + .mem_type = VMW_PL_MOB,
>> + .flags = TTM_PL_FLAG_IDLE
>> + }
>> +};
>> +
>> +struct ttm_placement vmw_nonfixed_placement = {
>> + .num_placement = 3,
>> + .placement = nonfixed_placement_flags,
>> };
> That looks incorrect. vmwgfx doesn't have or use most of those, e.g.
> vmw_nonfixed_placement or vmw_pt_sys_placement . They were removed
> about a year ago, which is, I guess, when this series started and the
> change was never updated.
Oh, yeah that could be. Looks like we missed that while rebasing this patch.
Thanks for the notice,
Christian.
>
> z
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-01-05 12:27 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-04 15:05 Rework TTMs busy handling Christian König
2024-01-04 15:05 ` [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
2024-01-04 15:05 ` [PATCH 2/4] drm/ttm: replace busy placement with flags v4 Christian König
2024-01-04 20:02 ` Zack Rusin
2024-01-05 12:27 ` Christian König
2024-01-04 15:05 ` [PATCH 3/4] drm/ttm: improve idle/busy handling v2 Christian König
2024-01-04 15:05 ` [PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT Christian König
2024-01-04 15:39 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Patchwork
2024-01-04 15:39 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-04 15:55 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-04 17:04 ` ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox