* Re: [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource
2022-09-20 17:06 [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource Nirmoy Das
@ 2022-09-20 17:13 ` Matthew Auld
2022-09-21 7:52 ` Christian König
2022-09-20 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2022-09-20 17:13 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx
Cc: Christian König, dri-devel, Christian König
On 20/09/2022 18:06, Nirmoy Das wrote:
> For delayed BO release i915_ttm_delete_mem_notify()
> gets called twice, once with proper bo->resource and
> another time with NULL. We shouldn't do anything for
> the 2nd time as we already cleanedup the obj once.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6850
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Christian, as per above it looks like ttm calls into the
delete_mem_notify() hook twice if the object ends up on the delayed
destroy list, is that expected/normal?
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 0544b0a4a43a..e3fc38dd5db0 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -511,7 +511,7 @@ static void i915_ttm_delete_mem_notify(struct ttm_buffer_object *bo)
> struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
> intel_wakeref_t wakeref = 0;
>
> - if (likely(obj)) {
> + if (bo->resource && likely(obj)) {
> /* ttm_bo_release() already has dma_resv_lock */
> if (i915_ttm_cpu_maps_iomem(bo->resource))
> wakeref = intel_runtime_pm_get(&to_i915(obj->base.dev)->runtime_pm);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource
2022-09-20 17:13 ` Matthew Auld
@ 2022-09-21 7:52 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2022-09-21 7:52 UTC (permalink / raw)
To: Matthew Auld, Nirmoy Das, intel-gfx; +Cc: Christian König, dri-devel
Am 20.09.22 um 19:13 schrieb Matthew Auld:
> On 20/09/2022 18:06, Nirmoy Das wrote:
>> For delayed BO release i915_ttm_delete_mem_notify()
>> gets called twice, once with proper bo->resource and
>> another time with NULL. We shouldn't do anything for
>> the 2nd time as we already cleanedup the obj once.
>>
>> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6850
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Christian, as per above it looks like ttm calls into the
> delete_mem_notify() hook twice if the object ends up on the delayed
> destroy list, is that expected/normal?
Yeah, that's expected. IIRC some driver depended on this for some reason.
I already wanted to change this behavior, but forgot to do so after the
patch set which made bo->resource a pointer landed.
Going to look into it once more.
Thanks,
Christian.
>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> index 0544b0a4a43a..e3fc38dd5db0 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> @@ -511,7 +511,7 @@ static void i915_ttm_delete_mem_notify(struct
>> ttm_buffer_object *bo)
>> struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
>> intel_wakeref_t wakeref = 0;
>> - if (likely(obj)) {
>> + if (bo->resource && likely(obj)) {
>> /* ttm_bo_release() already has dma_resv_lock */
>> if (i915_ttm_cpu_maps_iomem(bo->resource))
>> wakeref =
>> intel_runtime_pm_get(&to_i915(obj->base.dev)->runtime_pm);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not cleanup obj with NULL bo->resource
2022-09-20 17:06 [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource Nirmoy Das
2022-09-20 17:13 ` Matthew Auld
@ 2022-09-20 17:53 ` Patchwork
2022-09-20 23:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-21 8:27 ` [Intel-gfx] [PATCH] " Das, Nirmoy
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-09-20 17:53 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10421 bytes --]
== Series Details ==
Series: drm/i915: Do not cleanup obj with NULL bo->resource
URL : https://patchwork.freedesktop.org/series/108792/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12161 -> Patchwork_108792v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/index.html
Participating hosts (44 -> 42)
------------------------------
Additional (1): fi-rkl-11600
Missing (3): fi-ctg-p8600 fi-hsw-4770 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_108792v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-bdw-gvtdvm: NOTRUN -> [SKIP][2] ([fdo#109271]) +19 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-bdw-gvtdvm/igt@gem_lmem_swapping@basic.html
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#3012])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][6] -> [DMESG-FAIL][7] ([i915#62])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [PASS][8] -> [DMESG-WARN][9] ([i915#5904]) +30 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [PASS][10] -> [DMESG-WARN][11] ([i915#5904] / [i915#62])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][12] ([i915#4817])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-bdw-gvtdvm/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][13] ([i915#5982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([fdo#111827]) +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#4103])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([fdo#109285] / [i915#4098])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [PASS][17] -> [DMESG-WARN][18] ([i915#62]) +11 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][19] ([fdo#109271]) +43 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
- fi-rkl-11600: NOTRUN -> [SKIP][20] ([i915#1072]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][21] ([i915#3555] / [i915#4098])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][22] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][23] ([fdo#109295] / [i915#3301] / [i915#3708])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-pnv-d510: [INCOMPLETE][24] ([i915#6863]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
* igt@fbdev@info:
- {fi-tgl-mst}: [SKIP][26] ([i915#2582]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-tgl-mst/igt@fbdev@info.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-tgl-mst/igt@fbdev@info.html
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][28] ([i915#2867]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_module_load@load:
- fi-bdw-gvtdvm: [DMESG-WARN][30] ([i915#6540]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-bdw-gvtdvm/igt@i915_module_load@load.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-bdw-gvtdvm/igt@i915_module_load@load.html
* igt@i915_selftest@live@hangcheck:
- {fi-ehl-2}: [INCOMPLETE][32] ([i915#5153]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-ehl-2/igt@i915_selftest@live@hangcheck.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-ehl-2/igt@i915_selftest@live@hangcheck.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-bdw-gvtdvm: [DMESG-WARN][34] ([i915#5922]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/fi-bdw-gvtdvm/igt@kms_force_connector_basic@force-connector-state.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/fi-bdw-gvtdvm/igt@kms_force_connector_basic@force-connector-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#5922]: https://gitlab.freedesktop.org/drm/intel/issues/5922
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
[i915#6540]: https://gitlab.freedesktop.org/drm/intel/issues/6540
[i915#6596]: https://gitlab.freedesktop.org/drm/intel/issues/6596
[i915#6863]: https://gitlab.freedesktop.org/drm/intel/issues/6863
Build changes
-------------
* Linux: CI_DRM_12161 -> Patchwork_108792v1
CI-20190529: 20190529
CI_DRM_12161: a7d5d07d5ac5ac58ec81932b3f732e3127d17af9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6659: 1becf700a737a7a98555a0cfbe8566355377afb2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108792v1: a7d5d07d5ac5ac58ec81932b3f732e3127d17af9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3f586188e97b drm/i915: Do not cleanup obj with NULL bo->resource
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/index.html
[-- Attachment #2: Type: text/html, Size: 11839 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Do not cleanup obj with NULL bo->resource
2022-09-20 17:06 [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource Nirmoy Das
2022-09-20 17:13 ` Matthew Auld
2022-09-20 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-09-20 23:37 ` Patchwork
2022-09-21 8:27 ` [Intel-gfx] [PATCH] " Das, Nirmoy
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-09-20 23:37 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 29761 bytes --]
== Series Details ==
Series: drm/i915: Do not cleanup obj with NULL bo->resource
URL : https://patchwork.freedesktop.org/series/108792/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12161_full -> Patchwork_108792v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 11)
------------------------------
Additional (2): shard-rkl shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_108792v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_color@ctm-0-75@pipe-a-hdmi-a-1:
- {shard-tglu}: NOTRUN -> [FAIL][1] +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-tglu-6/igt@kms_color@ctm-0-75@pipe-a-hdmi-a-1.html
New tests
---------
New tests have been introduced between CI_DRM_12161_full and Patchwork_108792v1_full:
### New IGT tests (2) ###
* igt@kms_lease@lease_revoke@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.05] s
* igt@kms_lease@page_flip_implicit_plane@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.15] s
Known issues
------------
Here are the changes found in Patchwork_108792v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26]) -> ([PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [FAIL][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51]) ([i915#4386])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl7/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl6/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl3/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl2/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl3/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl3/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl1/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl8/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl8/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl8/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl8/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl1/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl7/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl3/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl6/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl6/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl6/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl2/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl2/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl6/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl7/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl7/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl7/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl8/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl8/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl8/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl8/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [PASS][52] -> [SKIP][53] ([i915#4525])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb5/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: NOTRUN -> [FAIL][54] ([i915#2842])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][55] ([i915#2842])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl7/igt@gem_exec_suspend@basic-s3@smem.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl2/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#4613]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@gem_lmem_swapping@massive-random.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][59] -> [DMESG-WARN][60] ([i915#5591])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-tglb7/igt@i915_selftest@live@hangcheck.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-tglb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#3886]) +5 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_color_chamelium@degamma:
- shard-glk: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk6/igt@kms_color_chamelium@degamma.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-glk: [PASS][63] -> [DMESG-FAIL][64] ([i915#118] / [i915#1888])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][65] -> [FAIL][66] ([i915#79])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@b-dp1:
- shard-apl: [PASS][67] -> [FAIL][68] ([i915#79])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl8/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#2672]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#2587] / [i915#2672]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#3555]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#2672] / [i915#3555])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1:
- shard-glk: [PASS][73] -> [DMESG-WARN][74] ([i915#118] / [i915#1888])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-glk5/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk3/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][75] ([fdo#109271]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-snb7/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][76] -> [SKIP][77] ([i915#5235]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][79] -> [SKIP][80] ([fdo#109441])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#533])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271]) +77 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
* igt@perf@non-zero-reason:
- shard-apl: [PASS][83] -> [FAIL][84] ([i915#6742])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl7/igt@perf@non-zero-reason.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/igt@perf@non-zero-reason.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][85] ([i915#6268]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][87] ([i915#2842]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][89] ([i915#2842]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][91] ([i915#2842]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-apl8/igt@i915_suspend@debugfs-reader.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-apl3/igt@i915_suspend@debugfs-reader.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglb: [FAIL][95] ([i915#3743]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-tglb2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-tglb8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][97] ([i915#3555]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][99] ([fdo#109441]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][101] ([i915#5213]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-glk9/igt@perf@stress-open-close.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-glk7/igt@perf@stress-open-close.html
#### Warnings ####
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][103] ([i915#658]) -> [SKIP][104] ([i915#2920])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][105] ([fdo#111068] / [i915#658]) -> [SKIP][106] ([i915#2920])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12161/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6742]: https://gitlab.freedesktop.org/drm/intel/issues/6742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12161 -> Patchwork_108792v1
CI-20190529: 20190529
CI_DRM_12161: a7d5d07d5ac5ac58ec81932b3f732e3127d17af9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6659: 1becf700a737a7a98555a0cfbe8566355377afb2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108792v1: a7d5d07d5ac5ac58ec81932b3f732e3127d17af9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108792v1/index.html
[-- Attachment #2: Type: text/html, Size: 24207 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource
2022-09-20 17:06 [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource Nirmoy Das
` (2 preceding siblings ...)
2022-09-20 23:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-09-21 8:27 ` Das, Nirmoy
3 siblings, 0 replies; 6+ messages in thread
From: Das, Nirmoy @ 2022-09-21 8:27 UTC (permalink / raw)
To: intel-gfx; +Cc: matthew.auld, dri-devel
Hi Matt
On 9/20/2022 7:06 PM, Nirmoy Das wrote:
> For delayed BO release i915_ttm_delete_mem_notify()
> gets called twice, once with proper bo->resource and
> another time with NULL. We shouldn't do anything for
> the 2nd time as we already cleanedup the obj once.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6850
Please add the below Fixes before merging, I missed that.
Fixes: ad74457a6b5a96 ("drm/i915/dgfx: Release mmap on rpm suspend")
Thanks,
Nirmoy
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 0544b0a4a43a..e3fc38dd5db0 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -511,7 +511,7 @@ static void i915_ttm_delete_mem_notify(struct ttm_buffer_object *bo)
> struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
> intel_wakeref_t wakeref = 0;
>
> - if (likely(obj)) {
> + if (bo->resource && likely(obj)) {
> /* ttm_bo_release() already has dma_resv_lock */
> if (i915_ttm_cpu_maps_iomem(bo->resource))
> wakeref = intel_runtime_pm_get(&to_i915(obj->base.dev)->runtime_pm);
^ permalink raw reply [flat|nested] 6+ messages in thread