* [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
@ 2023-07-17 6:22 Su Hui
2023-07-17 14:52 ` Andrzej Hajda
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Su Hui @ 2023-07-17 6:22 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, daniel, nathan, ndesaulniers, trix
Cc: Su Hui, intel-gfx, llvm, kernel-janitors, linux-kernel, dri-devel,
mripard, andrzej.hajda
Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
line 991, column 22 Division by zero.
Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
then division by zero will happen.
Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
index 36b479b46b60..82b54af51f23 100644
--- a/drivers/gpu/drm/i915/display/intel_tv.c
+++ b/drivers/gpu/drm/i915/display/intel_tv.c
@@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode *mode,
const struct tv_mode *tv_mode,
int clock)
{
- mode->clock = clock / (tv_mode->oversample >> !tv_mode->progressive);
+ mode->clock = clock / (tv_mode->oversample != 1 ?
+ tv_mode->oversample >> !tv_mode->progressive : 1);
/*
* tv_mode horizontal timings:
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
2023-07-17 6:22 [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero Su Hui
@ 2023-07-17 14:52 ` Andrzej Hajda
2023-07-18 1:13 ` Su Hui
2023-07-18 5:39 ` Dan Carpenter
2023-07-17 18:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-17 22:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 2 replies; 9+ messages in thread
From: Andrzej Hajda @ 2023-07-17 14:52 UTC (permalink / raw)
To: Su Hui, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel, nathan, ndesaulniers, trix
Cc: intel-gfx, llvm, kernel-janitors, linux-kernel, dri-devel,
mripard
On 17.07.2023 08:22, Su Hui wrote:
> Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
> line 991, column 22 Division by zero.
> Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
> then division by zero will happen.
>
> Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
> index 36b479b46b60..82b54af51f23 100644
> --- a/drivers/gpu/drm/i915/display/intel_tv.c
> +++ b/drivers/gpu/drm/i915/display/intel_tv.c
> @@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode *mode,
> const struct tv_mode *tv_mode,
> int clock)
> {
> - mode->clock = clock / (tv_mode->oversample >> !tv_mode->progressive);
> + mode->clock = clock / (tv_mode->oversample != 1 ?
> + tv_mode->oversample >> !tv_mode->progressive : 1);
Seems too smart to me, why not just:
mode->clock = clock / tv_mode->oversample;
if (!tv_mode->progressive)
mode->clock <<= 1;
Or trying being smart:
mode->clock = clock / tv_mode->oversample << !tv_mode->progressive;
Btw in both cases there is assumption tv_mode->oversample != 0, I guess
it is true.
Regards
Andrzej
>
> /*
> * tv_mode horizontal timings:
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tv: avoid possible division by zero
2023-07-17 6:22 [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero Su Hui
2023-07-17 14:52 ` Andrzej Hajda
@ 2023-07-17 18:24 ` Patchwork
2023-07-17 22:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-07-17 18:24 UTC (permalink / raw)
To: Su Hui; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14461 bytes --]
== Series Details ==
Series: drm/i915/tv: avoid possible division by zero
URL : https://patchwork.freedesktop.org/series/120851/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13392 -> Patchwork_120851v1
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_120851v1 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_120851v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/index.html
Participating hosts (43 -> 43)
------------------------------
Additional (1): bat-rpls-2
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_120851v1:
### IGT changes ###
#### Warnings ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-atsm-1: [DMESG-WARN][1] ([i915#8841]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-atsm-1/igt@gem_exec_suspend@basic-s0@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-atsm-1/igt@gem_exec_suspend@basic-s0@smem.html
Known issues
------------
Here are the changes found in Patchwork_120851v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@info:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#1849] / [i915#2582])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@fbdev@info.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#2582]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@fbdev@read.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][8] ([i915#7561])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-guc: [PASS][9] -> [FAIL][10] ([i915#7940])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
- fi-cfl-8700k: [PASS][11] -> [FAIL][12] ([i915#7940])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-8700k/igt@i915_pm_rpm@basic-rte.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-cfl-8700k/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [PASS][13] -> [FAIL][14] ([i915#7940])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][15] ([i915#6621])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][16] ([i915#4258] / [i915#7913])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][17] -> [ABORT][18] ([i915#7982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-8/igt@i915_selftest@live@requests.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][19] -> [ABORT][20] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rpls-1/igt@i915_selftest@live@reset.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][21] ([i915#6367])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][22] ([i915#1845]) +15 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][23] ([i915#7828]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][24] ([i915#3637]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][25] ([fdo#109285])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][26] ([i915#1849])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@primary_page_flip:
- bat-rplp-1: NOTRUN -> [SKIP][27] ([i915#1072]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][28] ([i915#1072]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: NOTRUN -> [ABORT][29] ([i915#8260] / [i915#8668])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
- bat-rpls-2: NOTRUN -> [SKIP][30] ([i915#3555])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][31] ([fdo#109295] / [i915#1845] / [i915#3708])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-write:
- bat-rpls-2: NOTRUN -> [SKIP][32] ([fdo#109295] / [i915#3708]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rpls-2/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-skl-guc: [FAIL][33] ([i915#7940]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [FAIL][35] ([i915#7940]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [FAIL][37] ([i915#7940]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
- fi-tgl-1115g4: [FAIL][39] ([i915#7940]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-8: [DMESG-FAIL][41] ([i915#7059]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][43] ([i915#7699]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-11/igt@i915_selftest@live@migrate.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-mtlp-6: [DMESG-FAIL][45] ([i915#8497]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-6/igt@i915_selftest@live@requests.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-mtlp-6/igt@i915_selftest@live@requests.html
* igt@kms_chamelium_frames@dp-crc-fast:
- {bat-dg2-13}: [DMESG-WARN][47] ([Intel XE#485]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][49] ([i915#8442] / [i915#8668]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
#### Warnings ####
* igt@core_auth@basic-auth:
- bat-adlp-11: [ABORT][51] ([i915#8011]) -> [ABORT][52] ([i915#4423] / [i915#8011])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-adlp-11/igt@core_auth@basic-auth.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/bat-adlp-11/igt@core_auth@basic-auth.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [FAIL][53] ([i915#7940]) -> [SKIP][54] ([fdo#109271])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#485]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/485
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
Build changes
-------------
* Linux: CI_DRM_13392 -> Patchwork_120851v1
CI-20190529: 20190529
CI_DRM_13392: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_120851v1: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
188e83581a87 drm/i915/tv: avoid possible division by zero
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/index.html
[-- Attachment #2: Type: text/html, Size: 16992 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tv: avoid possible division by zero
2023-07-17 6:22 [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero Su Hui
2023-07-17 14:52 ` Andrzej Hajda
2023-07-17 18:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-07-17 22:51 ` Patchwork
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-07-17 22:51 UTC (permalink / raw)
To: Su Hui; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30455 bytes --]
== Series Details ==
Series: drm/i915/tv: avoid possible division by zero
URL : https://patchwork.freedesktop.org/series/120851/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13392_full -> Patchwork_120851v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_120851v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@object-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][1] ([i915#8411])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@api_intel_bb@object-reloc-purge-cache.html
* igt@gem_basic@multigpu-create-close:
- shard-dg2: NOTRUN -> [SKIP][2] ([i915#7697])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_basic@multigpu-create-close.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][3] -> [FAIL][4] ([i915#6268])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@hibernate:
- shard-dg2: NOTRUN -> [ABORT][5] ([i915#7975] / [i915#8213])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_eio@hibernate.html
* igt@gem_eio@kms:
- shard-mtlp: [PASS][6] -> [ABORT][7] ([i915#7461] / [i915#7892])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-4/igt@gem_eio@kms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-6/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-apl7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-apl1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fence@submit:
- shard-mtlp: NOTRUN -> [SKIP][12] ([i915#4812])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@gem_exec_fence@submit.html
* igt@gem_exec_fence@submit67:
- shard-dg2: NOTRUN -> [SKIP][13] ([i915#4812])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_exec_fence@submit67.html
* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-dg2: NOTRUN -> [SKIP][14] ([i915#3539] / [i915#4852])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
* igt@gem_mmap_gtt@medium-copy-xy:
- shard-mtlp: NOTRUN -> [SKIP][15] ([i915#4077]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@gem_mmap_gtt@medium-copy-xy.html
* igt@gem_mmap_gtt@ptrace:
- shard-dg2: NOTRUN -> [SKIP][16] ([i915#4077]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_mmap_gtt@ptrace.html
* igt@gem_mmap_wc@write-wc-read-gtt:
- shard-mtlp: NOTRUN -> [SKIP][17] ([i915#4083])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@gem_mmap_wc@write-wc-read-gtt.html
* igt@gem_render_copy@yf-tiled-ccs-to-linear:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#5190])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_render_copy@yf-tiled-ccs-to-linear.html
* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-dg2: NOTRUN -> [SKIP][19] ([i915#4079])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html
* igt@i915_pm_dc@dc5-psr:
- shard-dg2: NOTRUN -> [SKIP][20] ([i915#658])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#3591])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk2/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-glk4/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@cursor-dpms:
- shard-tglu: [PASS][23] -> [FAIL][24] ([i915#7940]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-8/igt@i915_pm_rpm@cursor-dpms.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-tglu-7/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-rkl: [PASS][25] -> [SKIP][26] ([i915#1397])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-4/igt@i915_pm_rpm@modeset-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-dg2: [PASS][27] -> [SKIP][28] ([i915#1397])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-10/igt@i915_pm_rpm@modeset-lpsp-stress.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][29] ([i915#8502]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs.html
* igt@kms_async_flips@crc@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][30] ([i915#8247]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-7/igt@kms_async_flips@crc@pipe-b-hdmi-a-1.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-mtlp: NOTRUN -> [FAIL][31] ([i915#3743])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [PASS][32] -> [FAIL][33] ([i915#5138]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#4538] / [i915#5190])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#6095])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#3689] / [i915#3886] / [i915#5354])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][37] ([i915#3886] / [i915#6095]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][38] ([i915#3689] / [i915#5354]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][39] ([i915#4087]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-8/igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3.html
* igt@kms_content_protection@atomic-dpms:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#7118]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-3/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@srm@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [TIMEOUT][41] ([i915#7173]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-12/igt@kms_content_protection@srm@pipe-a-dp-2.html
* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#3359])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_cursor_crc@cursor-rapid-movement-512x512.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-mtlp: NOTRUN -> [SKIP][43] ([i915#3546])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-2/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- shard-dg2: NOTRUN -> [SKIP][44] ([i915#3555])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-dg2: [PASS][45] -> [FAIL][46] ([i915#6880])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-mtlp: NOTRUN -> [SKIP][47] ([i915#1825])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][48] ([i915#5354]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-dg2: [PASS][49] -> [FAIL][50] ([fdo#103375]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#3458]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-vga-1:
- shard-snb: NOTRUN -> [DMESG-WARN][52] ([i915#8841]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-snb5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-vga-1.html
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-dg2: NOTRUN -> [SKIP][53] ([fdo#109274] / [i915#5354])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_plane_scaling@2x-scaler-multi-pipe.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][54] ([i915#8292])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-11/igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#5176]) +7 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-10/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#5176]) +5 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-4/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][57] ([i915#5235]) +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-2/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][58] ([fdo#109271]) +14 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][59] ([i915#5235]) +19 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_rotation_crc@primary-rotation-90:
- shard-dg2: NOTRUN -> [SKIP][60] ([i915#4235])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@kms_rotation_crc@primary-rotation-90.html
* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][61] ([i915#5465]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#2437])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-5/igt@kms_writeback@writeback-invalid-parameters.html
* igt@perf@enable-disable@0-rcs0:
- shard-dg2: [PASS][63] -> [FAIL][64] ([i915#8724])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-1/igt@perf@enable-disable@0-rcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-11/igt@perf@enable-disable@0-rcs0.html
* igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#2575])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-7/igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync.html
* igt@vc4/vc4_tiling@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#7711]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@vc4/vc4_tiling@get-bad-handle.html
#### Possible fixes ####
* igt@gem_create@hog-create@smem0:
- shard-dg2: [FAIL][67] ([i915#5892] / [i915#8758]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-10/igt@gem_create@hog-create@smem0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@gem_create@hog-create@smem0.html
* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][69] ([i915#5784]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg1-17/igt@gem_eio@kms.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg1-14/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][71] ([i915#2842]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_suspend@basic-s3@lmem0:
- shard-dg2: [FAIL][73] ([fdo#103375]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-2/igt@gem_exec_suspend@basic-s3@lmem0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-8/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-mtlp: [ABORT][75] ([i915#8131]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-2/igt@gem_exec_whisper@basic-contexts-forked-all.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [DMESG-WARN][77] ([i915#7061]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-10/igt@i915_module_load@reload-with-fault-injection.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-7/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-tglu: [FAIL][79] ([i915#7940]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-6/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-tglu-9/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- {shard-dg1}: [FAIL][81] ([i915#7940]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg1-18/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg1-16/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-dg2: [SKIP][83] ([i915#1397]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-8/igt@i915_pm_rpm@modeset-lpsp.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-10/igt@i915_pm_rpm@modeset-lpsp.html
* igt@i915_selftest@live@gt_mocs:
- shard-mtlp: [DMESG-FAIL][85] ([i915#7059]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-5/igt@i915_selftest@live@gt_mocs.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-2/igt@i915_selftest@live@gt_mocs.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-mtlp: [FAIL][87] ([i915#3743]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-mtlp: [FAIL][89] ([i915#8248]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-5/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][91] ([i915#2346]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][93] ([i915#79]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [FAIL][95] ([i915#2122]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3:
- shard-dg2: [FAIL][97] ([i915#79]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3.html
#### Warnings ####
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][99] ([i915#5493]) -> [DMESG-WARN][100] ([i915#4936] / [i915#5493])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-1/igt@gem_lmem_swapping@smem-oom@lmem0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@kms_content_protection@content_type_change:
- shard-dg2: [SKIP][101] ([i915#7118]) -> [SKIP][102] ([i915#7118] / [i915#7162])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-2/igt@kms_content_protection@content_type_change.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-11/igt@kms_content_protection@content_type_change.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-mtlp: [FAIL][103] ([i915#2346]) -> [DMESG-FAIL][104] ([i915#1982] / [i915#2017] / [i915#5954])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-mtlp-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][105] ([i915#3955]) -> [SKIP][106] ([fdo#110189] / [i915#3955])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-4/igt@kms_fbcon_fbt@psr.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-1/igt@kms_fbcon_fbt@psr.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][107] ([fdo#109285]) -> [SKIP][108] ([fdo#109285] / [i915#4098])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-7/igt@kms_force_connector_basic@force-load-detect.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-rkl-4/igt@kms_force_connector_basic@force-load-detect.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][109] ([i915#7484]) -> [FAIL][110] ([i915#7757])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-1/igt@perf@non-zero-reason@0-rcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7757]: https://gitlab.freedesktop.org/drm/intel/issues/7757
[i915#7892]: https://gitlab.freedesktop.org/drm/intel/issues/7892
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8724]: https://gitlab.freedesktop.org/drm/intel/issues/8724
[i915#8758]: https://gitlab.freedesktop.org/drm/intel/issues/8758
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
Build changes
-------------
* Linux: CI_DRM_13392 -> Patchwork_120851v1
CI-20190529: 20190529
CI_DRM_13392: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_120851v1: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120851v1/index.html
[-- Attachment #2: Type: text/html, Size: 34267 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
2023-07-17 14:52 ` Andrzej Hajda
@ 2023-07-18 1:13 ` Su Hui
2023-07-18 5:39 ` Dan Carpenter
1 sibling, 0 replies; 9+ messages in thread
From: Su Hui @ 2023-07-18 1:13 UTC (permalink / raw)
To: Andrzej Hajda, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel, nathan, ndesaulniers, trix
Cc: intel-gfx, llvm, kernel-janitors, linux-kernel, dri-devel,
mripard
On 2023/7/17 22:52, Andrzej Hajda wrote:
>
>
> On 17.07.2023 08:22, Su Hui wrote:
>> Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
>> line 991, column 22 Division by zero.
>> Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
>> then division by zero will happen.
>>
>> Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
>> Signed-off-by: Su Hui <suhui@nfschina.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_tv.c
>> b/drivers/gpu/drm/i915/display/intel_tv.c
>> index 36b479b46b60..82b54af51f23 100644
>> --- a/drivers/gpu/drm/i915/display/intel_tv.c
>> +++ b/drivers/gpu/drm/i915/display/intel_tv.c
>> @@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode *mode,
>> const struct tv_mode *tv_mode,
>> int clock)
>> {
>> - mode->clock = clock / (tv_mode->oversample >>
>> !tv_mode->progressive);
>> + mode->clock = clock / (tv_mode->oversample != 1 ?
>> + tv_mode->oversample >> !tv_mode->progressive : 1);
>
> Seems too smart to me, why not just:
> mode->clock = clock / tv_mode->oversample;
> if (!tv_mode->progressive)
> mode->clock <<= 1;
> Or trying being smart:
> mode->clock = clock / tv_mode->oversample << !tv_mode->progressive;
Hi,
Yes, this is more readable and clear.
Thanks four your advice. I will send v2 soon.
Su Hui
>
> Btw in both cases there is assumption tv_mode->oversample != 0, I
> guess it is true.
>
> Regards
> Andrzej
>
>> /*
>> * tv_mode horizontal timings:
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
2023-07-17 14:52 ` Andrzej Hajda
2023-07-18 1:13 ` Su Hui
@ 2023-07-18 5:39 ` Dan Carpenter
2023-07-18 10:10 ` Su Hui
1 sibling, 1 reply; 9+ messages in thread
From: Dan Carpenter @ 2023-07-18 5:39 UTC (permalink / raw)
To: Andrzej Hajda
Cc: dri-devel, kernel-janitors, llvm, Su Hui, trix, intel-gfx,
ndesaulniers, linux-kernel, nathan, mripard, daniel, rodrigo.vivi,
airlied
On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote:
>
>
> On 17.07.2023 08:22, Su Hui wrote:
> > Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
> > line 991, column 22 Division by zero.
> > Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
> > then division by zero will happen.
> >
> > Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
> > Signed-off-by: Su Hui <suhui@nfschina.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
> > index 36b479b46b60..82b54af51f23 100644
> > --- a/drivers/gpu/drm/i915/display/intel_tv.c
> > +++ b/drivers/gpu/drm/i915/display/intel_tv.c
> > @@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode *mode,
> > const struct tv_mode *tv_mode,
> > int clock)
> > {
> > - mode->clock = clock / (tv_mode->oversample >> !tv_mode->progressive);
> > + mode->clock = clock / (tv_mode->oversample != 1 ?
> > + tv_mode->oversample >> !tv_mode->progressive : 1);
>
> Seems too smart to me, why not just:
> mode->clock = clock / tv_mode->oversample;
> if (!tv_mode->progressive)
> mode->clock <<= 1;
This is nice.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
2023-07-18 5:39 ` Dan Carpenter
@ 2023-07-18 10:10 ` Su Hui
2023-07-18 11:28 ` Andrzej Hajda
0 siblings, 1 reply; 9+ messages in thread
From: Su Hui @ 2023-07-18 10:10 UTC (permalink / raw)
To: Dan Carpenter, Andrzej Hajda
Cc: kernel-janitors, llvm, dri-devel, trix, intel-gfx, ndesaulniers,
linux-kernel, nathan, mripard, daniel, rodrigo.vivi, airlied
On 2023/7/18 13:39, Dan Carpenter wrote:
> On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote:
>>
>> On 17.07.2023 08:22, Su Hui wrote:
>>> Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
>>> line 991, column 22 Division by zero.
>>> Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
>>> then division by zero will happen.
>>>
>>> Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
>>> Signed-off-by: Su Hui <suhui@nfschina.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
>>> index 36b479b46b60..82b54af51f23 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_tv.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_tv.c
>>> @@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode *mode,
>>> const struct tv_mode *tv_mode,
>>> int clock)
>>> {
>>> - mode->clock = clock / (tv_mode->oversample >> !tv_mode->progressive);
>>> + mode->clock = clock / (tv_mode->oversample != 1 ?
>>> + tv_mode->oversample >> !tv_mode->progressive : 1);
>> Seems too smart to me, why not just:
>> mode->clock = clock / tv_mode->oversample;
>> if (!tv_mode->progressive)
>> mode->clock <<= 1;
> This is nice.
mode->clock = clock / tv_mode->oversample << !tv_mode->progressive;
But I think this one is much better, it has less code and run faster.
Should I resend v3 to add some explanation or follow Dan's advice?
Su Hui
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
2023-07-18 10:10 ` Su Hui
@ 2023-07-18 11:28 ` Andrzej Hajda
2023-07-19 2:12 ` Su Hui
0 siblings, 1 reply; 9+ messages in thread
From: Andrzej Hajda @ 2023-07-18 11:28 UTC (permalink / raw)
To: Su Hui, Dan Carpenter
Cc: kernel-janitors, llvm, dri-devel, trix, intel-gfx, ndesaulniers,
linux-kernel, nathan, mripard, daniel, rodrigo.vivi, airlied
On 18.07.2023 12:10, Su Hui wrote:
> On 2023/7/18 13:39, Dan Carpenter wrote:
>> On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote:
>>>
>>> On 17.07.2023 08:22, Su Hui wrote:
>>>> Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
>>>> line 991, column 22 Division by zero.
>>>> Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
>>>> then division by zero will happen.
>>>>
>>>> Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
>>>> Signed-off-by: Su Hui <suhui@nfschina.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_tv.c
>>>> b/drivers/gpu/drm/i915/display/intel_tv.c
>>>> index 36b479b46b60..82b54af51f23 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_tv.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_tv.c
>>>> @@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode
>>>> *mode,
>>>> const struct tv_mode *tv_mode,
>>>> int clock)
>>>> {
>>>> - mode->clock = clock / (tv_mode->oversample >>
>>>> !tv_mode->progressive);
>>>> + mode->clock = clock / (tv_mode->oversample != 1 ?
>>>> + tv_mode->oversample >> !tv_mode->progressive : 1);
>>> Seems too smart to me, why not just:
>>> mode->clock = clock / tv_mode->oversample;
>>> if (!tv_mode->progressive)
>>> mode->clock <<= 1;
>> This is nice.
>
> mode->clock = clock / tv_mode->oversample << !tv_mode->progressive;
>
> But I think this one is much better, it has less code and run faster.
> Should I resend v3 to add some explanation or follow Dan's advice?
Speed gain here is irrelevant here, and disputable.
One thing which could be problematic is that we could loose the least
significant bit in mode->clock,
in case non-progressive, but I am not sure if it really matters, as
mode->clock is not precise value anyway.
Alternatively we could 1st shift, then divide, but in this case overflow
can occur, at least in theory - I suspect there are no such big clocks
(in kHz).
Finally I would agree with Dan, readability is better with conditional.
Regards
Andrzej
>
> Su Hui
>
>> regards,
>> dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero
2023-07-18 11:28 ` Andrzej Hajda
@ 2023-07-19 2:12 ` Su Hui
0 siblings, 0 replies; 9+ messages in thread
From: Su Hui @ 2023-07-19 2:12 UTC (permalink / raw)
To: Andrzej Hajda
Cc: kernel-janitors, llvm, dri-devel, trix, intel-gfx, ndesaulniers,
linux-kernel, nathan, Dan Carpenter, mripard, daniel,
rodrigo.vivi, airlied
On 2023/7/18 19:28, Andrzej Hajda wrote:
> On 18.07.2023 12:10, Su Hui wrote:
>> On 2023/7/18 13:39, Dan Carpenter wrote:
>>> On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote:
>>>> On 17.07.2023 08:22, Su Hui wrote:
>>>>> Clang warning: drivers/gpu/drm/i915/display/intel_tv.c:
>>>>> line 991, column 22 Division by zero.
>>>>> Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,
>>>>> then division by zero will happen.
>>>>>
>>>>> Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")
>>>>> Signed-off-by: Su Hui <suhui@nfschina.com>
>>>>> ---
>>>>> drivers/gpu/drm/i915/display/intel_tv.c | 3 ++-
>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_tv.c
>>>>> b/drivers/gpu/drm/i915/display/intel_tv.c
>>>>> index 36b479b46b60..82b54af51f23 100644
>>>>> --- a/drivers/gpu/drm/i915/display/intel_tv.c
>>>>> +++ b/drivers/gpu/drm/i915/display/intel_tv.c
>>>>> @@ -988,7 +988,8 @@ intel_tv_mode_to_mode(struct drm_display_mode
>>>>> *mode,
>>>>> const struct tv_mode *tv_mode,
>>>>> int clock)
>>>>> {
>>>>> - mode->clock = clock / (tv_mode->oversample >>
>>>>> !tv_mode->progressive);
>>>>> + mode->clock = clock / (tv_mode->oversample != 1 ?
>>>>> + tv_mode->oversample >> !tv_mode->progressive : 1);
>>>> Seems too smart to me, why not just:
>>>> mode->clock = clock / tv_mode->oversample;
>>>> if (!tv_mode->progressive)
>>>> mode->clock <<= 1;
>>> This is nice.
>>
>> mode->clock = clock / tv_mode->oversample << !tv_mode->progressive;
>>
>> But I think this one is much better, it has less code and run faster.
>> Should I resend v3 to add some explanation or follow Dan's advice?
>
> Speed gain here is irrelevant here, and disputable.
>
> One thing which could be problematic is that we could loose the least
> significant bit in mode->clock,
> in case non-progressive, but I am not sure if it really matters, as
> mode->clock is not precise value anyway.
> Alternatively we could 1st shift, then divide, but in this case
> overflow can occur, at least in theory - I suspect there are no such
> big clocks (in kHz).
>
> Finally I would agree with Dan, readability is better with conditional.
>
How about this one?
- mode->clock = clock / (tv_mode->oversample >> !tv_mode->progressive);
+ mode->clock = clock;
+ if (tv_mode->oversample >> !tv_mode->progressive)
+ mode->clock /= tv_mode->oversample >> 1;
Prevent loss of accuracy and also make it more readable.
If it's OK, I will send v3 patch.
By the way, do we need to print some error messages or do some things when
"tv_mode->oversample << !tv_mode->progressive" is zero? I'm not sure about
this.
Su Hui
> Regards
> Andrzej
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-07-19 14:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 6:22 [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero Su Hui
2023-07-17 14:52 ` Andrzej Hajda
2023-07-18 1:13 ` Su Hui
2023-07-18 5:39 ` Dan Carpenter
2023-07-18 10:10 ` Su Hui
2023-07-18 11:28 ` Andrzej Hajda
2023-07-19 2:12 ` Su Hui
2023-07-17 18:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-17 22:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox