Re: drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Carlos Santa <carlos.santa@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Michel Thierry <michel.thierry@intel.com>
Subject: Re: drm/i915: Watchdog timeout: DRM kernel interface to set the timeout
Date: Mon, 7 Jan 2019 17:00:01 +0000	[thread overview]
Message-ID: <0d24c67a-6a70-8bfd-bbd3-d61a18ff0003@linux.intel.com> (raw)
In-Reply-To: <f08b7a49-cc6c-9266-240a-40d85be94fe5@linux.intel.com>

On 07/01/2019 12:38, Tvrtko Ursulin wrote:

[snip]

>> +#define GEN8_TIMESTAMP_CNTS_PER_USEC 12
>> +#define GEN9_LP_TIMESTAMP_CNTS_PER_USEC 19
>> +static inline u32 cs_timestamp_in_us(struct drm_i915_private *dev_priv)
>> +{
>> +    u32 cs_timestamp_base = dev_priv->cs_timestamp_base;
>> +
>> +    if (cs_timestamp_base)
>> +        return cs_timestamp_base;
>> +
>> +    switch (INTEL_GEN(dev_priv)) {
>> +    default:
>> +        MISSING_CASE(INTEL_GEN(dev_priv));
>> +        /* fall through */
>> +    case 9:
>> +        cs_timestamp_base = IS_GEN9_LP(dev_priv) ?
>> +                    GEN9_LP_TIMESTAMP_CNTS_PER_USEC :
>> +                    GEN8_TIMESTAMP_CNTS_PER_USEC;
>> +        break;
>> +    case 8:
>> +        cs_timestamp_base = GEN8_TIMESTAMP_CNTS_PER_USEC;
>> +        break;
>> +    }
>> +
>> +    dev_priv->cs_timestamp_base = cs_timestamp_base;
>> +    return cs_timestamp_base;
>> +}
> 
> We already have RUNTIME_INFO(i915)->cs_timestamp_frequency_khz and 
> read_timestamp_frequency which sets it.

Here I missed the mark, please ignore.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx