Re: drm/i915: Watchdog timeout: Include threshold value in error state

From: kbuild test robot <lkp@intel.com>
To: Carlos Santa <carlos.santa@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>,
	intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: drm/i915: Watchdog timeout: Include threshold value in error state
Date: Sat, 5 Jan 2019 12:39:27 +0800	[thread overview]
Message-ID: <201901051213.C3oFEATo%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190105024001.37629-6-carlos.santa@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]

Hi Michel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.20 next-20190103]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Carlos-Santa/drm-i915-Watchdog-timeout-Include-threshold-value-in-error-state/20190105-112649
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-s1-201900 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/i915_gpu_error.c: In function 'error_print_context':
>> drivers/gpu//drm/i915/i915_gpu_error.c:466:4: error: implicit declaration of function 'watchdog_to_us' [-Werror=implicit-function-declaration]
       watchdog_to_us(m->i915, ctx->watchdog_threshold) : 0);
       ^
   drivers/gpu//drm/i915/i915_gpu_error.c:189:49: note: in definition of macro 'err_printf'
    #define err_printf(e, ...) i915_error_printf(e, __VA_ARGS__)
                                                    ^~~~~~~~~~~
   drivers/gpu//drm/i915/i915_gpu_error.c: In function 'record_context':
   drivers/gpu//drm/i915/i915_gpu_error.c:1481:50: error: 'struct intel_context' has no member named 'watchdog_threshold'
     e->watchdog_threshold = ctx->__engine[engine_id].watchdog_threshold;
                                                     ^
   cc1: some warnings being treated as errors

vim +/watchdog_to_us +466 drivers/gpu//drm/i915/i915_gpu_error.c

   456	
   457	static void error_print_context(struct drm_i915_error_state_buf *m,
   458					const char *header,
   459					const struct drm_i915_error_context *ctx)
   460	{
   461		err_printf(m, "%s%s[%d] user_handle %d hw_id %d, prio %d, ban score %d%s guilty %d active %d, watchdog %dus\n",
   462			   header, ctx->comm, ctx->pid, ctx->handle, ctx->hw_id,
   463			   ctx->sched_attr.priority, ctx->ban_score, bannable(ctx),
   464			   ctx->guilty, ctx->active,
   465			   INTEL_GEN(m->i915) >= 8 ?
 > 466				watchdog_to_us(m->i915, ctx->watchdog_threshold) : 0);
   467	}
   468	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33577 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx