Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove leftover gem.pm_notifier member
Date: Tue, 12 Nov 2019 11:48:40 +0000	[thread overview]
Message-ID: <0df1b2b8-8177-07b6-4709-ce55133307a5@linux.intel.com> (raw)
In-Reply-To: <20191112113434.31088-1-chris@chris-wilson.co.uk>


On 12/11/2019 11:34, Chris Wilson wrote:
> Since we removed the pm hookup from the GT, the hook in
> drm_i915_private.gem is unused. Remove it.
> 
> References: 18f3b2727fc3 ("drm/i915: Remove pm park/unpark notifications")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_drv.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index c303707f5132..5f8bd1d54c59 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1252,8 +1252,6 @@ struct drm_i915_private {
>   	struct intel_gt gt;
>   
>   	struct {
> -		struct notifier_block pm_notifier;
> -
>   		struct i915_gem_contexts {
>   			spinlock_t lock; /* locks list */
>   			struct list_head list;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove leftover gem.pm_notifier member
Date: Tue, 12 Nov 2019 11:48:40 +0000	[thread overview]
Message-ID: <0df1b2b8-8177-07b6-4709-ce55133307a5@linux.intel.com> (raw)
Message-ID: <20191112114840.9YEmPUUrwBAma9JjD4ZlV3A5jiNUpiFB0ly6imnsQQ0@z> (raw)
In-Reply-To: <20191112113434.31088-1-chris@chris-wilson.co.uk>


On 12/11/2019 11:34, Chris Wilson wrote:
> Since we removed the pm hookup from the GT, the hook in
> drm_i915_private.gem is unused. Remove it.
> 
> References: 18f3b2727fc3 ("drm/i915: Remove pm park/unpark notifications")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_drv.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index c303707f5132..5f8bd1d54c59 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1252,8 +1252,6 @@ struct drm_i915_private {
>   	struct intel_gt gt;
>   
>   	struct {
> -		struct notifier_block pm_notifier;
> -
>   		struct i915_gem_contexts {
>   			spinlock_t lock; /* locks list */
>   			struct list_head list;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-12 11:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 11:34 [PATCH] drm/i915: Remove leftover gem.pm_notifier member Chris Wilson
2019-11-12 11:34 ` [Intel-gfx] " Chris Wilson
2019-11-12 11:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-12 11:46   ` [Intel-gfx] " Patchwork
2019-11-12 11:48 ` Tvrtko Ursulin [this message]
2019-11-12 11:48   ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2019-11-12 12:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-12 12:27   ` [Intel-gfx] " Patchwork
2019-11-12 17:06 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-12 17:06   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0df1b2b8-8177-07b6-4709-ce55133307a5@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox