Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ykzhao <yakui.zhao@intel.com>
To: Eric Anholt <eric@anholt.net>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	arjan@linxu.intel.com, linux-acpi@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 4/4] cpuidle: Hack iowait weighting to avoid C-state reduction for graphics.
Date: Tue, 02 Nov 2010 20:20:14 +0800	[thread overview]
Message-ID: <1288700414.26046.18.camel@localhost.localdomain> (raw)
In-Reply-To: <1288643024-5706-5-git-send-email-eric@anholt.net>

On Tue, 2010-11-02 at 04:23 +0800, Eric Anholt wrote:
> Improves nexuiz performance by about 1% on my system.

CC: Arjan and linux-acpi mailing list.

It seems that the selection of C-state will become very sensitive to IO
wait after the multi factor is changed from 10 to 1000.
Maybe only one IO/wait will bring that the system can't enter the deep
C-state.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  drivers/cpuidle/governors/menu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
> index f508690..9bb5654 100644
> --- a/drivers/cpuidle/governors/menu.c
> +++ b/drivers/cpuidle/governors/menu.c
> @@ -175,7 +175,7 @@ static inline int performance_multiplier(void)
>  	mult += 2 * get_loadavg();
>  
>  	/* for IO wait tasks (per cpu!) we add 5x each */
> -	mult += 10 * nr_iowait_cpu(smp_processor_id());
> +	mult += 1000 * nr_iowait_cpu(smp_processor_id());
>  
>  	return mult;
>  }


  reply	other threads:[~2010-11-02 12:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 20:23 [RFC] Hack to avoid C-state reduction during graphics activity Eric Anholt
2010-11-01 20:23 ` [PATCH 1/4] sched: Export io_schedule_timeout() Eric Anholt
2010-11-01 20:23 ` [PATCH 2/4] Add io_ variants of wait_event() and wait_event_interruptible() Eric Anholt
2010-11-01 20:23 ` [PATCH 3/4] drm/i915: Declare waits on GPU as io waits, to reduce C-state reduction Eric Anholt
2010-11-01 20:23 ` [PATCH 4/4] cpuidle: Hack iowait weighting to avoid C-state reduction for graphics Eric Anholt
2010-11-02 12:20   ` ykzhao [this message]
2010-11-02 15:42     ` Eric Anholt
2010-11-02 20:00       ` [Intel-gfx] " Alexey Fisher
2010-11-02 20:44         ` Chris Wilson
2010-11-01 21:00 ` [RFC] Hack to avoid C-state reduction during graphics activity Andrew Lutomirski
2010-11-01 21:43   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288700414.26046.18.camel@localhost.localdomain \
    --to=yakui.zhao@intel.com \
    --cc=arjan@linxu.intel.com \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox