From: Chris Wilson <chris@chris-wilson.co.uk>
To: Alexey Fisher <bug-track@fisher-privat.net>,
Eric Anholt <eric@anholt.net>
Cc: linux-acpi@vger.kernel.org,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
arjan@linux.intel.com
Subject: Re: [Intel-gfx] [PATCH 4/4] cpuidle: Hack iowait weighting to avoid C-state reduction for graphics.
Date: Tue, 02 Nov 2010 20:44:11 +0000 [thread overview]
Message-ID: <c6d829$pduqrb@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1288728031.3031.7.camel@zwerg>
On Tue, 02 Nov 2010 21:00:31 +0100, Alexey Fisher <bug-track@fisher-privat.net> wrote:
> If this patches about perforamnce issue on 9450gm and sleep state on
> CPU, than it do not work for me.
>
> I applied your patches on the top of 3e7b033 (drm/i915: Use the agp_size
> determined from the GTT), the 3/4 was rejected so id it manually.
>
> Same result: graphic perfomence drop on smp/ht system if cpu in C4.
Useful check. The patches proposed should only affect readback and
throttling, when the driver is stuck waiting for the GPU with the device
mutex held. The scenario with missing vblank wakeups is that it is the
application waiting in poll for the event to be sent from the driver. In
order to have an effect, we would need to prevent the CPU from dropping
below C2? C1? whilst the vblank interrupt is unmasked i.e
drm_vblank_get(). That would also hopefully have a bigger impact on both
performance and battery life for Intel GPUs/
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-11-02 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 20:23 [RFC] Hack to avoid C-state reduction during graphics activity Eric Anholt
2010-11-01 20:23 ` [PATCH 1/4] sched: Export io_schedule_timeout() Eric Anholt
2010-11-01 20:23 ` [PATCH 2/4] Add io_ variants of wait_event() and wait_event_interruptible() Eric Anholt
2010-11-01 20:23 ` [PATCH 3/4] drm/i915: Declare waits on GPU as io waits, to reduce C-state reduction Eric Anholt
2010-11-01 20:23 ` [PATCH 4/4] cpuidle: Hack iowait weighting to avoid C-state reduction for graphics Eric Anholt
2010-11-02 12:20 ` [Intel-gfx] " ykzhao
2010-11-02 15:42 ` Eric Anholt
2010-11-02 20:00 ` [Intel-gfx] " Alexey Fisher
2010-11-02 20:44 ` Chris Wilson [this message]
2010-11-01 21:00 ` [RFC] Hack to avoid C-state reduction during graphics activity Andrew Lutomirski
2010-11-01 21:43 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c6d829$pduqrb@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=arjan@linux.intel.com \
--cc=bug-track@fisher-privat.net \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox