Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Switch to use kernel standard fault injection in i915
@ 2025-11-19 15:32 Juha-Pekka Heikkila
  2025-11-19 15:32 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2025-11-19 15:32 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: Juha-Pekka Heikkila

Here taken out calls to i915_inject_probe_failure and changed to use
ALLOW_ERROR_INJECTION for the same functions.

Below functions are dropped from testing since I couldn't hit those
at module bind time, testing these would just fail the tests.
To include these in test would need to find way to cause resetting in i915
which would trigger these:

intel_gvt_init
intel_wopcm_init
intel_uc_fw_upload
intel_gt_init with expected -EIO (-EINVAL is tested)
lrc_init_wa_ctx
intel_huc_auth
guc_check_version_range
intel_uc_fw_fetch
uc_fw_xfer
__intel_uc_reset_hw
guc_enable_communication
uc_init_wopcm
..and all stages of __force_fw_fetch_failures

This is resend of the last version just to get igt changes tested.

/Juha-Pekka

Test-with: 20251118143301.510707-1-juhapekka.heikkila@gmail.com


Juha-Pekka Heikkila (1):
  drm/i915: switch to use kernel standard error injection

 .../gpu/drm/i915/display/intel_connector.c    | 14 +----
 .../drm/i915/display/intel_display_driver.c   |  5 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |  9 +--
 drivers/gpu/drm/i915/gt/intel_gt_print.h      |  5 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c           |  4 --
 drivers/gpu/drm/i915/gt/intel_wopcm.c         |  3 -
 drivers/gpu/drm/i915/gt/intel_wopcm.h         |  1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  8 +--
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        |  4 --
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 17 +-----
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 60 +------------------
 drivers/gpu/drm/i915/i915_driver.c            | 12 +---
 drivers/gpu/drm/i915/i915_params.c            |  5 --
 drivers/gpu/drm/i915/i915_params.h            |  1 -
 drivers/gpu/drm/i915/i915_pci.c               |  6 +-
 drivers/gpu/drm/i915/i915_utils.c             | 30 +---------
 drivers/gpu/drm/i915/i915_utils.h             | 22 +------
 drivers/gpu/drm/i915/intel_gvt.c              |  3 -
 drivers/gpu/drm/i915/intel_uncore.c           |  4 +-
 20 files changed, 18 insertions(+), 199 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/1] Switch to use kernel standard fault injection in i915
@ 2025-11-12 12:05 Juha-Pekka Heikkila
  2025-11-12 12:05 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
  0 siblings, 1 reply; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2025-11-12 12:05 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: Juha-Pekka Heikkila

Here taken out calls to i915_inject_probe_failure and changed to use
ALLOW_ERROR_INJECTION for the same functions.

Below functions are dropped from testing since I couldn't hit those
at module bind time, testing these would just fail the tests.
To include these in test would need to find way to cause resetting in i915
which would trigger these:

intel_gvt_init
intel_wopcm_init
intel_uc_fw_upload
intel_gt_init with expected -EIO (-EINVAL is tested)
lrc_init_wa_ctx
intel_huc_auth
guc_check_version_range
intel_uc_fw_fetch
uc_fw_xfer
__intel_uc_reset_hw
guc_enable_communication
uc_init_wopcm
..and all stages of __force_fw_fetch_failures

This is resend of the last version just to get igt changes tested.

/Juha-Pekka

Test-with: 20251111194936.444955-1-juhapekka.heikkila@gmail.com

Juha-Pekka Heikkila (1):
  drm/i915: switch to use kernel standard error injection

 .../gpu/drm/i915/display/intel_connector.c    | 14 +----
 .../drm/i915/display/intel_display_driver.c   |  5 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |  9 +--
 drivers/gpu/drm/i915/gt/intel_gt_print.h      |  5 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c           |  4 --
 drivers/gpu/drm/i915/gt/intel_wopcm.c         |  3 -
 drivers/gpu/drm/i915/gt/intel_wopcm.h         |  1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  8 +--
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        |  4 --
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 17 +-----
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 60 +------------------
 drivers/gpu/drm/i915/i915_driver.c            | 12 +---
 drivers/gpu/drm/i915/i915_params.c            |  5 --
 drivers/gpu/drm/i915/i915_params.h            |  1 -
 drivers/gpu/drm/i915/i915_pci.c               |  6 +-
 drivers/gpu/drm/i915/i915_utils.c             | 30 +---------
 drivers/gpu/drm/i915/i915_utils.h             | 22 +------
 drivers/gpu/drm/i915/intel_gvt.c              |  3 -
 drivers/gpu/drm/i915/intel_uncore.c           |  4 +-
 20 files changed, 18 insertions(+), 199 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/1] Switch to use kernel standard fault injection in i915
@ 2025-11-03 17:51 Juha-Pekka Heikkila
  2025-11-03 17:51 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
  0 siblings, 1 reply; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2025-11-03 17:51 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: Juha-Pekka Heikkila

Here taken out calls to i915_inject_probe_failure and changed to use
ALLOW_ERROR_INJECTION for the same functions.

Below functions are dropped from testing since I couldn't hit those
at module bind time, testing these would just fail the tests.
To include these in test would need to find way to cause resetting in i915
which would trigger these:

intel_gvt_init
intel_wopcm_init
intel_uc_fw_upload
intel_gt_init with expected -EIO (-EINVAL is tested)
lrc_init_wa_ctx
intel_huc_auth
guc_check_version_range
intel_uc_fw_fetch
uc_fw_xfer
__intel_uc_reset_hw
guc_enable_communication
uc_init_wopcm
..and all stages of __force_fw_fetch_failures

/Juha-Pekka

Test-with: 20251031181216.172174-1-juhapekka.heikkila@gmail.com

Juha-Pekka Heikkila (1):
  drm/i915: switch to use kernel standard error injection

 .../gpu/drm/i915/display/intel_connector.c    | 14 +----
 .../drm/i915/display/intel_display_driver.c   |  5 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |  9 +--
 drivers/gpu/drm/i915/gt/intel_gt_print.h      |  5 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c           |  4 --
 drivers/gpu/drm/i915/gt/intel_wopcm.c         |  3 -
 drivers/gpu/drm/i915/gt/intel_wopcm.h         |  1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  8 +--
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        |  4 --
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 17 +-----
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 60 +------------------
 drivers/gpu/drm/i915/i915_driver.c            | 12 +---
 drivers/gpu/drm/i915/i915_params.c            |  5 --
 drivers/gpu/drm/i915/i915_params.h            |  1 -
 drivers/gpu/drm/i915/i915_pci.c               |  6 +-
 drivers/gpu/drm/i915/i915_utils.c             | 30 +---------
 drivers/gpu/drm/i915/i915_utils.h             | 22 +------
 drivers/gpu/drm/i915/intel_gvt.c              |  3 -
 drivers/gpu/drm/i915/intel_uncore.c           |  4 +-
 20 files changed, 18 insertions(+), 199 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/1] [wip] Switch to use kernel standard fault injection in i915
@ 2025-10-15 11:29 Juha-Pekka Heikkila
  2025-10-15 11:29 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
  0 siblings, 1 reply; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2025-10-15 11:29 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: Juha-Pekka Heikkila, Jani Nikula

Here taken out calls to i915_inject_probe_failure and changed to use
ALLOW_ERROR_INJECTION for the same functions.

Below functions are dropped from testing since I couldn't hit those
at module bind time, testing these would just fail the tests.
To include these in test would need to find way to cause resetting in i915
which would trigger these:

intel_gvt_init
intel_wopcm_init
intel_uc_fw_upload
intel_gt_init with expected -EIO (-EINVAL is tested)
lrc_init_wa_ctx
intel_huc_auth
guc_check_version_range
intel_uc_fw_fetch
uc_fw_xfer
__intel_uc_reset_hw
guc_enable_communication
uc_init_wopcm
..and all stages of __force_fw_fetch_failures

wip once seen what different platforms in ci say about this
to take out related i915_inject_probe_failure infra.

/Juha-Pekka

Test-with: 20251015112002.234956-1-juhapekka.heikkila@gmail.com

Juha-Pekka Heikkila (1):
  drm/i915: switch to use kernel standard error injection

 .../gpu/drm/i915/display/intel_connector.c    | 14 +----
 .../drm/i915/display/intel_display_driver.c   |  5 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  4 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |  9 +--
 drivers/gpu/drm/i915/gt/intel_gt_print.h      |  5 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c           |  4 --
 drivers/gpu/drm/i915/gt/intel_wopcm.c         |  3 -
 drivers/gpu/drm/i915/gt/intel_wopcm.h         |  1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  8 +--
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        |  4 --
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 17 +-----
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 60 +------------------
 drivers/gpu/drm/i915/i915_driver.c            | 12 +---
 drivers/gpu/drm/i915/i915_params.c            |  5 --
 drivers/gpu/drm/i915/i915_params.h            |  1 -
 drivers/gpu/drm/i915/i915_pci.c               |  6 +-
 drivers/gpu/drm/i915/i915_utils.c             | 30 +---------
 drivers/gpu/drm/i915/i915_utils.h             | 22 +------
 drivers/gpu/drm/i915/intel_gvt.c              |  3 -
 drivers/gpu/drm/i915/intel_uncore.c           |  4 +-
 drivers/gpu/drm/xe/display/ext/i915_utils.c   | 11 ----
 21 files changed, 18 insertions(+), 210 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/1] [wip] Switch to use kernel standard fault injection in i915
@ 2025-10-10 18:40 Juha-Pekka Heikkila
  2025-10-10 18:40 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
  0 siblings, 1 reply; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2025-10-10 18:40 UTC (permalink / raw)
  To: intel-gfx; +Cc: Juha-Pekka Heikkila, Jani Nikula

Here taken out calls to i915_inject_probe_failure and changed to use
ALLOW_ERROR_INJECTION for the same functions.
intel_gvt_init and intel_wopcm_init are dropped from testing since
I couldn't hit those at module load time, testing these would just
fail the tests.

wip once seen what different platforms in ci say about this
to take out related i915_inject_probe_failure infra.

/Juha-Pekka

Test-with: 20251010183643.1634589-1-juhapekka.heikkila@gmail.com

Juha-Pekka Heikkila (1):
  drm/i915: switch to use kernel standard error injection

 drivers/gpu/drm/i915/display/intel_connector.c     | 14 ++------------
 .../gpu/drm/i915/display/intel_display_driver.c    |  5 +----
 drivers/gpu/drm/i915/gt/intel_engine_cs.c          |  4 +---
 drivers/gpu/drm/i915/gt/intel_wopcm.c              |  3 ---
 drivers/gpu/drm/i915/gt/intel_wopcm.h              |  1 +
 drivers/gpu/drm/i915/gt/uc/intel_uc.c              |  4 +---
 drivers/gpu/drm/i915/i915_driver.c                 | 12 +++---------
 drivers/gpu/drm/i915/i915_pci.c                    |  6 +-----
 drivers/gpu/drm/i915/intel_gvt.c                   |  3 ---
 drivers/gpu/drm/i915/intel_uncore.c                |  4 +---
 10 files changed, 11 insertions(+), 45 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2025-11-26 13:53 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-19 15:32 [PATCH 0/1] Switch to use kernel standard fault injection in i915 Juha-Pekka Heikkila
2025-11-19 15:32 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
2025-11-26 13:52   ` Jani Nikula
2025-11-19 20:36 ` ✓ i915.CI.BAT: success for Switch to use kernel standard fault injection in i915 (rev14) Patchwork
2025-11-20  0:50 ` ✗ i915.CI.Full: failure " Patchwork
2025-11-20 10:43 ` ✓ i915.CI.BAT: success for Switch to use kernel standard fault injection in i915 (rev15) Patchwork
2025-11-20 15:10 ` ✗ i915.CI.Full: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-11-12 12:05 [PATCH 0/1] Switch to use kernel standard fault injection in i915 Juha-Pekka Heikkila
2025-11-12 12:05 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
2025-11-03 17:51 [PATCH 0/1] Switch to use kernel standard fault injection in i915 Juha-Pekka Heikkila
2025-11-03 17:51 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
2025-10-15 11:29 [PATCH 0/1] [wip] Switch to use kernel standard fault injection in i915 Juha-Pekka Heikkila
2025-10-15 11:29 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila
2025-10-15 13:27   ` Jani Nikula
2025-10-10 18:40 [PATCH 0/1] [wip] Switch to use kernel standard fault injection in i915 Juha-Pekka Heikkila
2025-10-10 18:40 ` [PATCH 1/1] drm/i915: switch to use kernel standard error injection Juha-Pekka Heikkila

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox