public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Kenneth Graunke <kenneth@whitecape.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/i915: Remove extraneous MI_BATCHBUFFER_START from the BLT ring.
Date: Sun,  6 Nov 2011 09:51:38 -0800	[thread overview]
Message-ID: <1320601898-1376-2-git-send-email-kenneth@whitecape.org> (raw)
In-Reply-To: <1320601898-1376-1-git-send-email-kenneth@whitecape.org>

This looks like it was part of the BLT ring workaround which the prior
patch removed.  However, this is a separate patch because it changes
behavior on shipping platforms.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 8198ab3..9f11751 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1353,10 +1353,6 @@ static int blt_ring_begin(struct intel_ring_buffer *ring,
 		int ret = intel_ring_begin(ring, num_dwords+2);
 		if (ret)
 			return ret;
-
-		intel_ring_emit(ring, MI_BATCH_BUFFER_START);
-		intel_ring_emit(ring, obj->gtt_offset);
-
 		return 0;
 	} else
 		return intel_ring_begin(ring, 4);
-- 
1.7.7.1

  reply	other threads:[~2011-11-06 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-06 17:51 [PATCH 1/2] drm/i915: Remove BLT workaround for pre-production Sandybridge systems Kenneth Graunke
2011-11-06 17:51 ` Kenneth Graunke [this message]
2011-11-06 18:03   ` [PATCH 2/2] drm/i915: Remove extraneous MI_BATCHBUFFER_START from the BLT ring Daniel Vetter
2011-11-06 18:50     ` [PATCH] drm/i915/ringbuffer: kill snb blt workaround Kenneth Graunke
2011-11-06 19:14       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320601898-1376-2-git-send-email-kenneth@whitecape.org \
    --to=kenneth@whitecape.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox