From: Daniel Vetter <daniel@ffwll.ch>
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Remove extraneous MI_BATCHBUFFER_START from the BLT ring.
Date: Sun, 6 Nov 2011 19:03:18 +0100 [thread overview]
Message-ID: <20111106180318.GB3126@phenom.ffwll.local> (raw)
In-Reply-To: <1320601898-1376-2-git-send-email-kenneth@whitecape.org>
On Sun, Nov 06, 2011 at 09:51:38AM -0800, Kenneth Graunke wrote:
> This looks like it was part of the BLT ring workaround which the prior
> patch removed. However, this is a separate patch because it changes
> behavior on shipping platforms.
Nope, this should actually be part of your previous patch. ring->private
for the blt ring is only set for this gen6 preproduction-hw w/a, so this
entire if block should go. You're missing a similar if block in the ring
cleanup.
I've posted that patch a few months back, but due to the Giant Whitespace
Patch haven't yet bothered to forward port it ...
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-11-06 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 17:51 [PATCH 1/2] drm/i915: Remove BLT workaround for pre-production Sandybridge systems Kenneth Graunke
2011-11-06 17:51 ` [PATCH 2/2] drm/i915: Remove extraneous MI_BATCHBUFFER_START from the BLT ring Kenneth Graunke
2011-11-06 18:03 ` Daniel Vetter [this message]
2011-11-06 18:50 ` [PATCH] drm/i915/ringbuffer: kill snb blt workaround Kenneth Graunke
2011-11-06 19:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111106180318.GB3126@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox