public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Eugeni Dodonov <eugeni.dodonov@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch, Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: [PATCH 2/3] drm/i915: allow semaphores on SNB if DMAR is disabled
Date: Wed, 16 Nov 2011 22:17:54 -0200	[thread overview]
Message-ID: <1321489075-1322-2-git-send-email-eugeni.dodonov@intel.com> (raw)
In-Reply-To: <1321489075-1322-1-git-send-email-eugeni.dodonov@intel.com>

Semaphores cause issues when DMAR is enabled. So if we are set to per-chip
default, and we are on SNB, we can enable semaphores as long as SMAR is
disabled.

Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c            |    2 ++
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |    4 +++-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 355f1ab..565725c 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -214,6 +214,7 @@ static const struct intel_device_info intel_sandybridge_d_info = {
 	.need_gfx_hws = 1, .has_hotplug = 1,
 	.has_bsd_ring = 1,
 	.has_blt_ring = 1,
+	.enable_semaphores = 1,
 };
 
 static const struct intel_device_info intel_sandybridge_m_info = {
@@ -222,6 +223,7 @@ static const struct intel_device_info intel_sandybridge_m_info = {
 	.has_fbc = 1,
 	.has_bsd_ring = 1,
 	.has_blt_ring = 1,
+	.enable_semaphores = 1,
 };
 
 static const struct intel_device_info intel_ivybridge_d_info = {
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 094ff4c..0510735 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -32,6 +32,7 @@
 #include "i915_drv.h"
 #include "i915_trace.h"
 #include "intel_drv.h"
+#include <linux/intel-iommu.h>
 
 struct change_domains {
 	uint32_t invalidate_domains;
@@ -758,7 +759,8 @@ i915_gem_execbuffer_sync_rings(struct drm_i915_gem_object *obj,
 	if (from == NULL || to == from)
 		return 0;
 
-	if (i915_semaphores < 0 && ENABLE_SEMAPHORES(obj->base.dev))
+	/* Only enable semaphores if DMAR is disabled */
+	if (i915_semaphores < 0 && ENABLE_SEMAPHORES(obj->base.dev) && dmar_disabled)
 		enable_semaphores = 1;
 
 	/* XXX gpu semaphores are implicated in various hard hangs on SNB */
-- 
1.7.7.3

  reply	other threads:[~2011-11-17  0:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17  0:17 [PATCH 1/3] drm/i915: support for per-device semaphores settings Eugeni Dodonov
2011-11-17  0:17 ` Eugeni Dodonov [this message]
2011-11-17  0:56   ` [PATCH 2/3] drm/i915: allow semaphores on SNB if DMAR is disabled Ben Widawsky
2011-11-17  0:17 ` [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR " Eugeni Dodonov
2011-11-17  0:56   ` Ben Widawsky
2011-11-17  1:02     ` Eugeni Dodonov
2011-11-17  1:13       ` Ben Widawsky
     [not found]     ` <yunty63l1mt.fsf@aiko.keithp.com>
2011-11-17  7:00       ` Ben Widawsky
2011-11-17  9:30 ` [PATCH 1/3] drm/i915: support for per-device semaphores settings Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321489075-1322-2-git-send-email-eugeni.dodonov@intel.com \
    --to=eugeni.dodonov@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox