From: Ben Widawsky <ben@bwidawsk.net>
To: keith.packard@intel.com
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled
Date: Wed, 16 Nov 2011 23:00:42 -0800 [thread overview]
Message-ID: <20111116230042.5071006f@bwidawsk.net> (raw)
In-Reply-To: <yunty63l1mt.fsf@aiko.keithp.com>
On Wed, 16 Nov 2011 22:11:06 -0800
keith.packard@intel.com wrote:
> On Wed, 16 Nov 2011 16:56:16 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > The variable you want is: !intel_iommu_gfx_mapped
>
> From what Daniel Vetter said:
>
> > Last time I've played around with all the combinations, only
> > intel_iommu=off was good enough to prevent the hang.
> > intel_iommu=igd_off still hangs (which is what the current value
> > exported by the dmar code dopends on, iirc). If I remember things
> > correctly, intel_iommu=off also reliably works around issues for all
> > reporters (both semaphores and rc6).
>
> we need to use dmar_disabled instead of intel_iommu_gfx_mapped. Other
> places in the code use:
>
> if (no_iommu || dmar_disabled)
>
As long as he meant igfx_off, then okay... igd_off didn't immediately register
to me earlier. Sorry for the confusion.
next prev parent reply other threads:[~2011-11-17 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 0:17 [PATCH 1/3] drm/i915: support for per-device semaphores settings Eugeni Dodonov
2011-11-17 0:17 ` [PATCH 2/3] drm/i915: allow semaphores on SNB if DMAR is disabled Eugeni Dodonov
2011-11-17 0:56 ` Ben Widawsky
2011-11-17 0:17 ` [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR " Eugeni Dodonov
2011-11-17 0:56 ` Ben Widawsky
2011-11-17 1:02 ` Eugeni Dodonov
2011-11-17 1:13 ` Ben Widawsky
[not found] ` <yunty63l1mt.fsf@aiko.keithp.com>
2011-11-17 7:00 ` Ben Widawsky [this message]
2011-11-17 9:30 ` [PATCH 1/3] drm/i915: support for per-device semaphores settings Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116230042.5071006f@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keith.packard@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox