Re: [PATCH 4/5] intel_reg_dumper: Add dumping of GPU turbo regs.

From: Paul Menzel <paulepanter@users.sourceforge.net>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] intel_reg_dumper: Add dumping of GPU turbo regs.
Date: Mon, 20 Feb 2012 23:53:26 +0100	[thread overview]
Message-ID: <1329778406.8910.2.camel@mattotaupa> (raw)
In-Reply-To: <1329761042-9648-4-git-send-email-eric@anholt.net>

[-- Attachment #1.1: Type: text/plain, Size: 3280 bytes --]

Dear Eric,

Am Montag, den 20.02.2012, 10:04 -0800 schrieb Eric Anholt:
> I was interested in finding why my IVB system is not getting GPU turbo
> after suspend/resume.  The piece that looks weird to me is that
> INTERRUPT_THRESHOLD is sitting at 0, whereas pre-suspend it's
> 0x12000000.

are all of your patches in this series missing the Signed-off-by line?

> ---
>  lib/intel_reg.h          |   31 +++++++++++++++++++++++++++++++
>  tools/intel_reg_dumper.c |   20 ++++++++++++++++++++
>  2 files changed, 51 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/intel_reg.h b/lib/intel_reg.h
> index c7cd857..427efee 100644
> --- a/lib/intel_reg.h
> +++ b/lib/intel_reg.h
> @@ -3511,4 +3511,35 @@ typedef enum {
>  #define RC6p_RESIDENCY_TIME         0x13810C
>  #define RC6pp_RESIDENCY_TIME        0x138110
>  
> +#define GEN6_RPNSWREQ				0xA008
> +#define GEN6_RC_VIDEO_FREQ			0xA00C
> +#define GEN6_RC_CONTROL				0xA090

Looking at this patch in Evolution the indentation looks off for some
entries. Like the one above.

> +#define GEN6_RP_DOWN_TIMEOUT			0xA010
> +#define GEN6_RP_INTERRUPT_LIMITS		0xA014
> +#define GEN6_RPSTAT1				0xA01C
> +#define GEN6_RP_CONTROL				0xA024

Dito.

> +#define GEN6_RP_UP_THRESHOLD			0xA02C
> +#define GEN6_RP_DOWN_THRESHOLD			0xA030
> +#define GEN6_RP_CUR_UP_EI			0xA050
> +#define GEN6_RP_CUR_UP				0xA054
> +#define GEN6_RP_PREV_UP				0xA058

Dito.

> +#define GEN6_RP_CUR_DOWN_EI			0xA05C
> +#define GEN6_RP_CUR_DOWN			0xA060
> +#define GEN6_RP_PREV_DOWN			0xA064
> +#define GEN6_RP_UP_EI				0xA068
> +#define GEN6_RP_DOWN_EI				0xA06C

Dito.

> +#define GEN6_RP_IDLE_HYSTERSIS			0xA070
> +#define GEN6_RC_STATE				0xA094
> +#define GEN6_RC1_WAKE_RATE_LIMIT		0xA098
> +#define GEN6_RC6_WAKE_RATE_LIMIT		0xA09C
> +#define GEN6_RC6pp_WAKE_RATE_LIMIT		0xA0A0
> +#define GEN6_RC_EVALUATION_INTERVAL		0xA0A8
> +#define GEN6_RC_IDLE_HYSTERSIS			0xA0AC
> +#define GEN6_RC_SLEEP				0xA0B0
> +#define GEN6_RC1e_THRESHOLD			0xA0B4
> +#define GEN6_RC6_THRESHOLD			0xA0B8
> +#define GEN6_RC6p_THRESHOLD			0xA0BC
> +#define GEN6_RC6pp_THRESHOLD			0xA0C0
> +#define GEN6_PMINTRMSK				0xA168
> +
>  #endif /* _I810_REG_H */
> diff --git a/tools/intel_reg_dumper.c b/tools/intel_reg_dumper.c
> index c5249cb..9f281eb 100644
> --- a/tools/intel_reg_dumper.c
> +++ b/tools/intel_reg_dumper.c
> @@ -1826,6 +1826,23 @@ _intel_dump_regs(struct reg_debug *regs, int count)
>  	}
>  }
>  
> +DEBUGSTRING(gen6_rp_control)
> +{
> +	snprintf(result, len, "%s",
> +		 (val & (1 << 7)) ? "enabled" : "disabled");
> +}
> +
> +static struct reg_debug gen6_rp_debug_regs[] = {
> +	DEFINEREG2(GEN6_RP_CONTROL, gen6_rp_control),
> +	DEFINEREG(GEN6_RPNSWREQ),
> +	DEFINEREG(GEN6_RP_DOWN_TIMEOUT),
> +	DEFINEREG(GEN6_RP_INTERRUPT_LIMITS),
> +	DEFINEREG(GEN6_RP_UP_THRESHOLD),
> +	DEFINEREG(GEN6_RP_UP_EI),
> +	DEFINEREG(GEN6_RP_DOWN_EI),
> +	DEFINEREG(GEN6_RP_IDLE_HYSTERSIS),
> +};
> +
>  static void
>  intel_dump_other_regs(void)
>  {
> @@ -2097,5 +2114,8 @@ int main(int argc, char** argv)
>  		intel_dump_other_regs();
>  	}
>  
> +	if (IS_GEN6(devid) || IS_GEN7(devid))
> +		intel_dump_regs(gen6_rp_debug_regs);
> +
>  	return 0;
>  }

Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx