From: Eric Anholt <eric@anholt.net>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] intel_reg_dumper: Add dumping of GPU turbo regs.
Date: Tue, 21 Feb 2012 10:50:41 -0800 [thread overview]
Message-ID: <87ty2kvx4u.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1329778406.8910.2.camel@mattotaupa>
[-- Attachment #1.1: Type: text/plain, Size: 868 bytes --]
On Mon, 20 Feb 2012 23:53:26 +0100, Paul Menzel <paulepanter@users.sourceforge.net> wrote:
> Dear Eric,
>
>
> Am Montag, den 20.02.2012, 10:04 -0800 schrieb Eric Anholt:
> > I was interested in finding why my IVB system is not getting GPU turbo
> > after suspend/resume. The piece that looks weird to me is that
> > INTERRUPT_THRESHOLD is sitting at 0, whereas pre-suspend it's
> > 0x12000000.
>
> are all of your patches in this series missing the Signed-off-by line?
Signed-off-by is a linux kernel practice. Other projects don't require
it, though some people who write a lot of kernel code happen to -s their
other patches.
> Looking at this patch in Evolution the indentation looks off for some
> entries. Like the one above.
That will often be the case when you read a diff, since it has the extra
"+" or " " character at the start.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-02-21 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 18:03 [PATCH 1/5] instdone: Fix fallthroughs to invalid instdone bits on newer hardware Eric Anholt
2012-02-20 18:03 ` [PATCH 2/5] instdone: Add support for one of the IVB instdone regs Eric Anholt
2012-02-20 18:04 ` [PATCH 3/5] reg_dumper: Refactor duplicated reg-dumping code Eric Anholt
2012-02-20 18:04 ` [PATCH 4/5] intel_reg_dumper: Add dumping of GPU turbo regs Eric Anholt
2012-02-20 22:53 ` Paul Menzel
2012-02-21 18:50 ` Eric Anholt [this message]
2012-02-20 18:04 ` [PATCH 5/5] gem_ringfill: Make this actually test that all the batches executed Eric Anholt
2012-02-20 21:22 ` Chris Wilson
2012-02-20 22:05 ` Chris Wilson
2012-02-22 9:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty2kvx4u.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulepanter@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox