* [PATCH 1/1] drm/i915: fix operator precedence when enabling RC6p [not found] <CAPVoSvSvQv14dM6EWTi3YxUtxNWB8+kypDHSwkYTiWpBxL2eug@mail.gmail.com> @ 2012-02-24 1:57 ` Eugeni Dodonov 2012-02-24 17:33 ` Jesse Barnes 0 siblings, 1 reply; 2+ messages in thread From: Eugeni Dodonov @ 2012-02-24 1:57 UTC (permalink / raw) To: intel-gfx Cc: just.for.lkml, linux-kernel, Eugeni Dodonov, dri-devel, Dave Airlie As noticed by Torsten Kaiser, the operator precedence can play tricks with us here. CC: Dave Airlie <airlied@redhat.com> CC: Jesse Barnes <jbarnes@virtuousgeek.org> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e654f32..4871ba0 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -8194,7 +8194,7 @@ void gen6_enable_rps(struct drm_i915_private *dev_priv) if (intel_enable_rc6(dev_priv->dev)) rc6_mask = GEN6_RC_CTL_RC6_ENABLE | - (IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0; + ((IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0); I915_WRITE(GEN6_RC_CONTROL, rc6_mask | -- 1.7.8.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drm/i915: fix operator precedence when enabling RC6p 2012-02-24 1:57 ` [PATCH 1/1] drm/i915: fix operator precedence when enabling RC6p Eugeni Dodonov @ 2012-02-24 17:33 ` Jesse Barnes 0 siblings, 0 replies; 2+ messages in thread From: Jesse Barnes @ 2012-02-24 17:33 UTC (permalink / raw) To: Eugeni Dodonov Cc: intel-gfx, just.for.lkml, dri-devel, linux-kernel, Dave Airlie [-- Attachment #1: Type: text/plain, Size: 1163 bytes --] On Thu, 23 Feb 2012 23:57:06 -0200 Eugeni Dodonov <eugeni.dodonov@intel.com> wrote: > As noticed by Torsten Kaiser, the operator precedence can play tricks with > us here. > > CC: Dave Airlie <airlied@redhat.com> > CC: Jesse Barnes <jbarnes@virtuousgeek.org> > Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index e654f32..4871ba0 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8194,7 +8194,7 @@ void gen6_enable_rps(struct drm_i915_private *dev_priv) > > if (intel_enable_rc6(dev_priv->dev)) > rc6_mask = GEN6_RC_CTL_RC6_ENABLE | > - (IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0; > + ((IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0); > > I915_WRITE(GEN6_RC_CONTROL, > rc6_mask | ugg yeah, with the old code we'd never end up enabling rc6 at all. Pushed. Thanks, -- Jesse Barnes, Intel Open Source Technology Center [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-24 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAPVoSvSvQv14dM6EWTi3YxUtxNWB8+kypDHSwkYTiWpBxL2eug@mail.gmail.com>
2012-02-24 1:57 ` [PATCH 1/1] drm/i915: fix operator precedence when enabling RC6p Eugeni Dodonov
2012-02-24 17:33 ` Jesse Barnes
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox