From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/12] drm/i915: Clarify the semantics of tiling-changed by renaming it
Date: Wed, 18 Apr 2012 13:12:22 +0100 [thread overview]
Message-ID: <1334751163_18715@CP5-2952> (raw)
In-Reply-To: <20120418120502.GP5315@phenom.ffwll.local>
On Wed, 18 Apr 2012 14:05:02 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Apr 17, 2012 at 03:31:34PM +0100, Chris Wilson wrote:
> > Rename obj->tiling_changed to obj->fence_change so that it is clear that
> > it flags when the parameters for an active fence (including the
> > no-fence) register are changed.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I've picked up all the patches for -next up to this one. Thanks a lot for
> cleaning out the cruft here. For this patch I've got a bit confused about
> fence_changed. Chris suggested fence_dirty on irc and I like it.
I'm working on improving the comments here which will impact this and
the next patch...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-18 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:31 Kill unused fence pipelining Chris Wilson
2012-04-17 14:31 ` [PATCH 01/12] drm/i915: Remove the pipelined parameter from get_fence() Chris Wilson
2012-04-17 14:31 ` [PATCH 02/12] drm/i915: Remove fence pipelining Chris Wilson
2012-04-17 14:31 ` [PATCH 03/12] drm/i915: Remove unused ring->setup_seqno Chris Wilson
2012-04-17 14:31 ` [PATCH 04/12] drm/i915: Discard the unused obj->last_fenced_ring Chris Wilson
2012-04-17 14:31 ` [PATCH 05/12] drm/i915: Simplify fence finding Chris Wilson
2012-04-17 14:31 ` [PATCH 06/12] drm/i915: Remove the unsightly "optimisation" from flush_fence() Chris Wilson
2012-04-17 14:31 ` [PATCH 07/12] drm/i915: Prepare to consolidate fence writing Chris Wilson
2012-04-17 14:31 ` [PATCH 08/12] drm/i915: Refactor put_fence() to use the common fence writing routine Chris Wilson
2012-04-17 14:31 ` [PATCH 09/12] drm/i915: Refactor fence clearing " Chris Wilson
2012-04-17 14:31 ` [PATCH 10/12] drm/i915: Refactor get_fence() " Chris Wilson
2012-04-17 14:31 ` [PATCH 11/12] drm/i915: Clarify the semantics of tiling-changed by renaming it Chris Wilson
2012-04-18 12:05 ` Daniel Vetter
2012-04-18 12:12 ` Chris Wilson [this message]
2012-04-17 14:31 ` [PATCH 12/12] drm/i915: Only the zap the VMA after updating the tiling parameters Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334751163_18715@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox