[PATCH] drm/i915: make PCH poison interrupt debug only

[PATCH] drm/i915: make PCH poison interrupt debug only

[Jesse Barnes]

This indicates an internal messaging issue between the CPU and PCH, but
there's nothing the driver can do about it.  We seem to be able to
trigger it at hotplug time sometimes, possibly due to the interrupt
corrupting an in-flight message between CPU and PCH.  At any rate, the
error is harmless, so there's no need to bother the user about it.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/i915_irq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 967b92e..efb8d24 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -592,7 +592,7 @@ static void pch_irq_handler(struct drm_device *dev)
 		DRM_DEBUG_DRIVER("PCH transcoder audio interrupt\n");
 
 	if (pch_iir & SDE_POISON)
-		DRM_ERROR("PCH poison interrupt\n");
+		DRM_DEBUG_DRIVER("PCH poison interrupt\n");
 
 	if (pch_iir & SDE_FDI_MASK)
 		for_each_pipe(pipe)
-- 
1.7.5.4

Re: [PATCH] drm/i915: make PCH poison interrupt debug only

[Adam Jackson]

[-- Attachment #1.1: Type: text/plain, Size: 653 bytes --]

On Wed, 2012-04-18 at 10:20 -0700, Jesse Barnes wrote:
> This indicates an internal messaging issue between the CPU and PCH, but
> there's nothing the driver can do about it.  We seem to be able to
> trigger it at hotplug time sometimes, possibly due to the interrupt
> corrupting an in-flight message between CPU and PCH.  At any rate, the
> error is harmless, so there's no need to bother the user about it.

I'm unconvinced.  The bugs I've seen tend to have these messages in
combination with actual output setup problems.  If that's going to be
reliably true I'd just as soon always see the message without needing
drm.debug=7.

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx