public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Kamal Mostafa <kamal@canonical.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Robert Hooker <robert.hooker@canonical.com>
Subject: [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z
Date: Wed, 25 Apr 2012 10:28:42 -0700	[thread overview]
Message-ID: <1335374922-7905-2-git-send-email-kamal@canonical.com> (raw)
In-Reply-To: <1335374922-7905-1-git-send-email-kamal@canonical.com>

From: Robert Hooker <robert.hooker@canonical.com>

Dell XPS 13z exhibits problems (backlight flashing/pulsating) when
intel_backlight is enabled at all, so disable it.

BugLink: https://launchpad.net/bugs/954661
Signed-off-by: Robert Hooker <robert.hooker@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
 drivers/gpu/drm/i915/intel_display.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 5908cd5..0c4cac4 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9100,6 +9100,19 @@ static void quirk_ssc_force_disable(struct drm_device *dev)
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	dev_priv->quirks |= QUIRK_LVDS_SSC_DISABLE;
 }
+ 
+/*
+ * Some machines (Dell XPS 13z) exhibit problems with i915 control of the
+ * backlight registers; Others may need the intel_backlight interface
+ * disabled for some other reason.
+ */
+static void quirk_backlight_disable(struct drm_device *dev)
+{
+	if (i915_enable_backlight == -1) {
+	    i915_enable_backlight = 0;
+	    DRM_DEBUG_DRIVER("disabling intel_backlight interface via quirk\n");
+	}
+}
 
 struct intel_quirk {
 	int device;
@@ -9133,6 +9146,10 @@ struct intel_quirk intel_quirks[] = {
 
 	/* Sony Vaio Y cannot use SSC on LVDS */
 	{ 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
+
+	/* Dell XPS 13z needs to disable the intel_backlight interface
+	   (LP: #954661) */
+	{ 0x0116, 0x1028, 0x052e, quirk_backlight_disable },
 };
 
 static void intel_init_quirks(struct drm_device *dev)
-- 
1.7.5.4

  reply	other threads:[~2012-04-25 17:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 17:28 [PATCH 1/2] drm/i915: i915.enable_backlight=0 disables intel_backlight Kamal Mostafa
2012-04-25 17:28 ` Kamal Mostafa [this message]
2012-04-27 20:56   ` [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z Kamal Mostafa
2012-04-27 21:25     ` Daniel Vetter
2012-04-27 21:55       ` Kamal Mostafa
2012-05-14 18:54         ` Kamal Mostafa
2012-04-26 20:07 ` [PATCH 1/2] drm/i915: i915.enable_backlight=0 disables intel_backlight Daniel Vetter
2012-04-27 20:55   ` Kamal Mostafa
2012-05-14 18:53   ` Kamal Mostafa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335374922-7905-2-git-send-email-kamal@canonical.com \
    --to=kamal@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=robert.hooker@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox