* [PATCH] drm/i915: disable gmbus on i830
@ 2012-05-13 12:44 Daniel Vetter
2012-05-13 14:15 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2012-05-13 12:44 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
The hw just returns garbage.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49838
Reported-and-tested-by: Vladyslav <DFEW.Entwickler@googlemail.com>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_i2c.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index e04255e..4a9707d 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -490,6 +490,10 @@ int intel_setup_gmbus(struct drm_device *dev)
/* By default use a conservative clock rate */
bus->reg0 = port | GMBUS_RATE_100KHZ;
+ /* gmbus seems to be broken on i830 */
+ if (IS_I830(dev))
+ bus->force_bit = true;
+
intel_gpio_setup(bus, port);
}
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: disable gmbus on i830
2012-05-13 12:44 [PATCH] drm/i915: disable gmbus on i830 Daniel Vetter
@ 2012-05-13 14:15 ` Chris Wilson
2012-05-13 14:18 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-05-13 14:15 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
On Sun, 13 May 2012 14:44:20 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The hw just returns garbage.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49838
> Reported-and-tested-by: Vladyslav <DFEW.Entwickler@googlemail.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I would prefer to have a solid reason as to whether it is the machine or
the chipset. However, I'm not going to lose sleep over 830gm not being
able to use GMBUS.
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: disable gmbus on i830
2012-05-13 14:15 ` Chris Wilson
@ 2012-05-13 14:18 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-05-13 14:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, Intel Graphics Development
On Sun, May 13, 2012 at 03:15:07PM +0100, Chris Wilson wrote:
> On Sun, 13 May 2012 14:44:20 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > The hw just returns garbage.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49838
> > Reported-and-tested-by: Vladyslav <DFEW.Entwickler@googlemail.com>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I would prefer to have a solid reason as to whether it is the machine or
> the chipset. However, I'm not going to lose sleep over 830gm not being
> able to use GMBUS.
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Exactly my thinking - i830 is not worth fighting for much. Patch merged.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-13 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-13 12:44 [PATCH] drm/i915: disable gmbus on i830 Daniel Vetter
2012-05-13 14:15 ` Chris Wilson
2012-05-13 14:18 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox