From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>,
Robert Lowery <rglowery@exemail.com.au>,
Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Fix GM965 TV out regression
Date: Sat, 19 May 2012 20:06:41 +0100 [thread overview]
Message-ID: <1337454405_124852@CP5-2952> (raw)
In-Reply-To: <20120519183820.GC4721@phenom.ffwll.local>
On Sat, 19 May 2012 20:38:20 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, May 19, 2012 at 04:52:10PM +1000, Robert Lowery wrote:
> > Could someone please apply the following which I have confirmed re-fixes
> > the issue for my TV output via component video connection.
> Rodrigo, can you please check this patch with the docs and maybe quickly
> run it?
The patch looks reasonable (just lacking a POSTING_READ prior to the
wait as that is not guaranteed by the wait). My guess would be that we
need a vblank to be sure that the writes latched and we indeed switched
off the detection mode prior to turning the pipe off. Not sure how that
results in ghost TV detection, and so it would be good to capture any
final explanation as a code comment to make sure that the wait isn't
deleted again in future.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-19 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 6:52 [PATCH] Fix GM965 TV out regression Robert Lowery
2012-05-19 18:38 ` Daniel Vetter
2012-05-19 19:06 ` Chris Wilson [this message]
2012-05-20 1:45 ` Robert Lowery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337454405_124852@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rglowery@exemail.com.au \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox