From: Daniel Vetter <daniel@ffwll.ch>
To: Robert Lowery <rglowery@exemail.com.au>,
Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Fix GM965 TV out regression
Date: Sat, 19 May 2012 20:38:20 +0200 [thread overview]
Message-ID: <20120519183820.GC4721@phenom.ffwll.local> (raw)
In-Reply-To: <05c042c394bc08c0625c8661eb2782d7.squirrel@webmail.exetel.com.au>
On Sat, May 19, 2012 at 04:52:10PM +1000, Robert Lowery wrote:
> I recently upgraded to ubuntu 12.04 and noticed the TV out no longer works
> with kernel 3.2.0.
>
> Tracing back through old kernels, I found the last working kernel was 2.6.35.
>
> Now 4 years ago I fixed a similar issue in the user space intel driver by
> waiting for vblank after writing to the TV_CTL register via
> http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/src/i830_tv.c?id=1142be53eb8d2ee8a9b60ace5d49f0ba27332275
>
> Low and behold, it appears 2 years later this same issue was reintroduced
> in kernel 2.6.36 and has led to some very unhappy users eg
> https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/763688
>
> Could someone please apply the following which I have confirmed re-fixes
> the issue for my TV output via component video connection.
Nice piece of diggin through code! A few minor nitpicks on the patch:
- sob-line is missing (see Documentation/SubmittingPatches)
- are there any other people who have tested this patch? If so, please
include them in the patch with a
Tested-by: Name <mail@server>
Rodrigo, can you please check this patch with the docs and maybe quickly
run it?
Thanks, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-05-19 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 6:52 [PATCH] Fix GM965 TV out regression Robert Lowery
2012-05-19 18:38 ` Daniel Vetter [this message]
2012-05-19 19:06 ` Chris Wilson
2012-05-20 1:45 ` Robert Lowery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519183820.GC4721@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rglowery@exemail.com.au \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox